similar to: [PATCH] Lguest32 print hex on bad reads and writes

This is taken from the work I did on lguest64. When killing a guest, we read the guest stack to do a nice back trace of the guest and send it via printk to the host. So instead of just getting an error message from the lguest launcher of: lguest: bad read address 537012178 len 1 I also get in my dmesg: called from [<c0405f30>] show_trace_log_lvl+0x1a/0x2f [<c04069aa>]

This is taken from the work I did on lguest64. When killing a guest, we read the guest stack to do a nice back trace of the guest and send it via printk to the host. So instead of just getting an error message from the lguest launcher of: lguest: bad read address 537012178 len 1 I also get in my dmesg: called from [<c0405f30>] show_trace_log_lvl+0x1a/0x2f [<c04069aa>]

Christoph Hellwig said runs sparse: 1) page_tables.c unnecessary initialization 2) Change prototype of run_lguest and do cast in caller instead (when we add __user to cast, it runs over another line). Al Viro pointed out the ugly cast in push_lguest_stack(): 3) Stick with unsigned long for arg, removes 4 casts in total. Most importantly, I now realize that Christoph's incorrect ranting

Christoph Hellwig said runs sparse: 1) page_tables.c unnecessary initialization 2) Change prototype of run_lguest and do cast in caller instead (when we add __user to cast, it runs over another line). Al Viro pointed out the ugly cast in push_lguest_stack(): 3) Stick with unsigned long for arg, removes 4 casts in total. Most importantly, I now realize that Christoph's incorrect ranting

[Bug that was found by my previous patch] This patch allows things like modules, which don't have a direct __pa(EIP) mapping to do emulated instructions. Sure, the emulated instruction probably should be a paravirt_op, but this patch lets you at least boot a kernel that has modules needing emulated instructions. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Index:

[Bug that was found by my previous patch] This patch allows things like modules, which don't have a direct __pa(EIP) mapping to do emulated instructions. Sure, the emulated instruction probably should be a paravirt_op, but this patch lets you at least boot a kernel that has modules needing emulated instructions. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Index:

From: Rusty Russell <rusty@rustcorp.com.au> This is the code for the "lg.ko" module, which allows lguest guests to be launched. [akpm@linux-foundation.org: update for futex-new-private-futexes] Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Cc: Andi Kleen <ak@suse.de> Cc: Eric Dumazet <dada1@cosmosbay.com> Signed-off-by: Andrew Morton

From: Rusty Russell <rusty@rustcorp.com.au> This is the code for the "lg.ko" module, which allows lguest guests to be launched. [akpm@linux-foundation.org: update for futex-new-private-futexes] Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Cc: Andi Kleen <ak@suse.de> Cc: Eric Dumazet <dada1@cosmosbay.com> Signed-off-by: Andrew Morton

Hi, this version requires that host and guest have the same PAE status. NX cap is not offered to the guest, yet. Thanks, Matias Lguest PAE support Signed-off-by: Matias Zabaljauregui <zabaljauregui at gmail.com> --- Documentation/lguest/lguest.txt | 1 - arch/x86/include/asm/lguest.h | 7 +- arch/x86/include/asm/lguest_hcall.h | 3 +- arch/x86/lguest/Kconfig

Hi, this version requires that host and guest have the same PAE status. NX cap is not offered to the guest, yet. Thanks, Matias Lguest PAE support Signed-off-by: Matias Zabaljauregui <zabaljauregui at gmail.com> --- Documentation/lguest/lguest.txt | 1 - arch/x86/include/asm/lguest.h | 7 +- arch/x86/include/asm/lguest_hcall.h | 3 +- arch/x86/lguest/Kconfig

Hi, For some days I have been looking for the bug that causes an easily reproducible oops in the guest when I apply my PAE support _draft_ patch (appended at the end of this mail) to lguest. This is the oops: Setting kernel variables...done. Will now mount local filesystems:. Will now activate swapfile swap:done. Cleaning /tmp... [ 84.749676] BUG: unable to handle kernel NULL pointer

Hi, For some days I have been looking for the bug that causes an easily reproducible oops in the guest when I apply my PAE support _draft_ patch (appended at the end of this mail) to lguest. This is the oops: Setting kernel variables...done. Will now mount local filesystems:. Will now activate swapfile swap:done. Cleaning /tmp... [ 84.749676] BUG: unable to handle kernel NULL pointer

The assumption that we have an overall irqs_pending flags, and a one-to-one lguest <-> task mapping fails to hold on x86_64, where we can have multiple puppies, aka vcpus. Although ifdefs could be used, it makes the code much more unreadable, and other ports are on the way, anyway. So some sort of acessor is preferred anyway. Signed-off-by: Glauber de Oliveira Costa

The assumption that we have an overall irqs_pending flags, and a one-to-one lguest <-> task mapping fails to hold on x86_64, where we can have multiple puppies, aka vcpus. Although ifdefs could be used, it makes the code much more unreadable, and other ports are on the way, anyway. So some sort of acessor is preferred anyway. Signed-off-by: Glauber de Oliveira Costa

plain text document attachment (lguest64.patch) This is the main core code for the lguest64. Have fun, and don't hurt the puppies! Signed-off-by: Steven Rostedt <srostedt@redhat.com> Signed-off-by: Glauber de Oliveira Costa <glommer@gmail.com> Cc: Chris Wright <chrisw@sous-sol.org> Index: work-pv/arch/x86_64/lguest/Makefile

plain text document attachment (lguest64.patch) This is the main core code for the lguest64. Have fun, and don't hurt the puppies! Signed-off-by: Steven Rostedt <srostedt@redhat.com> Signed-off-by: Glauber de Oliveira Costa <glommer@gmail.com> Cc: Chris Wright <chrisw@sous-sol.org> Index: work-pv/arch/x86_64/lguest/Makefile

plain text document attachment (lguest64-device.patch) We started working a little bit on the devices for lguest64. This is still very much a work-in-progress and needs much more work. Signed-off-by: Steven Rostedt <srostedt@redhat.com> Signed-off-by: Glauber de Oliveira Costa <glommer@gmail.com> Cc: Chris Wright <chrisw@sous-sol.org> Index:

plain text document attachment (lguest64-device.patch) We started working a little bit on the devices for lguest64. This is still very much a work-in-progress and needs much more work. Signed-off-by: Steven Rostedt <srostedt@redhat.com> Signed-off-by: Glauber de Oliveira Costa <glommer@gmail.com> Cc: Chris Wright <chrisw@sous-sol.org> Index:

Hi all, Gratefully-received recent feedback from CC'd was applied to excellent effect (and the advice from Matt Mackall about my personal appearance is best unrequited). The patch is split in 5 parts to correspond with the 9 parts Andrew sent out before, but here's the summary: 1) Sparse (thanks Christoph Hellwig): - lguest_const can be static now - lguest.c should include

Hi all, Gratefully-received recent feedback from CC'd was applied to excellent effect (and the advice from Matt Mackall about my personal appearance is best unrequited). The patch is split in 5 parts to correspond with the 9 parts Andrew sent out before, but here's the summary: 1) Sparse (thanks Christoph Hellwig): - lguest_const can be static now - lguest.c should include