similar to: Use of virtio device IDs

From: Anthony Liguori <aliguori at amazon.com> See https://issues.oasis-open.org/browse/VIRTIO-16 although it was prematurely closed. Red Hat has non-redistributable Windows drivers and Microsoft will not allow anyone else to WHQL certify drivers using that vendor ID. That makes it impossible to use virtio drivers with a Windows guest without changing the vendor ID. Cc: Matt Wilson

From: Anthony Liguori <aliguori at amazon.com> See https://issues.oasis-open.org/browse/VIRTIO-16 although it was prematurely closed. Red Hat has non-redistributable Windows drivers and Microsoft will not allow anyone else to WHQL certify drivers using that vendor ID. That makes it impossible to use virtio drivers with a Windows guest without changing the vendor ID. Cc: Matt Wilson

Hi Michael, On Mon, Sep 15, 2014 at 1:20 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Sun, Sep 14, 2014 at 08:29:33PM -0700, Anthony Liguori wrote: >> From: Anthony Liguori <aliguori at amazon.com> >> >> See https://issues.oasis-open.org/browse/VIRTIO-16 although it >> was prematurely closed. > > The reason it was closed is described in the

Hi Michael, On Mon, Sep 15, 2014 at 1:20 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Sun, Sep 14, 2014 at 08:29:33PM -0700, Anthony Liguori wrote: >> From: Anthony Liguori <aliguori at amazon.com> >> >> See https://issues.oasis-open.org/browse/VIRTIO-16 although it >> was prematurely closed. > > The reason it was closed is described in the

Anthony Liguori <aliguori at us.ibm.com> writes: > 4) Do virtio-pcie, make it PCI-e friendly (drop the IO BAR completely), give > it a new device/vendor ID. Continue to use virtio-pci for existing > devices potentially adding virtio-{net,blk,...}-pcie variants for > people that care to use them. Now you have a different compatibility problem; how do you know the guest

Anthony Liguori <aliguori at us.ibm.com> writes: > 4) Do virtio-pcie, make it PCI-e friendly (drop the IO BAR completely), give > it a new device/vendor ID. Continue to use virtio-pci for existing > devices potentially adding virtio-{net,blk,...}-pcie variants for > people that care to use them. Now you have a different compatibility problem; how do you know the guest

The virtio modules do not advertise themselves as GPL but rely on exported GPL symbols. This makes them unloadable as modules. This patch adds the appropriate MODULE_LICENSE(). Signed-off: Anthony Liguori <aliguori@us.ibm.com> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 54a8017..8f6040d 100644 --- a/drivers/block/virtio_blk.c +++

The virtio modules do not advertise themselves as GPL but rely on exported GPL symbols. This makes them unloadable as modules. This patch adds the appropriate MODULE_LICENSE(). Signed-off: Anthony Liguori <aliguori@us.ibm.com> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 54a8017..8f6040d 100644 --- a/drivers/block/virtio_blk.c +++

On Wed, Jun 05, 2013 at 10:46:15AM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > > On Wed, Jun 05, 2013 at 10:08:37AM -0500, Anthony Liguori wrote: > >> "Michael S. Tsirkin" <mst at redhat.com> writes: > >> > >> > On Wed, Jun 05, 2013 at 07:59:33AM -0500, Anthony Liguori wrote: >

On Wed, Jun 05, 2013 at 10:46:15AM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > > On Wed, Jun 05, 2013 at 10:08:37AM -0500, Anthony Liguori wrote: > >> "Michael S. Tsirkin" <mst at redhat.com> writes: > >> > >> > On Wed, Jun 05, 2013 at 07:59:33AM -0500, Anthony Liguori wrote: >

Michael S. Tsirkin <mst at redhat.com> wrote: > Move everything dealing with legacy devices out to virtio_pci_legacy.c. > Expose common code APIs in virtio_pci.h > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> This breaks virtio_pci because you deleted the licence from it. -- >8 -- Subject: virtio_pci: Restore module licence and other attributes When the

Michael S. Tsirkin <mst at redhat.com> wrote: > Move everything dealing with legacy devices out to virtio_pci_legacy.c. > Expose common code APIs in virtio_pci.h > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> This breaks virtio_pci because you deleted the licence from it. -- >8 -- Subject: virtio_pci: Restore module licence and other attributes When the

From: Anthony Liguori <aliguori at amazon.com> If MSI-X initialization fails after setting msix_enabled = 1, then the device is left in an inconsistent state. This would normally only happen if there was a bug in the device emulation but it still should be handled correctly. Cc: Matt Wilson <msw at amazon.com> Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael Tsirkin

From: Anthony Liguori <aliguori at amazon.com> If MSI-X initialization fails after setting msix_enabled = 1, then the device is left in an inconsistent state. This would normally only happen if there was a bug in the device emulation but it still should be handled correctly. Cc: Matt Wilson <msw at amazon.com> Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael Tsirkin

On Mon, Jun 03, 2013 at 09:56:15AM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: > >> Rusty Russell <rusty at rustcorp.com.au> writes: > >> > >> > Anthony Liguori <aliguori at us.ibm.com> writes: > >> >> Forcing a

On Mon, Jun 03, 2013 at 09:56:15AM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: > >> Rusty Russell <rusty at rustcorp.com.au> writes: > >> > >> > Anthony Liguori <aliguori at us.ibm.com> writes: > >> >> Forcing a

Qumranet let us use their PCI vendor ID, with device ids >= 0x1000. We can specify that we accept all of them in the device ID table, and then return -ENODEV in the probe routine. modprobe will load all the modules which match a given alias so we might be loaded when we're not needed, but that's the worst that can happen. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> ---

Qumranet let us use their PCI vendor ID, with device ids >= 0x1000. We can specify that we accept all of them in the device ID table, and then return -ENODEV in the probe routine. modprobe will load all the modules which match a given alias so we might be loaded when we're not needed, but that's the worst that can happen. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> ---

On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: > Rusty Russell <rusty at rustcorp.com.au> writes: > > > Anthony Liguori <aliguori at us.ibm.com> writes: > >> Forcing a guest driver change is a really big > >> deal and I see no reason to do that unless there's a compelling reason > >> to. > >> > >> So

On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: > Rusty Russell <rusty at rustcorp.com.au> writes: > > > Anthony Liguori <aliguori at us.ibm.com> writes: > >> Forcing a guest driver change is a really big > >> deal and I see no reason to do that unless there's a compelling reason > >> to. > >> > >> So