similar to: [Bridge] brctl insmod

Hello, syzbot found the following issue on: HEAD commit: 67faabbde36b selftests/bpf: Add missing prototypes for sev.. git tree: bpf-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=1381363b280000 kernel config: https://syzkaller.appspot.com/x/.config?x=5335204dcdecfda dashboard link: https://syzkaller.appspot.com/bug?extid=881d65229ca4f9ae8c84 compiler: gcc (Debian

Add four new ioctl's for the operations that can't be done through sysfs. The existing bridge ioctl's are multiplexed, and most go through SIOCDEVPRIVATE so they won't work in a mixed 32/64bit environment. The new release of bridge-utils will use these if possible, and fall back to the old interface. diff -Nru a/include/linux/if_bridge.h b/include/linux/if_bridge.h ---

In the bug reported by Syzbot, certain bridge devices would have a leaked reference created by race conditions in dev_ioctl, specifically, under SIOCBRADDIF or SIOCBRDELIF operations. The reference leak would be shown in the periodic unregister_netdevice call, which throws a warning and cause Syzbot to report a crash. Upon inspection of the logic in dev_ioctl, it seems the reference was introduced

The bridge module uses this ioctl - but in the comment in include/linux/sockios.h where it is defined says that the device private IOCTL are "deprecated" and will disappear in 2.5.X (comment by DaveM). I still see it being used in the 2.6.X bridge code - what's the story behind this? Will SIOCDEVPRIVATE disappear or its just an invalid comment because too many people/modules are

Hi, Is there any particular reason why the same physical port cannot be added to multiple bridges? Is it because of STP? If I am not using STP - can I change the code to have the same physical port in 2 VLANs? Is that a safe change? Thanks, Abhijit

The bridge code doesn't need a separate ioctl, mutex it can just use the existing RTNL mechanism. This avoids some races and deadlocks on shutdown. This is for 2.4; a similar mechanism has been in 2.6 for some time. diff -Nru a/net/bridge/br.c b/net/bridge/br.c --- a/net/bridge/br.c 2004-06-21 07:46:49 -07:00 +++ b/net/bridge/br.c 2004-06-21 07:46:49 -07:00 @@ -22,6 +22,7 @@ #include

Hi Ziqi, On 8/19/23 11:10, Ziqi Zhao wrote: > In the bug reported by Syzbot, certain bridge devices would have a > leaked reference created by race conditions in dev_ioctl, specifically, > under SIOCBRADDIF or SIOCBRDELIF operations. The reference leak would How would it leak a reference, could you elaborate? The reference is always taken and always released after the call. > be

--- openbsd-compat/port-irix.c.orig 2002-04-07 03:58:33.000000000 +0900 +++ openbsd-compat/port-irix.c 2003-05-27 02:11:07.620000380 +0900 @@ -7,6 +7,12 @@ #endif /* WITH_IRIX_PROJECT */ #ifdef WITH_IRIX_JOBS #include <sys/resource.h> +#include <optional_sym.h> +# if !defined(JLIMIT_CPU) +typedef __int64_t jid_t; +extern jid_t jlimit_startjob(char *, uid_t, char *); +# pragma

Hello, I want to add wireless capability to my Gentoo-linux based firewall/router at home, so I bought a Netgear MA311 PCI and installed the hostap package. I load the hostap_pci module and the wlan0 interface comes up fine. I can detect the signal from a wireless enabled laptop. Now I'm thinking I'm going to bridge the wlan0 interface and the eth1 interface, and run the firewall with br0

IRIX has a compatibility mechanism that lets you test for optional symbols (like jlimit_start) at run-time. I think these patches will let all all IRIX 6.5 systems build images that will test for job limit support dynamically: --- ./configure.ac Wed Feb 27 01:12:35 2002 +++ ../openssh-3.1p1/./configure.ac Thu Mar 7 15:50:21 2002 @@ -115,7 +115,7 @@ AC_DEFINE(WITH_IRIX_ARRAY)

Hi, I noticed that brctl (or more accurately, libbridge) is using the wrong path when doing various lookups in sysfs: e.g. /sys/class/net/brXXX/stp_state when it should use /sys/class/net/brXXX/bridge/stp_state. This doesn't cause any problems on most systems as it falls back to the ioctl when the sysfs attempt fails; however the ioctl method is apparently deprecated. I believe the

I've noticed for a while that # brctl showstp output is showing 0 for port_no and port_id It seems that somewhere in 2.6 sysfs land the following items got printed in hexadecimal, and brctl code was parsing for decimal only doug:/sys/class/net/eth0/brport# cat port_id 0x8001 doug:/sys/class/net/eth0/brport# cat port_no 0x1 The following patch to bridge-utils (git and 1.2 release) lets

On 8/20/23 01:50, Ziqi Zhao wrote: > On Sat, Aug 19, 2023 at 12:25:15PM +0300, Nikolay Aleksandrov wrote: > Hi Nik, > > Thank you so much for reviewing the patch and getting back to me! > >> IIRC there was no bug, it was a false-positive. The reference is held a bit >> longer but then released, so the device is deleted later. > >> If you reproduced it, is the

On Sat, Aug 19, 2023 at 12:25:15PM +0300, Nikolay Aleksandrov wrote: Hi Nik, Thank you so much for reviewing the patch and getting back to me! > IIRC there was no bug, it was a false-positive. The reference is held a bit > longer but then released, so the device is deleted later. > If you reproduced it, is the device later removed or is it really stuck? I ran the reproducer again

Hao Yu Commercial Scale Out IBM T.J. Watson Research Center 1101 Kitchawan Rd/Route 134, Rm 36-019 Yorktown Heights, NY 10598-0218 914-945-1854, Email: yuh@us.ibm.com ----- Forwarded by Hao Yu/Watson/IBM on 10/31/2006 09:52 AM ----- Jimi

Hao Yu Commercial Scale Out IBM T.J. Watson Research Center 1101 Kitchawan Rd/Route 134, Rm 36-019 Yorktown Heights, NY 10598-0218 914-945-1854, Email: yuh@us.ibm.com ----- Forwarded by Hao Yu/Watson/IBM on 10/31/2006 09:52 AM ----- Jimi

All is in subject. Example : root@harobed:~ # brctl show bridge name bridge id STP enabled interfaces root@harobed:~ # ifconfig lo Lien encap:Boucle locale inet adr:127.0.0.1 Masque:255.0.0.0 adr inet6: ::1/128 Scope:H?te UP LOOPBACK RUNNING MTU:16436 Metric:1 RX packets:16510 errors:0 dropped:0 overruns:0 frame:0

Hello CentOS, Is there a specific RPM that makes "insmod ip_conntrack_ftp" available? I've been using that on a number of servers fine, but the latest one I've built, running insmod ip_conntrack_ftp gives me: insmod: can't read 'ip_conntrack_ftp': No such file or directory -- Best regards, Mickael mailto:mike at kamloopsbc.com www.MickaelMaddison.com

Hi, I am trying to use zaptel module on an Ubuntu 5.10 distro (2.6.x kernel) using gcc 4.0.2. Compilation does not give me errors so after a 'make install' I try to load zaptel module with insmod but the following error arise: *insmod: error inserting '/lib/modules/2.6.12/misc/zaptel.ko': -1 Invalid module format* Is there anybody who can help me?? TIA Giorgio --

Am I wrong saying that actually anyone that use klibc has to use insmod patch or build a monolithic kernel? Could not the insmod patch be include? That will make everyone life easier on klibc upgrade. Gilles