similar to: [PATCH 1/6] virtio: ignore corrupted virtqueues rather than spinning.

Hello Rusty, the subject patch was part of your original patch series on January 15th. When is that planned to go upstream? Heinz On 01/04/14 04:58, Rusty Russell wrote: > The following changes since commit 33807f4f0daec3b00565c2932d95f614f5833adf: > > Merge branch 'for-next' of git://git.samba.org/sfrench/cifs-2.6 (2014-03-11 11:53:42 -0700) > > are available in the

Firstly, it isn't necessary to hold lock of vblk->vq_lock when notifying hypervisor about queued I/O. Secondly, virtqueue_notify() will cause world switch and it may take long time on some hypervisors(such as, qemu-arm), so it isn't good to hold the lock and block other vCPUs. On arm64 quad core VM(qemu-kvm), the patch can increase I/O performance a lot with VIRTIO_RING_F_EVENT_IDX

Firstly, it isn't necessary to hold lock of vblk->vq_lock when notifying hypervisor about queued I/O. Secondly, virtqueue_notify() will cause world switch and it may take long time on some hypervisors(such as, qemu-arm), so it isn't good to hold the lock and block other vCPUs. On arm64 quad core VM(qemu-kvm), the patch can increase I/O performance a lot with VIRTIO_RING_F_EVENT_IDX

For virtio-scsi multiqueue support I would like to have an easy and fast way to go from a virtqueue to the internal struct for that queue. It turns out that virtio-serial has the same need, but it gets by with a simple list walk. This patch adds a pointer to struct virtqueue that is reserved for the virtio device, and uses it in virtio-serial. Cc: Amit Shah <amit.shah at redhat.com> Cc:

For virtio-scsi multiqueue support I would like to have an easy and fast way to go from a virtqueue to the internal struct for that queue. It turns out that virtio-serial has the same need, but it gets by with a simple list walk. This patch adds a pointer to struct virtqueue that is reserved for the virtio device, and uses it in virtio-serial. Cc: Amit Shah <amit.shah at redhat.com> Cc:

From: Anthony Liguori <aliguori at us.ibm.com> virtio-pci acquires its spin lock in an interrupt context so it's necessary to use spin_lock_irqsave/restore variants. This patch fixes guest SMP when using virtio devices in KVM. Signed-off-by: Anthony Liguori <aliguori at us.ibm.com> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- drivers/virtio/virtio_pci.c |

From: Anthony Liguori <aliguori at us.ibm.com> virtio-pci acquires its spin lock in an interrupt context so it's necessary to use spin_lock_irqsave/restore variants. This patch fixes guest SMP when using virtio devices in KVM. Signed-off-by: Anthony Liguori <aliguori at us.ibm.com> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- drivers/virtio/virtio_pci.c |

They're generic concepts, so hoist them. This also avoids accessor functions. This goes even further than Jason Wang's 17bb6d4088 patch ("virtio-ring: move queue_index to vring_virtqueue") which moved the queue_index from the specific transport. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- drivers/virtio/virtio_mmio.c | 4 ++--

They're generic concepts, so hoist them. This also avoids accessor functions. This goes even further than Jason Wang's 17bb6d4088 patch ("virtio-ring: move queue_index to vring_virtqueue") which moved the queue_index from the specific transport. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- drivers/virtio/virtio_mmio.c | 4 ++--

Ming Lei <ming.lei at canonical.com> writes: > Firstly, it isn't necessary to hold lock of vblk->vq_lock > when notifying hypervisor about queued I/O. > > Secondly, virtqueue_notify() will cause world switch and > it may take long time on some hypervisors(such as, qemu-arm), > so it isn't good to hold the lock and block other vCPUs. > > On arm64 quad core

3.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ming Lei <ming.lei at canonical.com> commit e8edca6f7f92234202d6dd163c118ef495244d7c upstream. Firstly, it isn't necessary to hold lock of vblk->vq_lock when notifying hypervisor about queued I/O. Secondly, virtqueue_notify() will cause world switch and it may take long time on

3.13.11.5 -stable review patch. If anyone has any objections, please let me know. ------------------ From: Ming Lei <ming.lei at canonical.com> commit e8edca6f7f92234202d6dd163c118ef495244d7c upstream. Firstly, it isn't necessary to hold lock of vblk->vq_lock when notifying hypervisor about queued I/O. Secondly, virtqueue_notify() will cause world switch and it may take long

3.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ming Lei <ming.lei at canonical.com> commit e8edca6f7f92234202d6dd163c118ef495244d7c upstream. Firstly, it isn't necessary to hold lock of vblk->vq_lock when notifying hypervisor about queued I/O. Secondly, virtqueue_notify() will cause world switch and it may take long time on

3.13.11.5 -stable review patch. If anyone has any objections, please let me know. ------------------ From: Ming Lei <ming.lei at canonical.com> commit e8edca6f7f92234202d6dd163c118ef495244d7c upstream. Firstly, it isn't necessary to hold lock of vblk->vq_lock when notifying hypervisor about queued I/O. Secondly, virtqueue_notify() will cause world switch and it may take long

From: Mark McLoughlin <markmc at redhat.com> hdr->csum_start is the offset from the start of the ethernet header to the transport layer checksum field. skb->csum_start is the offset from skb->head. skb_partial_csum_set() assumes that skb->data points to the ethernet header - i.e. it computes skb->csum_start by adding the headroom to hdr->csum_start. Since

This is a note to let you know that I have just added a patch titled block: virtio_blk: don't hold spin lock during world switch to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree which can be found at: http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.13.y-queue This patch is scheduled to be released in version 3.13.11.5. If you, or

This is a note to let you know that I have just added a patch titled block: virtio_blk: don't hold spin lock during world switch to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree which can be found at: http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.13.y-queue This patch is scheduled to be released in version 3.13.11.5. If you, or

Jens Axboe <axboe at kernel.dk> writes: > On 2014-05-30 00:10, Rusty Russell wrote: >> Jens Axboe <axboe at kernel.dk> writes: >>> If Rusty agrees, I'd like to add it for 3.16 with a stable marker. >> >> Really stable? It improves performance, which is nice. But every patch >> which goes into the kernel fixes a bug, improves clarity, improves

Jens Axboe <axboe at kernel.dk> writes: > On 2014-05-30 00:10, Rusty Russell wrote: >> Jens Axboe <axboe at kernel.dk> writes: >>> If Rusty agrees, I'd like to add it for 3.16 with a stable marker. >> >> Really stable? It improves performance, which is nice. But every patch >> which goes into the kernel fixes a bug, improves clarity, improves

On Mon, Jun 2, 2014 at 9:23 AM, Rusty Russell <rusty at rustcorp.com.au> wrote: > Jens Axboe <axboe at kernel.dk> writes: >> On 2014-05-30 00:10, Rusty Russell wrote: >>> Jens Axboe <axboe at kernel.dk> writes: >>>> If Rusty agrees, I'd like to add it for 3.16 with a stable marker. >>> >>> Really stable? It improves