similar to: [PATCH 1/3] virtio: bus_id for devices should contain 'virtio'

An embedded and charset-unspecified text was scrubbed... Name: not available Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20080522/4684d166/attachment.txt

An embedded and charset-unspecified text was scrubbed... Name: not available Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20080522/4684d166/attachment.txt

(sent to the kvm list erroneously) -------------- next part -------------- An embedded message was scrubbed... From: Chris Lalancette <clalance at redhat.com> Subject: [PATCH]: Fix silly output for virtio devices in /proc/interrupts Date: Wed, 21 May 2008 14:51:45 +0200 Size: 4582 Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20080521/38a29f92/attachment.eml

(sent to the kvm list erroneously) -------------- next part -------------- An embedded message was scrubbed... From: Chris Lalancette <clalance at redhat.com> Subject: [PATCH]: Fix silly output for virtio devices in /proc/interrupts Date: Wed, 21 May 2008 14:51:45 +0200 Size: 4582 Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20080521/38a29f92/attachment.eml

An embedded and charset-unspecified text was scrubbed... Name: not available Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20080714/a884a437/attachment.txt

An embedded and charset-unspecified text was scrubbed... Name: not available Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20080714/a884a437/attachment.txt

An embedded and charset-unspecified text was scrubbed... Name: cpumask:convert-drivers.patch Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20090107/f459eb35/attachment.txt

An embedded and charset-unspecified text was scrubbed... Name: cpumask:convert-drivers.patch Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20090107/f459eb35/attachment.txt

If we fail to transmit a packet, we assume the queue is full and put the skb into last_xmit_skb. However, if more space frees up before we xmit it, we loop, and the result can be transmitting the same skb twice. Fix is simple: set skb to NULL if we've used it in some way, and check before sending. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- drivers/net/virtio_net.c |

If we fail to transmit a packet, we assume the queue is full and put the skb into last_xmit_skb. However, if more space frees up before we xmit it, we loop, and the result can be transmitting the same skb twice. Fix is simple: set skb to NULL if we've used it in some way, and check before sending. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- drivers/net/virtio_net.c |

On Mon, 17 Nov 2014 11:37:01 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Mon, Nov 17, 2014 at 05:17:17PM +0800, Jason Wang wrote: > > Buggy host may advertised buggy host features (a usual case is that host > > advertise a feature whose dependencies were missed). In this case, driver > > should detect and disable the buggy features by itself.

On Mon, 17 Nov 2014 11:37:01 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Mon, Nov 17, 2014 at 05:17:17PM +0800, Jason Wang wrote: > > Buggy host may advertised buggy host features (a usual case is that host > > advertise a feature whose dependencies were missed). In this case, driver > > should detect and disable the buggy features by itself.

This patch modifies virtio-console to use virtio_config_val() instead of a 'if(virtio_has_feature()) vdev->config->get()' construct to retrieve optional values from the config space. Cc: Amit Shah <amit.shah at redhat.com> Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: virtualization at

This patch modifies virtio-console to use virtio_config_val() instead of a 'if(virtio_has_feature()) vdev->config->get()' construct to retrieve optional values from the config space. Cc: Amit Shah <amit.shah at redhat.com> Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: virtualization at

An embedded and charset-unspecified text was scrubbed... Name: not available Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20080522/20e9f8d1/attachment.txt

An embedded and charset-unspecified text was scrubbed... Name: not available Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20080522/20e9f8d1/attachment.txt

Hi Rusty, The linux-next kernel was failing my virtio-console test suite for a while. I looked into it today, and it's due to the virtqueue_add_buf() change that doesn't return > 0 values anymore. I found your commit that adjusts virtio_console.c, but you missed one instance where the return value mattered, and as a result not enough buffers were queued for the host to send in data.

Hi Rusty, The linux-next kernel was failing my virtio-console test suite for a while. I looked into it today, and it's due to the virtqueue_add_buf() change that doesn't return > 0 values anymore. I found your commit that adjusts virtio_console.c, but you missed one instance where the return value mattered, and as a result not enough buffers were queued for the host to send in data.

virtio allows drivers to suppress callbacks (ie. interrupts) for efficiency (no locking, it's just an optimization). There's a similar mechanism for the host to suppress notifications coming from the guest: in that case, we ignore the suppression if the ring is completely full. It turns out that life is simpler if the host similarly ignores callback suppression when the ring is

virtio allows drivers to suppress callbacks (ie. interrupts) for efficiency (no locking, it's just an optimization). There's a similar mechanism for the host to suppress notifications coming from the guest: in that case, we ignore the suppression if the ring is completely full. It turns out that life is simpler if the host similarly ignores callback suppression when the ring is