similar to: [PATCH] virtio: don't always force a notification when ring is full

On 2018/11/8 ??9:38, Tiwei Bie wrote: >>> + >>> + if (vq->vq.num_free < descs_used) { >>> + pr_debug("Can't add buf len %i - avail = %i\n", >>> + descs_used, vq->vq.num_free); >>> + /* FIXME: for historical reasons, we force a notify here if >>> + * there are outgoing parts to the buffer. Presumably the

On 2018/11/8 ??9:38, Tiwei Bie wrote: >>> + >>> + if (vq->vq.num_free < descs_used) { >>> + pr_debug("Can't add buf len %i - avail = %i\n", >>> + descs_used, vq->vq.num_free); >>> + /* FIXME: for historical reasons, we force a notify here if >>> + * there are outgoing parts to the buffer. Presumably the

On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > > On 2018/11/8 ??9:38, Tiwei Bie wrote: > > > > > + > > > > > + if (vq->vq.num_free < descs_used) { > > > > > + pr_debug("Can't add buf len %i - avail = %i\n", > > > > > +

On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > > On 2018/11/8 ??9:38, Tiwei Bie wrote: > > > > > + > > > > > + if (vq->vq.num_free < descs_used) { > > > > > + pr_debug("Can't add buf len %i - avail = %i\n", > > > > > +

On 2018/11/8 ??10:14, Michael S. Tsirkin wrote: > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: >> On 2018/11/8 ??9:38, Tiwei Bie wrote: >>>>> + >>>>> + if (vq->vq.num_free < descs_used) { >>>>> + pr_debug("Can't add buf len %i - avail = %i\n", >>>>> + descs_used, vq->vq.num_free);

On 2018/11/8 ??10:14, Michael S. Tsirkin wrote: > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: >> On 2018/11/8 ??9:38, Tiwei Bie wrote: >>>>> + >>>>> + if (vq->vq.num_free < descs_used) { >>>>> + pr_debug("Can't add buf len %i - avail = %i\n", >>>>> + descs_used, vq->vq.num_free);

On Fri, Nov 09, 2018 at 10:30:50AM +0800, Jason Wang wrote: > > On 2018/11/8 ??11:56, Michael S. Tsirkin wrote: > > On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: > > > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > > On 2018/11/8 ??9:38, Tiwei Bie wrote: > > > > > > > + > > > > > > > + if

On Wed, Jul 11, 2018 at 10:27:09AM +0800, Tiwei Bie wrote: > This commit introduces the support (without EVENT_IDX) for > packed ring. > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > drivers/virtio/virtio_ring.c | 495 ++++++++++++++++++++++++++++++++++- > 1 file changed, 487 insertions(+), 8 deletions(-) > > diff --git

On Wed, Jul 11, 2018 at 10:27:09AM +0800, Tiwei Bie wrote: > This commit introduces the support (without EVENT_IDX) for > packed ring. > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > drivers/virtio/virtio_ring.c | 495 ++++++++++++++++++++++++++++++++++- > 1 file changed, 487 insertions(+), 8 deletions(-) > > diff --git

On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > On 2018/11/8 ??9:38, Tiwei Bie wrote: > > > > + > > > > + if (vq->vq.num_free < descs_used) { > > > > + pr_debug("Can't add buf len %i - avail = %i\n", > > > > + descs_used, vq->vq.num_free); > > > > + /* FIXME: for historical reasons, we

On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > On 2018/11/8 ??9:38, Tiwei Bie wrote: > > > > + > > > > + if (vq->vq.num_free < descs_used) { > > > > + pr_debug("Can't add buf len %i - avail = %i\n", > > > > + descs_used, vq->vq.num_free); > > > > + /* FIXME: for historical reasons, we

On Fri, Nov 09, 2018 at 10:25:28AM +0800, Jason Wang wrote: > > On 2018/11/8 ??10:14, Michael S. Tsirkin wrote: > > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > On 2018/11/8 ??9:38, Tiwei Bie wrote: > > > > > > + > > > > > > + if (vq->vq.num_free < descs_used) { > > > > > > +

On 2018/11/8 ??11:56, Michael S. Tsirkin wrote: > On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: >> On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: >>> On 2018/11/8 ??9:38, Tiwei Bie wrote: >>>>>> + >>>>>> + if (vq->vq.num_free < descs_used) { >>>>>> + pr_debug("Can't add buf len %i -

On Wed, Nov 07, 2018 at 12:48:46PM -0500, Michael S. Tsirkin wrote: > On Wed, Jul 11, 2018 at 10:27:09AM +0800, Tiwei Bie wrote: > > This commit introduces the support (without EVENT_IDX) for > > packed ring. > > > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > > --- > > drivers/virtio/virtio_ring.c | 495 ++++++++++++++++++++++++++++++++++-

Hi Paolo & Co, So I've been running into another bug with SeaBIOS w/ virtio-scsi + vhost-scsi-pci code.. During the last weeks debugging on the QEMU vhost memory re-mapping bug, my seabios builds have been using a smaller target ID (16) for scanning than the default hard coded value of 256 in init_virtio_scsi(). After bumping this value back to 256 recently, a bogus out_num value from

Hi Paolo & Co, So I've been running into another bug with SeaBIOS w/ virtio-scsi + vhost-scsi-pci code.. During the last weeks debugging on the QEMU vhost memory re-mapping bug, my seabios builds have been using a smaller target ID (16) for scanning than the default hard coded value of 256 in init_virtio_scsi(). After bumping this value back to 256 recently, a bogus out_num value from

I saw that the tx timer was removed in your patch queue but you weren't notifying when full. I decided to do it here instead of in the error case on add_buf for really no great reason other than I thought it made more sense for it to happen in the notify(). Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c

I saw that the tx timer was removed in your patch queue but you weren't notifying when full. I decided to do it here instead of in the error case on add_buf for really no great reason other than I thought it made more sense for it to happen in the notify(). Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c

>From f582caf612b446e42f1e80d5ef12c5b7322efd03 Mon Sep 17 00:00:00 2001 From: Dor Laor <dor.laor@qumranet.com> Date: Mon, 28 Jan 2008 02:09:48 +0200 Subject: [PATCH] virtio_net tx performance fix There was a problem with the location of the notify call in add_buff function: When VRING_USED_F_NO_NOTIFY is set, the host does not kick the guest when packets were transmitted, as a result the

>From f582caf612b446e42f1e80d5ef12c5b7322efd03 Mon Sep 17 00:00:00 2001 From: Dor Laor <dor.laor@qumranet.com> Date: Mon, 28 Jan 2008 02:09:48 +0200 Subject: [PATCH] virtio_net tx performance fix There was a problem with the location of the notify call in add_buff function: When VRING_USED_F_NO_NOTIFY is set, the host does not kick the guest when packets were transmitted, as a result the