similar to: [PATCH 10/10] drivers/net/xen-netfront.c: Use DIV_ROUND_UP

From: Julia Lawall <julia@diku.dk> If spin_lock_irqsave is called twice in a row with the same second argument, the interrupt state at the point of the second call overwrites the value saved by the first call. Indeed, the second call does not need to save the interrupt state, so it is changed to a simple spin_lock. The semantic match that finds this problem is as follows:

On Fri, 23 Jun 2023 23:14:39 +0200, Julia Lawall <Julia.Lawall at inria.fr> wrote: > Use array_size to protect against multiplication overflows. > > The changes were done using the following Coccinelle semantic patch: > > // <smpl> > @@ > expression E1, E2; > constant C1, C2; > identifier alloc = {vmalloc,vzalloc}; > @@ > > ( >

On Wed, Jan 11, 2012 at 04:52:36PM +0800, Zhenzhong Duan wrote: > add polling interface to xen-netfront device to support netconsole > Ian, any thoughts on the spinlock changes? > Signed-off-by: Tina.Yang <tina.yang@oracle.com> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Cc: Jeremy Fitzhardinge <jeremy@goop.org> > Signed-off-by: Zhenzhong.Duan

Dear all, I am trying to model number of samples from a given series. The series are modelled according Gamma function. In order to estimate the # samples, I use BIC/AIC with MLE (computed from dgamma function). Here is the code I have. __BEGIN__ mlogl <- function( x_func, theta_func, samp) { # computing log_likelihood return( - sum(dgamma(samp, shape = x_func, scale=theta_func, log

This patch adds a new feature called feature-split-event-channels for netfront, enabling it to handle TX and RX events separately. If netback does not support this feature, it falls back to use single event channel. Signed-off-by: Wei Liu <wei.liu2@citrix.com> Reviewed-by: David Vrabel <david.vrabel@citrix.com> --- drivers/net/xen-netfront.c | 173

Hi, The MISS 2011 workshop below is highly related to this mailing list, since VMs are some of the best-known examples of systems software. Dealing with modularity in a VM is known to be critical, yet tough, so insights, advances or experiences from the trenches are extremely welcome at our workshop. Consider participating! Thanks in advance, the MISS 2011 committee

Dear group, I want to use the mclust package on large data, and therefore I want to use a subset in the initial clustering phase. From help(mclust): k: If `k' is specified, the hierarchical clustering phase will use a sample of size `k' of the data in the initial hierarchical clustering phase. The default is to use the entire data set. m2 is a

Hi, Sorry to trouble the list - I would like to ask a question - I can't find the answer in the r-help archives. I am trying to plot 2 survival curves in different colors. What I have tried is this plot(survfit(sim.surv ~ sim.km.smpl),col="red") but both the survival curves turn red... Your advice would be most appreciated! Thank you. Min-Han

From: Julia Lawall <julia.lawall at lip6.fr> Date: Wed, 8 Jun 2016 18:15:29 +0200 (CEST) > Use BUG_ON instead of a if condition followed by BUG. > > Generated by: scripts/coccinelle/misc/bugon.cocci > > CC: Mike Rapoport <rppt at linux.vnet.ibm.com> > Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> > Signed-off-by: Fengguang Wu <fengguang.wu at

Hi julia, I think it would be better to extract the assignment out of the if clause. Then you'll get something like this: memory = ...; if (IS_ERR(memory)) { .... } so, to answer your question: no, it isn't necessary. On Tue, Nov 28, 2017 at 1:56 PM, Julia Lawall <julia.lawall at lip6.fr> wrote: > This is a false positive, but I wonder if it is really necessary to put > the

Use BUG_ON instead of a if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci CC: Mike Rapoport <rppt at linux.vnet.ibm.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> --- macvtap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/macvtap.c +++

Use BUG_ON instead of a if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci CC: Mike Rapoport <rppt at linux.vnet.ibm.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> --- macvtap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/macvtap.c +++

Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Asias He <asias at redhat.com> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> --- vsock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/vhost/vsock.c +++

Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Asias He <asias at redhat.com> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> --- vsock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/vhost/vsock.c +++

On Mon, Jan 15, 2018 at 01:47:07PM +0100, Julia Lawall wrote: > From: Fengguang Wu <fengguang.wu at intel.com> > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > drm_*_unreference() helpers. > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> > Signed-off-by:

On Tue, May 05, 2020 at 08:47:47PM +0200, Julia Lawall wrote: > Elsewhere in the file, there is a list_for_each_entry with > &vdev->resv_regions as the second argument, suggesting that > &vdev->resv_regions is the list head. So exchange the > arguments on the list_add call to put the list head in the > second argument. > > Fixes: 2a5a31487445

On Tue, May 05, 2020 at 08:47:47PM +0200, Julia Lawall wrote: > Elsewhere in the file, there is a list_for_each_entry with > &vdev->resv_regions as the second argument, suggesting that > &vdev->resv_regions is the list head. So exchange the > arguments on the list_add call to put the list head in the > second argument. > > Fixes: 2a5a31487445

From: Fengguang Wu <fengguang.wu at intel.com> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. Generated by: scripts/coccinelle/api/drm-get-put.cocci Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> --- tree: https://github.com/thierryreding/linux for-4.16/work

We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ - DEFINE_PCI_DEVICE_TABLE(i) + const

We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ - DEFINE_PCI_DEVICE_TABLE(i) + const