similar to: [PATCH] virtio_net: hook up the set-tso ethtool op

Signed-off-by: Micha? Miros?aw <mirq-linux at rere.qmqm.pl> --- drivers/net/virtio_net.c | 46 +++++++++++++++++++--------------------------- 1 files changed, 19 insertions(+), 27 deletions(-) This is an example conversion to hw_features when constraints are constant and can be detected at init time. Build tested only. diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c

Signed-off-by: Micha? Miros?aw <mirq-linux at rere.qmqm.pl> --- drivers/net/virtio_net.c | 46 +++++++++++++++++++--------------------------- 1 files changed, 19 insertions(+), 27 deletions(-) This is an example conversion to hw_features when constraints are constant and can be detected at init time. Build tested only. diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c

Hi Keir: [LINUX] netfront: Cleanup and fix TSO/GSO/CHECKSUM conditionals This patch tries to minimise the amount of code that is conditionally compiled. This is desirable (and the Linux way) as it helps to prevent people breaking code unwittingly since conditionals may hide compile problems. It also adds a missing conditional around the TSO ethtool operations. This also helps the building of

Not tested in any way. The original code for offload setting seems broken as it resets the features on every netback reconnect. This will set GSO_ROBUST at device creation time (earlier than connect time). RX checksum offload is forced on - so advertise as it is. Signed-off-by: Micha? Miros?aw <mirq-linux at rere.qmqm.pl> --- [I don't know Xen code enough to say this is correct. There

Not tested in any way. The original code for offload setting seems broken as it resets the features on every netback reconnect. This will set GSO_ROBUST at device creation time (earlier than connect time). RX checksum offload is forced on - so advertise as it is. Signed-off-by: Micha? Miros?aw <mirq-linux at rere.qmqm.pl> --- [I don't know Xen code enough to say this is correct. There

Not tested in any way. The original code for offload setting seems broken as it resets the features on every netback reconnect. This will set GSO_ROBUST at device creation time (earlier than connect time). RX checksum offload is forced on - so advertise as it is. Signed-off-by: Micha? Miros?aw <mirq-linux at rere.qmqm.pl> --- [I don't know Xen code enough to say this is correct. There

# HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1233846695 0 # Node ID 7a24febd95d5abfc03e05de7fa991b11cef14eef # Parent 4f998fd102e24daa471482730d1a3ff68faa1ad6 netback: add ethtool stat to track copied skbs. copied skbs should be rare but we have no way of verifying that. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r 4f998fd102e2 -r

We don't really have a max tx packet size limit, so allow configuring the device with up to 64k tx MTU. Signed-off-by: Mark McLoughlin <markmc at redhat.com> --- drivers/net/virtio_net.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index e6b5d6e..71ca29c 100644 --- a/drivers/net/virtio_net.c +++

We don't really have a max tx packet size limit, so allow configuring the device with up to 64k tx MTU. Signed-off-by: Mark McLoughlin <markmc at redhat.com> --- drivers/net/virtio_net.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index e6b5d6e..71ca29c 100644 --- a/drivers/net/virtio_net.c +++

[PATCH] virtio_net: Delay dropping tx skbs Cc: Mark McLoughlin <markmc at redhat.com>, virtualization at lists.linux-foundation.org, netdev at vger.kernel.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807151340.00446.rusty at rustcorp.com.au> From: Mark McLoughlin <markmc at redhat.com> On Mon, 2008-05-26 at 17:42 +1000,

[PATCH] virtio_net: Delay dropping tx skbs Cc: Mark McLoughlin <markmc at redhat.com>, virtualization at lists.linux-foundation.org, netdev at vger.kernel.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807151340.00446.rusty at rustcorp.com.au> From: Mark McLoughlin <markmc at redhat.com> On Mon, 2008-05-26 at 17:42 +1000,

From: Mark McLoughlin <markmc at redhat.com> We can handle receiving partial csums, so set the appropriate feature bit. Signed-off-by: Mark McLoughlin <markmc at redhat.com> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c

From: Mark McLoughlin <markmc at redhat.com> hdr->csum_start is the offset from the start of the ethernet header to the transport layer checksum field. skb->csum_start is the offset from skb->head. skb_partial_csum_set() assumes that skb->data points to the ethernet header - i.e. it computes skb->csum_start by adding the headroom to hdr->csum_start. Since

From: Mark McLoughlin <markmc at redhat.com> hdr->csum_start is the offset from the start of the ethernet header to the transport layer checksum field. skb->csum_start is the offset from skb->head. skb_partial_csum_set() assumes that skb->data points to the ethernet header - i.e. it computes skb->csum_start by adding the headroom to hdr->csum_start. Since

(I know you already have this, but included for completeness) From: Mark McLoughlin <markmc at redhat.com> We can handle receiving partial csums, so set the appropriate feature bit. Signed-off-by: Mark McLoughlin <markmc at redhat.com> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1

From: Mark McLoughlin <markmc at redhat.com> lguest (in rusty's use-tun-ringfd patch) assumes that the guest has updated its feature bits before setting its status to VIRTIO_CONFIG_S_DRIVER_OK. That's pretty reasonable, so let's make it so. Signed-off-by: Mark McLoughlin <markmc at redhat.com> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> ---

2.6.25-stable review patch. If anyone has any objections, please let us know. ------------------ From: Mark McLoughlin <markmc at redhat.com> commit 23cde76d801246a702e7a84c3fe3d655b35c89a1 upstream. hdr->csum_start is the offset from the start of the ethernet header to the transport layer checksum field. skb->csum_start is the offset from skb->head. skb_partial_csum_set()

From: Mark McLoughlin <markmc at redhat.com> lguest (in rusty's use-tun-ringfd patch) assumes that the guest has updated its feature bits before setting its status to VIRTIO_CONFIG_S_DRIVER_OK. That's pretty reasonable, so let's make it so. Signed-off-by: Mark McLoughlin <markmc at redhat.com> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> ---

Hi all, I am trying to compile openswitch's kernel module in a CentOS 6.4 host, but fails in rpm-check: Requires: kernel(__alloc_percpu) = 0x55f2580b kernel(__alloc_skb) = 0x25421969 kernel(__dev_get_by_index) = 0x6a6d551b kernel(__init_waitqueue_head) = 0xffc7c184 kernel(__ip_select_ident) = 0x848695b3 kernel(__kmalloc) = 0x5a34a45c kernel(__list_add) = 0x0343a1a8 kernel(__nla_put) =

Herbert tells me that returning NETDEV_TX_BUSY from hard_start_xmit is seen as a poor thing to do; we should cache the packet and stop the queue. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- drivers/net/virtio_net.c | 58 ++++++++++++++++++++++++++++++++--------------- 1 file changed, 40 insertions(+), 18 deletions(-) diff -r 26ba2dd67f46 drivers/net/virtio_net.c ---