similar to: [PATCH] drm/nouveau/dispnv04: fix null pointer dereference in nv17_tv_get_hd_modes

Reviewed-by: Lyude Paul <lyude at redhat.com> I will push this and the other patch that you sent upstream in just a moment, thanks! On Tue, 2024-06-25 at 16:10 +0800, Ma Ke wrote: > In nv17_tv_get_hd_modes(), the return value of drm_mode_duplicate() > is > assigned to mode, which will lead to a possible NULL pointer > dereference > on failure of drm_mode_duplicate(). The

In nv17_tv_get_hd_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). The same applies to drm_cvt_mode(). Add a check to avoid null pointer dereference. Signed-off-by: Ma Ke <make_ruc2021 at 163.com> --- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 4 ++++ 1 file changed, 4 insertions(+)

> In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() is > assigned to mode, which will lead to a possible NULL pointer dereference > on failure of drm_mode_duplicate(). Add a check to avoid npd. Can a wording approach (like the following) be a better change description? A null pointer is stored in the local variable ?mode? after a call of the function

In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke <make_ruc2021 at 163.com> --- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c

Reviewed-by: Lyude Paul <lyude at redhat.com> On Tue, 2024-06-25 at 16:18 +0800, Ma Ke wrote: > In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() > is > assigned to mode, which will lead to a possible NULL pointer > dereference > on failure of drm_mode_duplicate(). Add a check to avoid npd. > > Cc: stable at vger.kernel.org > Signed-off-by: Ma Ke

> In nouveau_connector_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a possible NULL pointer > dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. 1. Can a wording approach (like the following) be a better change description? A null pointer is stored in the local variable ?mode? after a call of the function

On Wed, 26 Jun 2024, Ma Ke <make24 at iscas.ac.cn> wrote: > In nouveau_connector_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a possible NULL pointer > dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. > > Signed-off-by: Ma Ke <make24 at iscas.ac.cn> > --- >

http://bugs.freedesktop.org/show_bug.cgi?id=23295 Summary: nouveau KMS: null pointer dereference if native mode is not found Product: xorg Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at

https://bugs.freedesktop.org/show_bug.cgi?id=105173 Pierre Moreau <pierre.morrow at free.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|With kernel >=4.15 nouveau |[MCP79][Regression] |- artefacts and freezes |Unhandled NULL pointer

https://bugs.freedesktop.org/show_bug.cgi?id=105173 Pierre Moreau <pierre.morrow at free.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[MCP79][Regression] |[MCP79][Regression] |Unhandled NULL pointer |Unhandled NULL pointer

If output is NULL it is not permissable to dereference it. So we should leave the respective function in this case. The inconsistency was indicated by cppcheck. No actual NULL pointer dereference was observed. Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> --- drivers/gpu/drm/virtio/virtgpu_plane.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

If output is NULL it is not permissable to dereference it. So we should leave the respective function in this case. The inconsistency was indicated by cppcheck. No actual NULL pointer dereference was observed. Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> --- drivers/gpu/drm/virtio/virtgpu_plane.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

https://bugs.freedesktop.org/show_bug.cgi?id=105173 --- Comment #12 from Nick Lee <nvlbox at gmail.com> --- > The NULL pointer dereference, or the “trapped read at 0080000000 on channel 1 > [0fbb0000 DRM] engine 00 [PGRAPH] client 03 [DISPATCH] subclient 04 [M2M_IN] > reason 00000006 [NULL_DMAOBJ]” one? "NULL pointer dereference" AND "trapped read" after

http://bugs.freedesktop.org/show_bug.cgi?id=23712 Summary: NVA0 KMS: kernel NULL pointer dereference Product: xorg Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at lists.freedesktop.org

With lightweight desktoping, the atomic modesetting seems far from robust. BUG: unable to handle kernel NULL pointer dereference at 0000000000000021 IP: dma_fence_wait_timeout+0x36/0xf0 ... Oops: 0000 [#1] SMP Modules linked in: ... nouveau ... CPU: 0 PID: 6895 Comm: Xorg Not tainted 4.10.5-1001.fc24.x86_64 #1 ... Call Trace: drm_atomic_helper_wait_for_fences+0x48/0x120 [drm_kms_helper]

https://bugs.freedesktop.org/show_bug.cgi?id=28626 Summary: Oops: kernel NULL pointer dereference in nouveau_connector_get_modes Product: xorg Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: major Priority: medium Component: Driver/nouveau

Greetings! I am trying to do a hot driver swap between the vfio-pci and nouveau drivers for my secondary Nvidia graphics card. I boot up with vfio-pci enabled. With this script I give control over the GPU to nouveau: echo "0000:01:00.0" > /sys/bus/pci/devices/0000\:01\:00.0/driver/unbind echo 0x10de 0x11c6 > /sys/bus/pci/drivers/nouveau/new_id echo 1 > /sys/bus/pci/rescan

We've just started seeing this. Anyone else? reason: BUG: unable to handle kernel NULL pointer dereference at 00000000000000b8 component: kernel count: 1 analyzer: vmcore architecture: x86_64 event_log: kernel: 3.10.0-327.18.2.el7.x86_64 last_occurrence: 1484067452 os_release: CentOS Linux release 7.3.1611 (Core) runlevel: N 3 time:

https://bugs.freedesktop.org/show_bug.cgi?id=82975 Priority: medium Bug ID: 82975 Assignee: nouveau at lists.freedesktop.org Summary: Regression: NULL pointer dereference in nouveau_fence_wait after upgrading to 10.2.6 QA Contact: xorg-team at lists.x.org Severity: major Classification: Unclassified

Hi Yury, No need for the "{" "}" since it's a single statement in the compound statement. Other than that minor style detail, this looks fine assuming it applies cleanly to trunk. Do you have commit access? Regards, -Jim On May 9, 2012, at 3:40 PM, Yury Mikhaylov wrote: > Hi all, > > Writing my own LLVM client I've noticed a potential null pointer