similar to: capabilities() could report strict-barrier

On 2nd thought, I think a better fix to the segfault is something like this: --- a/src/main/memory.c +++ b/src/main/memory.c @@ -3444,6 +3444,8 @@ R_xlen_t (XTRUELENGTH)(SEXP x) { return XTRUELENGTH(CHK2(x)); } int (IS_LONG_VEC)(SEXP x) { return IS_LONG_VEC(CHK2(x)); } const char *(R_CHAR)(SEXP x) { + if(!x) + error("de-referncing null. Check the validity of your data.");

Hi, With a fresh Rdevel r66690 (yesterday 26th) in ~/R/Rtrunk I get : ~/R/Rtrunk $ ./configure CC="gcc -std=gnu99 -fsanitize=address" CFLAGS="-fno-omit-frame-pointer -O0 -g -Wall -pedantic -mtune=native" --without-recommended-packages ~/R/Rtrunk $ make clean ~/R/Rtrunk $ make Works fine. Now adding --enable-strict-barrier to the end : ~/R/Rtrunk $ ./configure

I haven' t touched R for some 18 months, and so I have no idea if this is a recent problems or not; but it certainly did not segfault two years ago. Since it has been crashing (segfault) under 'make check-all' for over a month, I reckon I'll have to look at it myself, to have it fixed. I have been having the ' --enable-memory-profiling --enable-strict-barrier

Hello, Until last weekend, I used to build R Devel smoothly with this switch (--enable-strict-barrier) on, but now it fails on my Debian system (found the culprit after posting on r-sig-debian). Configuring and building with: ---<--------------------cut here---------------start------------------->--- tools/rsync-recommended R_PAPERSIZE=letter \ R_BATCHSAVE="--no-save

>>>>> Jan Gorecki writes: > So the unique.default is from the R tools package during checks. > I don't see those issues on CRAN checks. I cannot reproduce this locally (and have no clues about docker). Perhaps you can try to debug this on your end? And see what env_list is when the error occurs? Best -k > Exact environment where I am reproducing this issue is a

>>>>> Jan Gorecki writes: > Thank you both, > You are absolutely correct that example should be minimal, so here it is. > l = list(a=new.env(), b=new.env()) > unique(l) > Just for completeness, env_list during check that raises error > env_list <- list(baseenv(), > as.environment("package:graphics"), >

>>>>> Kurt Hornik >>>>> on Mon, 29 Jun 2020 16:13:03 +0200 writes: >>>>> Jan Gorecki writes: >> So the unique.default is from the R tools package during >> checks. I don't see those issues on CRAN checks. > I cannot reproduce this locally (and have no clues about > docker). Perhaps you can try to debug this

Thank you both, You are absolutely correct that example should be minimal, so here it is. l = list(a=new.env(), b=new.env()) unique(l) Just for completeness, env_list during check that raises error env_list <- list(baseenv(), as.environment("package:graphics"), as.environment("package:stats"), as.environment("package:utils"),

So the unique.default is from the R tools package during checks. I don't see those issues on CRAN checks. Exact environment where I am reproducing this issue is a fresh ubuntu, no R packages pre-installed docker pull registry.gitlab.com/jangorecki/dockerfiles/r-devel https://gitlab.com/jangorecki/dockerfiles/-/raw/master/r-devel/Dockerfile On Sat, Jun 27, 2020 at 12:37 AM Jan Gorecki

Hi R developers, On R-devel (2020-06-24 r78746) I am getting those two new exceptions during R check. I found a change which eventually may be related https://github.com/wch/r-source/commit/69de92b9fb1b7f2a7c8d1394b8d56050881a5465 I think this may be a regression. I grep'ed package manuals and R code for unique.default but don't see any. Usage section of the unique method looks fine as

Thanks. I have now CXX = g++ -std=c++98 in my /etc/R/Makeconf, it's picked up properly. I can only assume that the last -std= option wins if more than one are given on the same command line [1]. -Kirill [1] http://stackoverflow.com/q/40563269/946850 On 12.11.2016 03:01, Dirk Eddelbuettel wrote: > On 11 November 2016 at 23:48, Kirill M?ller wrote: > | After upgrading to Ubuntu

No packages are being loaded, or even installed. Did you try running the example on R-devel built with flags I have provided in this email? I checked now and it is required to use --enable-strict-barrier to reproduce the issue. On Tue, Jun 30, 2020 at 9:02 AM Martin Maechler <maechler at stat.math.ethz.ch> wrote: > > >>>>> Kurt Hornik > >>>>> on

>>>>> Kurt Hornik >>>>> on Tue, 30 Jun 2020 06:20:57 +0200 writes: >>>>> Jan Gorecki writes: >> Thank you both, You are absolutely correct that example >> should be minimal, so here it is. >> l = list(a=new.env(), b=new.env()) unique(l) >> Just for completeness, env_list during check that raises

Thank you Gabriel, Agree, although I think that could be relaxed in this single case and AsIs class could be ignored. Best, Jan On Sun, Mar 29, 2020 at 7:09 PM Gabriel Becker <gabembecker at gmail.com> wrote: > > Jan, > > I believe it's because it has "a non-NULL attribute other than names" as per the documentation. In this case its class of "AsIs". >

Hello, I am in the process of implementing the atomic operations and synchronization constructs in LLVM. The memory synchronization construct is described at http://llvm.org/docs/LangRef.html#int_memory_barrier and has the following problem: There are 15 variations on the memory barrier to handle the various ordering constraints desired. Most architectures however only have support for a few of

virtio_ring.h uses mb() and friends, make it pull in asm/barrier.h itself, not rely on other headers to do it. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio_ring.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h index ca3ad41..b300787 100644 --- a/include/linux/virtio_ring.h +++

virtio_ring.h uses mb() and friends, make it pull in asm/barrier.h itself, not rely on other headers to do it. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio_ring.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h index ca3ad41..b300787 100644 --- a/include/linux/virtio_ring.h +++

Hi Linus, Just making sure nothing's wrong with this pull request. If there's an issue, pls let me know! Thanks! On Wed, Jan 13, 2016 at 06:28:55PM +0200, Michael S. Tsirkin wrote: > The following changes since commit afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc: > > Linux 4.4 (2016-01-10 15:01:32 -0800) > > are available in the git repository at: > >

On x86/um CONFIG_SMP is never defined. As a result, several macros match the asm-generic variant exactly. Drop the local definitions and pull in asm-generic/barrier.h instead. This is in preparation to refactoring this code area. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Acked-by: Arnd Bergmann <arnd at arndb.de> --- arch/x86/um/asm/barrier.h | 9 +-------- 1 file

On ia64 smp_rmb, smp_wmb, read_barrier_depends, smp_read_barrier_depends and smp_store_mb() match the asm-generic variants exactly. Drop the local definitions and pull in asm-generic/barrier.h instead. This is in preparation to refactoring this code area. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- arch/ia64/include/asm/barrier.h | 10 ++-------- 1 file changed, 2