similar to: [libnbd PATCH] golang: Optionally use gofmt on generated .go files

On Fri, Aug 04, 2023 at 09:29:48AM -0500, Eric Blake wrote: > Combine my recent work on improving the generated Go output with > Tage's work on using a canonical formatter for Rust. If gofmt is > available during the build, then the generated .go files will now use > TAB indents and have proper columnar alignment; if it is not > available, the project still compiles. > >

Pipeline #958658174 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 9cb10b39 ( https://gitlab.com/nbdkit/libnbd/-/commit/9cb10b390e2def9cc7ed744382e5d68e874e1c7a ) Commit Message: golang: Optionally use gofmt on generated .go f... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline

Pipeline #958658174 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 9cb10b39 ( https://gitlab.com/nbdkit/libnbd/-/commit/9cb10b390e2def9cc7ed744382e5d68e874e1c7a ) Commit Message: golang: Optionally use gofmt on generated .go f... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline

On Tuesday, 13 August 2019 05:17:10 CEST Katsura Hiroyuki wrote: > > > 2019/08/13 1:01、Pino Toscano <ptoscano@redhat.com>のメール: > > > > On Sunday, 11 August 2019 06:42:21 CEST Hiroyuki Katsura wrote: > >> `cargo doc` will generate docs with long descriptions. > > > > This is a nice start, although most probably it will not look that good > >

> 2019/08/13 1:01、Pino Toscano <ptoscano@redhat.com>のメール: > > On Sunday, 11 August 2019 06:42:21 CEST Hiroyuki Katsura wrote: >> `cargo doc` will generate docs with long descriptions. > > This is a nice start, although most probably it will not look that good > though (since the plain text output may be misrendered as markdown). > > I remember we talked about

This feature is roughly finished now, although it needs a few more tests and some examples. It's pretty much up to par with all the other bindings, but it lacks a completely safe AIO buffer. It won't stop you from freeing the buffer too early) because golang's GC inexplicably lacks a way to declare a root from C. I can probably do it with a global variable and ref counting on the

There are few more things that could be cleaned up related to the coding style and other things, like explicitly specifying the abi style after "extern" (i.e. `extern "C" fn` instead of `extern fn`), but since those are configurable in rustfmt config, I'm not sure whether the config needs to be added or complying with the defaults should be the priority. But this was just

> Can you explain which errors did you get? I tried pod2markdown on a > couple of API longdesc's, and the result seemed OK. > Most probably we will need to write our own pod2markdown though, as > pod2markdown does not allow users to customize all the options that > the Pod::Markdown module has. Yes. Most of the results seemed OK. But, for example, translating

Now runs a complete set of tests, notably including the AIO test. File descriptors are passed in and out as plain ints (instead of *os.File) for a couple of reasons: (1) We have to pass the plain int to syscall.Select. (2) Turning an fd into an os.File causes golang to set the blocking flag which is deeply unhelpful. Rich.

Partially downloaded file is not deleted on exit anymore. There is a check for partially downloaded image in cache directory based on its name. When found, download_to crafts appropriate options to continue its download. --- builder/downloader.ml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/builder/downloader.ml b/builder/downloader.ml index

This commit, which is just code motion, moves the common XDR protocol code (libprotocol) and the common errno handling (liberrnostring) into libraries which are each built once and shared between the library and daemon. --- .gitignore | 20 +++++-------- Makefile.am | 1 + common/errnostring/Makefile.am | 45 +++++++++++++++++++++++++++++

Generate test-prep.sh using the generator, so the prepared disk types tested are the same as the ones configured in prepopts.ml. --- .gitignore | 1 + fish/test-prep.sh | 35 ----------------------------------- generator/fish.ml | 33 +++++++++++++++++++++++++++++++++ generator/fish.mli | 1 + generator/main.ml | 1 + 5 files changed, 36 insertions(+), 35 deletions(-) delete mode

I managed to get a build of the async Rust handle compiling on FreeBSD (although the cirrus CI appears to not actually run 'make check' on non-Linux machines, at least when run on my fork): https://gitlab.com/ebblake/libnbd/-/jobs/4985192286 However, I'd really like Tage's review on patch 2 to see if my Rust makes sense. Eric Blake (2): maint: Favor 4-space indent in .rs files

Generate a simple bindtests test for the PHP binding, so it is possible to easily test all the argument types. Unlike the bindtests for other languages, optional arguments are not tested, due to the limitations of optional arguments in PHP (or maybe they way we implement them). --- .gitignore | 1 + generator/bindtests.ml | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++

These are now passed using a curl configuration file, which is a little bit safer than using command lines. virt-builder doesn't need to pass usernames and passwords to curl, but if it ever does in future this will be a lot safer. --- builder/Makefile.am | 1 + builder/builder.ml | 6 +-- builder/downloader.ml | 94

Rename the existing tests according to the naming/numbering described in guestfs-hacking(1), and improve the current ones: - guestfs_php_001.phpt: rename to guestfs_020_create.phpt - guestfs_php_003.phpt: rename to guestfs_070_optargs.phpt - guestfs_php_bindtests.phpt: rename to guestfs_090_bindtests.phpt - guestfs_091_version.phpt: new, checks taken from the former guestfs_php_002.phpt -

Put in a list the errnos to expose, filling the content of the Guestfs.Errno submodule from that. Also, generate a separate guestfs-c-errnos.c with the implementations of the functions returning the errno codes. Only code motion and refactoring, no actual changes on the content of the ocaml Guestfs module. --- .gitignore | 1 + generator/main.ml | 1 + generator/ocaml.ml | 77

Just code motion. This commit makes it clearer what is a utility and what is part of the library. It also makes it clear that we should rename: guestfs-internal-frontend.h -> utils.h guestfs-internal-frontend-cleanups.h -> cleanups.h (?) but this commit does not make that change. --- .gitignore | 10 ++--- Makefile.am

Create a new guestfs-private.h header, and move there the definitions of all the actions with visibility VInternal, and all the private structs: they are not meant to be used, not even seen, outside of the library. Include the new header where needed, which means also a couple of places outside the library (but they are tests, so it is acceptable for now). The result of this is mostly motion of

This was only used inside the library, so move it there. --- .gitignore | 2 +- common/utils/Makefile.am | 4 +--- common/utils/guestfs-internal-frontend.h | 12 ------------ docs/C_SOURCE_FILES | 2 +- generator/UEFI.ml | 3 ++- generator/main.ml | 2 +- lib/Makefile.am