similar to: [PATCH RFC net-next v5 10/14] virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

On Sat, Sep 02, 2023 at 04:56:42AM +0000, Bobby Eshleman wrote: > On Fri, Sep 01, 2023 at 02:45:14PM +0200, Stefano Garzarella wrote: > > On Tue, Aug 29, 2023 at 09:29:45PM +0000, Bobby Eshleman wrote: > > > This adds support for datagrams to the virtio-vsock device. > > > > > > virtio-vsock already supports stream and seqpacket types. The existing > >

On Sat, Sep 02, 2023 at 04:56:42AM +0000, Bobby Eshleman wrote: > On Fri, Sep 01, 2023 at 02:45:14PM +0200, Stefano Garzarella wrote: > > On Tue, Aug 29, 2023 at 09:29:45PM +0000, Bobby Eshleman wrote: > > > This adds support for datagrams to the virtio-vsock device. > > > > > > virtio-vsock already supports stream and seqpacket types. The existing > >

On Sat, Sep 02, 2023 at 09:24:26AM +0000, Bobby Eshleman wrote: > On Sat, Sep 02, 2023 at 04:41:28AM -0400, Michael S. Tsirkin wrote: > > On Sat, Sep 02, 2023 at 04:37:19AM +0000, Bobby Eshleman wrote: > > > On Fri, Sep 01, 2023 at 09:31:03AM -0400, Michael S. Tsirkin wrote: > > > > On Wed, Aug 30, 2023 at 12:43:03AM +0000, Bobby Eshleman wrote: > > > >

On Sat, Sep 02, 2023 at 04:37:19AM +0000, Bobby Eshleman wrote: > On Fri, Sep 01, 2023 at 09:31:03AM -0400, Michael S. Tsirkin wrote: > > On Wed, Aug 30, 2023 at 12:43:03AM +0000, Bobby Eshleman wrote: > > > On Tue, Aug 29, 2023 at 06:21:35PM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Aug 29, 2023 at 09:29:45PM +0000, Bobby Eshleman wrote: > > > >

On Sat, Sep 02, 2023 at 04:37:19AM +0000, Bobby Eshleman wrote: > On Fri, Sep 01, 2023 at 09:31:03AM -0400, Michael S. Tsirkin wrote: > > On Wed, Aug 30, 2023 at 12:43:03AM +0000, Bobby Eshleman wrote: > > > On Tue, Aug 29, 2023 at 06:21:35PM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Aug 29, 2023 at 09:29:45PM +0000, Bobby Eshleman wrote: > > > >

Hi Bobby, > /* The feature bitmap for virtio vsock */ > #define VIRTIO_VSOCK_F_SEQPACKET 1 /* SOCK_SEQPACKET supported */ > +#define VIRTIO_VSOCK_F_DGRAM 2 /* Host support dgram vsock */ Seems that bit 2 is already taken by VIRTIO_VSOCK_F_NO_IMPLIED_STREAM. https://github.com/oasis-tcs/virtio-spec/commit/26ed30ccb049fd51d6e20aad3de2807d678edb3a

On Tue, Feb 28, 2023 at 07:04:33PM +0000, Bobby Eshleman wrote: > Add support for sockmap to vsock. > > We're testing usage of vsock as a way to redirect guest-local UDS > requests to the host and this patch series greatly improves the > performance of such a setup. > > Compared to copying packets via userspace, this improves throughput by > 121% in basic testing.

From: Cong Wang <cong.wang at bytedance.com> When virtqueue_add_sgs() fails, the skb is put back to send queue, we should not deliver the copy to tap device in this case. So we need to move virtio_transport_deliver_tap_pkt() down after all possible failures. Fixes: 82dfb540aeb2 ("VSOCK: Add virtio vsock vsockmon hooks") Cc: Stefan Hajnoczi <stefanha at redhat.com> Cc:

On Thu, Aug 03, 2023 at 06:58:24PM +0000, Bobby Eshleman wrote: >On Thu, Aug 03, 2023 at 02:42:26PM +0200, Stefano Garzarella wrote: >> On Thu, Aug 03, 2023 at 12:53:22AM +0000, Bobby Eshleman wrote: >> > On Wed, Aug 02, 2023 at 10:24:44PM +0000, Bobby Eshleman wrote: >> > > On Sun, Jul 23, 2023 at 12:53:15AM +0300, Arseniy Krasnov wrote: >> > > >

On Wed, May 31, 2023 at 07:47:32PM +0000, Bobby Eshleman wrote: >Previous to setting the owner the socket is found via >vsock_find_connected_socket(), which returns sk after a call to >sock_hold(). > >If setting the owner fails, then sock_put() needs to be called. > >Fixes: f9d2b1e146e0 ("virtio/vsock: fix leaks due to missing skb owner") >Signed-off-by: Bobby

On Sat, Feb 18, 2023 at 07:25:41AM +0000, Bobby Eshleman wrote: >On Tue, Feb 28, 2023 at 04:36:22PM -0500, Michael S. Tsirkin wrote: >> On Tue, Feb 28, 2023 at 07:04:34PM +0000, Bobby Eshleman wrote: >> > @@ -1241,19 +1252,34 @@ static int vsock_dgram_connect(struct socket *sock, >> > >> > memcpy(&vsk->remote_addr, remote_addr,

Bobby Eshleman wrote: > We're testing usage of vsock as a way to redirect guest-local UDS > requests to the host and this patch series greatly improves the > performance of such a setup. > > Compared to copying packets via userspace, this improves throughput by > 121% in basic testing. > > Tested as follows. > > Setup: guest unix dgram sender -> guest vsock

On Sat, Mar 18, 2023 at 12:32:39AM +0000, Bobby Eshleman wrote: > On Fri, Mar 24, 2023 at 09:38:38AM +0100, Stefano Garzarella wrote: > > Hi Bobby, > > FYI we have also this one, but it seems related to > > syzbot+befff0a9536049e7902e at syzkaller.appspotmail.com > > > > Thanks, > > Stefano > > > > Got it, I'll look into it. > It seems

On Sat, Mar 25, 2023 at 1:44?AM Bobby Eshleman <bobbyeshleman at gmail.com> wrote: > > On Fri, Mar 24, 2023 at 09:38:38AM +0100, Stefano Garzarella wrote: > > Hi Bobby, > > FYI we have also this one, but it seems related to > > syzbot+befff0a9536049e7902e at syzkaller.appspotmail.com > > > > Thanks, > > Stefano > > > > Got it, I'll

Hi Arseniy, On Thu, Mar 09, 2023 at 11:24:42PM +0300, Arseniy Krasnov wrote: >Hello, > >this patchset evolved from previous v2 version (see link below). It does >several updates to virtio/vsock: >1) Changes 'virtio_transport_inc/dec_rx_pkt()' interface. Now instead of > using skbuff state ('head' and 'data' pointers) to update 'fwd_cnt' >

On Mon, Aug 14, 2023 at 10:46:05PM +0300, Arseniy Krasnov wrote: > > >On 04.08.2023 17:28, Stefano Garzarella wrote: >> On Fri, Aug 04, 2023 at 03:46:47PM +0300, Arseniy Krasnov wrote: >>> Hi Stefano, >>> >>> On 02.08.2023 10:46, Stefano Garzarella wrote: >>>> On Tue, Aug 01, 2023 at 05:17:26PM +0300, Arseniy Krasnov wrote: >>>>>

On Thu, Mar 09, 2023 at 07:20:20PM +0300, Arseniy Krasnov wrote: > > >On 09.03.2023 19:21, Stefano Garzarella wrote: >> On Thu, Mar 09, 2023 at 01:10:36PM +0300, Arseniy Krasnov wrote: >>> Hello, >>> >>> this patchset evolved from previous v2 version (see link below). It does >>> several updates to virtio/vsock: >>> 1) Changes

On Fri, Aug 07, 2020 at 11:00:11AM +0800, ?? wrote: > Xin He <hexin.op at bytedance.com> ?2020?7?21??? ??6:17??? > > > > From: Qi Liu <liuqi.16 at bytedance.com> > > > > We should put the reference count of the fence after calling > > virtio_gpu_cmd_submit(). So add the missing dma_fence_put(). > > > > Fixes: 2cd7b6f08bc4 ("drm/virtio:

From: Xin He <hexin.op at bytedance.com> [ Upstream commit 836b194d65782aaec4485a07d2aab52d3f698505 ] Before setting shmem->pages to NULL, kfree() should be called. Signed-off-by: Xin He <hexin.op at bytedance.com> Reviewed-by: Qi Liu <liuqi.16 at bytedance.com> Link: http://patchwork.freedesktop.org/patch/msgid/20200722051851.72662-1-hexin.op at bytedance.com

From: Xin He <hexin.op at bytedance.com> [ Upstream commit 836b194d65782aaec4485a07d2aab52d3f698505 ] Before setting shmem->pages to NULL, kfree() should be called. Signed-off-by: Xin He <hexin.op at bytedance.com> Reviewed-by: Qi Liu <liuqi.16 at bytedance.com> Link: http://patchwork.freedesktop.org/patch/msgid/20200722051851.72662-1-hexin.op at bytedance.com