similar to: [PATCH net-next V4 2/3] virtio_net: support per queue interrupt coalesce command

On Thu, Jul 27, 2023 at 03:28:32PM +0200, Paolo Abeni wrote: > On Tue, 2023-07-25 at 16:07 +0300, Gavin Li wrote: > > Add interrupt_coalesce config in send_queue and receive_queue to cache user > > config. > > > > Send per virtqueue interrupt moderation config to underlying device in > > order to have more efficient interrupt moderation and cpu utilization of >

? 2023/7/25 21:07, Gavin Li ??: > Add interrupt_coalesce config in send_queue and receive_queue to cache user > config. > > Send per virtqueue interrupt moderation config to underlying device in > order to have more efficient interrupt moderation and cpu utilization of > guest VM. > > Additionally, address all the VQs when updating the global configuration, > as now the

? 2023/7/25 21:07, Gavin Li ??: > Enable per queue interrupt coalesce feature bit in driver and validate its > dependency with control queue. > > Signed-off-by: Gavin Li <gavinl at nvidia.com> > Reviewed-by: Dragos Tatulea <dtatulea at nvidia.com> > Reviewed-by: Jiri Pirko <jiri at nvidia.com> > Acked-by: Michael S. Tsirkin <mst at redhat.com> >

is_power_of_2() already performs the zero check. Hence avoid duplicate check. While at it, move the query of size check also adjacent to where its used for the disabled vq. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> Reviewed-by: Parav Pandit <parav at nvidia.com> Reviewed-by: Gavin Li <gavinl at nvidia.com> Reviewed-by:

On Tue, Mar 7, 2023 at 11:57?AM Feng Liu <feliu at nvidia.com> wrote: > > Add const to make the read-only pointer parameters clear, similar to > many existing functions. > > Signed-off-by: Feng Liu <feliu at nvidia.com> > Reviewed-by: Jiri Pirko <jiri at nvidia.com> > Reviewed-by: Parav Pandit <parav at nvidia.com> > Reviewed-by: Gavin Li <gavinl

On Tue, Mar 7, 2023 at 11:57?AM Feng Liu <feliu at nvidia.com> wrote: > > is_power_of_2() already performs the zero check. Hence avoid duplicate > check. While at it, move the query of size check also adjacent to where > its used for the disabled vq. > > Signed-off-by: Feng Liu <feliu at nvidia.com> > Reviewed-by: Jiri Pirko <jiri at nvidia.com> >

This patch series performs a clean up of the code in virtio_ring and virtio_pci, modifying it to conform with the Linux kernel coding style guidance [1]. The modifications ensure the code easy to read and understand. This small series does few short cleanups in the code. Patch-1 Remove unnecessary num zero check, which performs in power_of_2. Patch-2 Avoid using inline for small functions.

This patch series performs a clean up of the code in virtio_ring and virtio_pci, modifying it to conform with the Linux kernel coding style guidance [1]. The modifications ensure the code easy to read and understand. This small series does few short cleanups in the code. Patch-1 Allow non power of 2 sizes for virtqueues Patch-2 Avoid using inline for small functions. Patch-3 Use const to annotate

All betas so far have compiled without problems on my setup, but something breaks in b13. This problem occurs with both make and gmake. Below are outputs from make and gmake. Regards, Mikkel make all-recursive Making all in src Making all in lib make all-am if gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I/opt/pkgsrc/pkg/include/mysql -std=gnu99 -g -O2 -Wall -W -Wmissing-prototypes

According to the Virtio Specification, the Queue Size parameter of a virtqueue corresponds to the maximum number of descriptors in that queue, and it does not have to be a power of 2 for packed virtqueues. However, the virtio_pci_modern driver enforced a power of 2 check for virtqueue sizes, which is unnecessary and restrictive. This commit removes that check, allowing virtqueues to have arbitrary

Add const to make the read-only pointer parameters clear, similar to many existing functions. To implement this change, the commit also introduces the use of `container_of_const` to implement `to_vvq`, which ensures the const-ness of read-only parameters and avoids accidental modification of their members. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at

Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable rx buffers to page frag allocators) try to increase the payload/truesize for MTU-sized traffic. But this will introduce the extra overhead for GSO packets received because of the frag list. This commit tries to reduce this issue by coalesce the possible rx frags when possible during rx. Test result shows the about 15%

Jason Wang <jasowang at redhat.com> writes: > Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable > rx buffers to page frag allocators) try to increase the payload/truesize for > MTU-sized traffic. But this will introduce the extra overhead for GSO packets > received because of the frag list. This commit tries to reduce this issue by > coalesce the

From: "Richard W.M. Jones" <rjones at redhat.com> --- src/events.c | 25 +++++++++++++++++-------- 1 files changed, 17 insertions(+), 8 deletions(-) diff --git a/src/events.c b/src/events.c index f707e0b..9a1ca76 100644 --- a/src/events.c +++ b/src/events.c @@ -120,8 +120,7 @@ guestfs___call_callbacks_message (guestfs_h *g, uint64_t event, event == GUESTFS_EVENT_TRACE)

Does the libvirt development team have a sense of when/which version of libvirt will support the deletion of live snapshots, incl. the coalesce. With the restriction that you cannot delete the most recent snapshot! Harald -------------- next part -------------- An HTML attachment was scrubbed... URL:

Jason Wang <jasowang at redhat.com> writes: > Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable > rx buffers to page frag allocators) try to increase the payload/truesize for > MTU-sized traffic. But this will introduce the extra overhead for GSO packets > received because of the frag list. This commit tries to reduce this issue by > coalesce the

On Mon, May 22, 2017 at 03:33:43AM -0700, Joe Perches wrote: > vhost logging uses of vq_err has a few defects and style inconsistencies. > > o pr_debug already uses pr_fmt so its use in vq_err is defective > however no #defines of pr_fmt exist in this code so no actual > defects exist > o vq_err uses need terminating newlines so add the missing ones > o Coalesce formats

On Mon, Jun 05, 2023 at 12:59:25PM -0700, Brett Creeley wrote: > Commit 699b045a8e43 ("net: virtio_net: notifications coalescing > support") added coalescing command support for virtio_net. However, > the coalesce commands are using buffers on the stack, which is causing > the device to see DMA errors. There should also be a complaint from > check_for_stack() in

Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable rx buffers to page frag allocators) try to increase the payload/truesize for MTU-sized traffic. But this will introduce the extra overhead for GSO packets received because of the frag list. This commit tries to reduce this issue by coalesce the possible rx frags when possible during rx. Test result shows the about 15%

Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable rx buffers to page frag allocators) try to increase the payload/truesize for MTU-sized traffic. But this will introduce the extra overhead for GSO packets received because of the frag list. This commit tries to reduce this issue by coalesce the possible rx frags when possible during rx. Test result shows the about 15%