similar to: [Bridge] [PATCH v1 net] bridge: Return an error when enabling STP in netns.

On 12/07/2023 17:48, Ido Schimmel wrote: > On Tue, Jul 11, 2023 at 04:54:15PM -0700, Kuniyuki Iwashima wrote: >> When we create an L2 loop on a bridge in netns, we will see packets storm >> even if STP is enabled. >> >> # unshare -n >> # ip link add br0 type bridge >> # ip link add veth0 type veth peer name veth1 >> # ip link set veth0 master

On 12/07/2023 02:54, Kuniyuki Iwashima wrote: > When we create an L2 loop on a bridge in netns, we will see packets storm > even if STP is enabled. > > # unshare -n > # ip link add br0 type bridge > # ip link add veth0 type veth peer name veth1 > # ip link set veth0 master br0 up > # ip link set veth1 master br0 up > # ip link set br0 type bridge stp_state 1

(CC'ing bridge maintainers.) Kuniyuki Iwashima <kuniyu at amazon.com> writes: > From: Harry Coin <hcoin at quietfountain.com> > Date: Tue, 11 Jul 2023 16:40:03 -0500 >> On 7/11/23 15:44, Andrew Lunn wrote: >> >>>>>> The current llc_rcv.c around line 166 in net/llc/llc_input.c has >> >>>>>> >>

Fixes a typo in net/bridge/br_stp_if.c --- a/net/bridge/br_stp_if.c +++ b/net/bridge/br_stp_if.c @@ -132,7 +132,7 @@ static void br_stp_start(struct net_bridge *br) } else { br->stp_enabled = BR_KERNEL_STP; printk(KERN_INFO "%s: starting userspace STP failed, " - "staring kernel STP\n",

This patch adds a 'hairpin' (also called 'reflective relay') mode port configuration to the Linux Ethernet bridge kernel module. A bridge supporting hairpin forwarding mode can send frames back out through the port the frame was received on. Hairpin mode is required to support basic VEPA (Virtual Ethernet Port Aggregator) capabilities. You can find additional information on VEPA

This patch adds a 'hairpin' (also called 'reflective relay') mode port configuration to the Linux Ethernet bridge kernel module. A bridge supporting hairpin forwarding mode can send frames back out through the port the frame was received on. Hairpin mode is required to support basic VEPA (Virtual Ethernet Port Aggregator) capabilities. You can find additional information on VEPA

This patch adds a 'hairpin' (also called 'reflective relay') mode port configuration to the Linux Ethernet bridge kernel module. A bridge supporting hairpin forwarding mode can send frames back out through the port the frame was received on. Hairpin mode is required to support basic VEPA (Virtual Ethernet Port Aggregator) capabilities. You can find additional information on VEPA

Looks like somebody forgot to use the _bh spin_lock variant. We ran into a deadlock where br->hello_timer expired while br_stp_disable_br() walked br->port_list. Anush can provide you with a test program. Patch against 2.6.16-rc3 inlined. diff -rup linux-2.6.16-rc3/net/bridge/br_stp_if.c linux-2.6.16-rc3-brfix/net/bridge/br_stp_if.c --- linux-2.6.16-rc3/net/bridge/br_stp_if.c

Looks like somebody forgot to use the _bh spin_lock variant. We ran into a deadlock where br->hello_timer expired while br_stp_disable_br() walked br->port_list. Anush can provide you with a test program. Patch against 2.6.16-rc3 inlined. Signed-off-by: Adrian Drzewiecki diff -rup linux-2.6.16-rc3/net/bridge/br_stp_if.c linux-2.6.16-rc3-brfix/net/bridge/br_stp_if.c ---

From: Evgeny Kravtsunov <emkravts@openvz.org> compare_ether_addr() implicitly requires that the addresses passed are 2-bytes aligned in memory. This is not true for br_stp_change_bridge_id() and br_stp_recalculate_bridge_id() in which one of the addresses is unsigned char *, and thus may not be 2-bytes aligned. Signed-off-by: Evgeny Kravtsunov <emkravts@openvz.org> Signed-off-by:

Bridge locking for /sys/class/net/br0/bridge/stp_enabled was wrong. Another bug in bridge utilities makes it such that this interface, meant it wasn't being used. The locking needs to be removed from set_stp_state(), the lock is already acquired down in br_stp_start()/br_stp_stop. Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> --- a/net/bridge/br_sysfs_br.c

Hi I'm looking for code that implements the 802.1d spanning tree. Do you have an idea where can I download this code? Thanks Yossi -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.linux-foundation.org/pipermail/bridge/attachments/20050818/692b471a/attachment-0002.htm

Hi, I noticed that brctl (or more accurately, libbridge) is using the wrong path when doing various lookups in sysfs: e.g. /sys/class/net/brXXX/stp_state when it should use /sys/class/net/brXXX/bridge/stp_state. This doesn't cause any problems on most systems as it falls back to the ioctl when the sysfs attempt fails; however the ioctl method is apparently deprecated. I believe the

It appears that interfaces participate in STP's forwarding delay even when STP is disabled for a given bridge. I can remedy by setting the FD to 0 for each new bridge, but I'm wondering if this is by design or oversight. [root@ ~]# brctl show bridge name bridge id STP enabled interfaces br0.690 8000.00065b8bce3e no eth1.690

Hi, All: I am tring to use STP function on bridge device that refer the BRIDGE-STP-HOWTO. And I use PING program to test it from PC1 to PC2. But the forward function is become too long when bridge topology change. How can I tuning the STP to make client connect to another again faster? I have been use follow command. But it seen not this issue. Bcause, if I run " arp -d " on

We seem to send 3 extra bytes in a TCN, which will be whatever happens to be on the stack. Thanks to Aji_Srinivas@emc.com for seeing. Signed-off-by: Stephen Hemminger <shemminger@osdl.org> diff -Naur a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c --- a/net/bridge/br_stp_bpdu.c 2006-09-03 23:40:08.000000000 +0530 +++ b/net/bridge/br_stp_bpdu.c 2006-09-03 23:40:33.000000000 +0530 @@

I have been playing around with the STP settings of brctl and saw something strange. I was setting the hello time, so I executed the following: # brctl sethello br0 30 Then I had a look at the value that was set: # cat /sys/class/net/br0/bridge/hello_time 2999 Much bigger than expected. I started looking at the source. In the libbridge/libbridge_devif.c file of brctl, we have the following

Hi all, I work on a SOC based on Micrel/Kendin KS8695 based on ARM9. ( http://micrel.com/page.do?page=product-info/sys_on_chip.jsp) This component has 2 network interfaces. One is connected to a 5 ports switch. eth0 eth1 => switch port1,2,3,4 I want to make a bridge with these 5 ports but my problem is that the network driver only install 2 interfaces. The KS8695 network switch can be

Hi, I want to connect two pc`s on a redundant way with each other. On those pc`s a 64 bit ubuntu 11.10 is running with kernel version 3.0.0-16-generic. Setup1: ---------- PC1: PC2: br0 br1 | | -- eth0.1000 ---------------------------------------------------eth0.1000 | | __eth1.1001

This is a revised version of Kishore's patch to set message age appropriately in STP configuration packets. Signed-off-by: Kishore A K <KishoreAK@myw.ltindia.com> Signed-off-by: Stephen Hemminger <shemminger@osdl.org> diff -Nru a/net/bridge/br_stp.c b/net/bridge/br_stp.c --- a/net/bridge/br_stp.c 2004-06-29 14:45:50 -07:00 +++ b/net/bridge/br_stp.c 2004-06-29 14:45:50 -07:00 @@