similar to: [PATCH] drm/nouveau/acr: Abort loading ACR if no firmware was found

Fixes coccicheck warning: drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:103:23-30: WARNING opportunity for kmemdup drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:113:22-29: WARNING opportunity for kmemdup Fixes: 22dcda45a3d1 ("drm/nouveau/acr: implement new subdev to replace "secure boot"") Reported-by: Hulk Robot <hulkci at huawei.com> Signed-off-by: Zou Wei

smatch reports drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c:49:1: warning: symbol 'ga102_gsps' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix <trix at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Hello, Commit 2541626cfb79 breaks GM20B probe with the following kernel log: [ 2.153892] ------------[ cut here ]------------ [ 2.153897] WARNING: CPU: 1 PID: 36 at drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgf100.c:273 gf100_vmm_valid+0x2c4/0x390 [ 2.153916] Modules linked in: [ 2.153922] CPU: 1 PID: 36 Comm: kworker/u8:1 Not tainted 6.1.0+ #1 [ 2.153929] Hardware name: Google

The local variable loc in nvkm_acr_lsfw_load_sig_image_desc_v2() is set but not used. Remove the variable and related code. Signed-off-by: Bo Liu <liubo03 at inspur.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c index

Fix the W=1 warning -Wunused-but-set-variable. Cc: Karol Herbst <kherbst at redhat.com> Cc: Lyude Paul <lyude at redhat.com> Cc: Danilo Krummrich <dakr at redhat.com> Cc: nouveau at lists.freedesktop.org Signed-off-by: Jani Nikula <jani.nikula at intel.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

clang with W=1 reports drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: error: variable 'loc' set but not used [-Werror,-Wunused-but-set-variable] u32 loc, sig, cnt, *meta; ^ This variable is not used so remove it. Signed-off-by: Tom Rix <trix at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- 1 file changed, 1

On Thu, Dec 29, 2022 at 12:58 AM Diogo Ivo <diogo.ivo at tecnico.ulisboa.pt> wrote: > > Hello, > > Commit 2541626cfb79 breaks GM20B probe with > the following kernel log: > > [ 2.153892] ------------[ cut here ]------------ > [ 2.153897] WARNING: CPU: 1 PID: 36 at drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgf100.c:273 gf100_vmm_valid+0x2c4/0x390 > [

I have this windows program; call it ACR. Its very simple I think.....though I'm not a programmer. It's an educational program and mostly involves pulling up images and documents off of a CD. I have the latest WINE from codeweavers installed. It seems to run wordpad.exe, cdplayer.exe and even the ACR installation of the disk works perfectly. The config file looks OK to me. So I

Does any have or can point me to /ACR/ Anonymous Call Rejection message I can download? The one I found was not not too clear. Thanks, Bart -------------- next part -------------- A non-text attachment was scrubbed... Name: bhfisher.vcf Type: text/x-vcard Size: 253 bytes Desc: not available Url : http://lists.digium.com/pipermail/asterisk-users/attachments/20090916/c3b682d5/attachment.vcf

Hi all, Friendly ping! Who can take this? Thanks -- Gustavo On 07/24/2018 08:27 AM, Gustavo A. R. Silva wrote: > In case memory resources for *bl_desc* were allocated, release > them before return. > > Addresses-Coverity-ID: 1472021 ("Resource leak") > Fixes: 0d466901552a ("drm/nouveau/secboot/acr: Remove VLA usage") > Signed-off-by: Gustavo A. R. Silva

On Fri, Sep 7, 2018 at 8:02 PM, John Hubbard <jhubbard at nvidia.com> wrote: > On 8/2/18 12:51 PM, Gustavo A. R. Silva wrote: >> Hi all, >> >> Friendly ping! Who can take this? >> >> Thanks >> -- >> Gustavo >> >> On 07/24/2018 08:27 AM, Gustavo A. R. Silva wrote: >>> In case memory resources for *bl_desc* were allocated,

On Fri, Apr 3, 2020 at 6:59 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote: > > Ben -- probably the ACR changes in 5.6 don't fall back nicely anymore > when there's no firmware? The load shouldn't be failed, just GR > disabled... > > Zeno -- if you grab linux-firmware, it should be all better. Not sure > if you're missing it on purpose or by accident.

On Fri, Apr 3, 2020 at 7:23 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote: > > On Fri, Apr 3, 2020 at 1:21 PM Zeno Davatz <zdavatz at gmail.com> wrote: > > > > On Fri, Apr 3, 2020 at 6:59 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote: > > > > > > Ben -- probably the ACR changes in 5.6 don't fall back nicely anymore > > > when

Starting with kernel 5.6, loading nouveau without firmware (for GPUs where it is required, such as yours) got broken. You are loading nouveau without firmware, so it fails. The firmware needs to be available to the kernel at the time of nouveau loading. Cheers, -ilia On Thu, Jun 4, 2020 at 10:24 AM Zeno Davatz <zdavatz at gmail.com> wrote: > > Hi > > With Kernel 5.7 I am

On Thu, Jun 4, 2020 at 11:16 AM Zeno Davatz <zdavatz at gmail.com> wrote: > > On Thu, Jun 4, 2020 at 4:36 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote: > > > > Starting with kernel 5.6, loading nouveau without firmware (for GPUs > > where it is required, such as yours) got broken. > > > > You are loading nouveau without firmware, so it fails. >

On Thu, Jun 4, 2020 at 12:04 PM Zeno Davatz <zdavatz at gmail.com> wrote: > > Thank you, Ilia > > On Thu, Jun 4, 2020 at 5:25 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote: > > > There's a lot more firmware files than that ... everything in the > > gp107 directory. Also this would only be necessary if nouveau is built > > into the kernel. The files

This patch performs the following changes: 1. remove a redundant parentheses around the nvkm_acr_lsfw_add() calls 2. do assignment before this if condition, it is more readable Signed-off-by: Jing Xiangfeng <jingxiangfeng at huawei.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

gcc with W=1 reports drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: error: no previous prototype for ?wpr_generic_header_dump? [-Werror=missing-prototypes] 49 | wpr_generic_header_dump(struct nvkm_subdev *subdev, | ^~~~~~~~~~~~~~~~~~~~~~~ wpr_generic_header_dump is only used in acr.c, so it should be static Signed-off-by: Tom Rix <trix at redhat.com> ---

Hi After installing Kernel 5.6 I am getting this error: Cannot run in framebuffer mode. Please specify busIDs for all framebuffer devices [ 0.757317] nouveau 0000:05:00.0: NVIDIA GP107 (137000a1) [ 0.869775] nouveau 0000:05:00.0: bios: version 86.07.42.00.4a [ 0.870157] nouveau 0000:05:00.0: acr: failed to load firmware [ 0.870256] nouveau 0000:05:00.0: acr: failed to load firmware [ 0.870356]

On Thu, Jun 4, 2020 at 4:36 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote: > > Starting with kernel 5.6, loading nouveau without firmware (for GPUs > where it is required, such as yours) got broken. > > You are loading nouveau without firmware, so it fails. > > The firmware needs to be available to the kernel at the time of nouveau loading. Ok, I am now trying this: