similar to: 6297318 Orphan dfA files found on cascading SUN print host

Hi Ivan, The patch looks good to me. I have a couple of minor comments: +void State::AddInsnClass(unsigned InsnClass, Add a top level comment describing the function + std::map<State*, std::set<Transition*, ltTransition>, ltState> stateTransitions; You should be able to use SmallSet here. Also, this line exceeds 80 columns. On a related note, is the CachedTable mechanism in

Hi Ivan, > I missed last 2 commits made by Alexey. Following his advices, I > updated the patch. It should be ok now. > Thanks Anshu! > > I've recently added more functional units to our Schedule.td and the > generation time became painfully long. In fact, the main problem was > in writeTableAndAPI(). I propose another patch to fix it: > - Fixed memory leaks. > -

> Thanks for reviewing this. I added a top comment for AddInsnClass and I fixed the violation of column numbers. Great. Looks good to me. > IMO, it wil be nice to keep it alive for performance comparisons. Given the overall performance > is rather determined by transition searches on the current state, for small DFA tables may not be a win > and it may still be the case for

Ivan, Thanks for working on the patch. It looks good to me except for the removal of the Transition class: > (1) Should I completely remove Transition and create a map structure in State (input, state) to replace them? Yes, please remove the Transition class and create a map structure in State instead of TransitionSet. Thanks -Anshu On 8/25/2012 6:42 AM, Ivan Llopard wrote: > Hi

Hi Ivan, Sorry, I should have been more explicit in my last email. The patch looks good to me. Please check that it applies on trunk and go ahead and commit. Thanks -Anshu > Hi Anshu, > > Just in case you have forgotten this thread ;-). Is this patch ok to > commit or does it not apply to trunk properly ? > I can fix it if that's the problem. > > Ivan > > On

On 28/08/2012 00:21, Anshuman Dasgupta wrote: > Ivan, > > Thanks for working on the patch. It looks good to me except for the > removal of the Transition class: > > > (1) Should I completely remove Transition and create a map structure > in State (input, state) to replace them? > > Yes, please remove the Transition class and create a map structure in > State

Ivan, Thanks for working on the DFA generator. I'll take a look at the changes in detail but from your description, I like the general nature of the modifications. -Anshu --- Qualcomm Innovation Center, Inc is a member of the Code Aurora Forum On 6/14/2012 8:22 AM, Ivan Llopard wrote: > Hi, > > I've refactored the DFA generator in TableGen because it takes too > much

I missed last 2 commits made by Alexey. Following his advices, I updated the patch. It should be ok now. Ivan On 27/06/2012 21:42, Anshuman Dasgupta wrote: > Committed in r159281. > > -Anshu > > > On 6/26/2012 3:04 AM, Ivan Llopard wrote: >> Hi Anshu, >> >> I don't have commit access. It applies correctly on trunk, I've just >> checked it.

Hi Anshu, Thanks for reviewing this. I added a top comment for AddInsnClass and I fixed the violation of column numbers. On 15/06/2012 21:31, Anshuman Dasgupta wrote: > Hi Ivan, > > The patch looks good to me. I have a couple of minor comments: > > +void State::AddInsnClass(unsigned InsnClass, > Add a top level comment describing the function > > + std::map<State*,

Hi Anshu, Just in case you have forgotten this thread ;-). Is this patch ok to commit or does it not apply to trunk properly ? I can fix it if that's the problem. Ivan On 20/06/2012 19:33, Anshuman Dasgupta wrote: > > > Thanks for reviewing this. I added a top comment for AddInsnClass > and I fixed the violation of column numbers. > > Great. Looks good to me. > >

Hi Anshu, Thanks again for your feedbacks. On 24/08/2012 17:01, Anshuman Dasgupta wrote: > Hi Ivan, > >> I missed last 2 commits made by Alexey. Following his advices, I >> updated the patch. It should be ok now. >> Thanks Anshu! >> >> I've recently added more functional units to our Schedule.td and the >> generation time became painfully long. In

Committed in r159281. -Anshu On 6/26/2012 3:04 AM, Ivan Llopard wrote: > Hi Anshu, > > I don't have commit access. It applies correctly on trunk, I've just > checked it. Could you please commit it? > > Ivan > > On 26/06/2012 04:44, adasgupt at codeaurora.org wrote: >> Hi Ivan, >> >> Sorry, I should have been more explicit in my last email. The

Dear all, I am trying to do a n-fold cross-validation for a regularized discrimant function analysis using rda from the package klaR. However, I have problems to predict the groups from the test/validation sample. The exmaples of the R documantation and some online webpage also do not work. Does anybody know what I have done wrong? Here my code # I want to use the first 6 observations for

Hello, I am a grad student in the Music Engineering Technology program at the University of Miami. I am planning on doing thesis research on cascading audio encoding chains and how to eliminate or improve audible artifacts in future encoding generations and will potentially be using Ogg for this work. My specific question is, Has anyone done any prior work in cascading audio encoders? If so, it

Hi Anshu, I don't have commit access. It applies correctly on trunk, I've just checked it. Could you please commit it? Ivan On 26/06/2012 04:44, adasgupt at codeaurora.org wrote: > Hi Ivan, > > Sorry, I should have been more explicit in my last email. The patch looks > good to me. Please check that it applies on trunk and go ahead and commit. > > Thanks > -Anshu

During the interesting interview that binaryfreedom has made with Monty and Jack, Monty mentions cascading, a feature that will be added, quote: "Cascading is the ability to make multiple passes through the frequency spectrum, iteratively filling in more detail, like a progressive jpeg". What are the advantages of something like this - does this generally improves quality or is it used

Hi, I've refactored the DFA generator in TableGen because it takes too much time to build the table of our BE and I'd like to share it. We have 15 functional units and 13 different itineraries which, in the worst case, can produce 13! states. Fortunately, many of those states are reused :-) but it still takes up to 11min to build the entire table. This patch reduces the build time to

Because orphan cleanup now happens well after the fs is all initialized and such, we can run into this problem where we find orphan entries that were just added to the fs, not ones that were added previously during a crash. This does not bode well for the system, and results in a couple of odd things happening, like truncate being run on non-regular files. In order to fix this we just check and

In my model I have a city_id. ON the form I am using a cascading select to select the state, which then does a remote_submit to get the list of cities (and hence the city_id) for the selected state. The problem that I am having is that if I make a selection, hit SUBMIT and validation fails, the original selected state/city is now reset (ie, the values aren''t saved). Since they

Hi all, In 1.4 and 1.2 there is a hole that leaves orphans in a orphan directory till fsck was run or recovery occurs on that slot. In the current implementation, if node A did rm of a file while it is opened by node B. Now if node A umounts and node B dies and is restarted first, it only recovers itself leaving orphan file in node A's orphan directory. In order to fix the problem, I am