similar to: libnbd | Failed pipeline for master | 2db30279

On 3/28/23 08:59, GitLab wrote: > GitLab > ? Pipeline #819889104 has failed! > > ? > Project nbdkit <https://gitlab.com/nbdkit> / libnbd > <https://gitlab.com/nbdkit/libnbd> > Branch > master <https://gitlab.com/nbdkit/libnbd/-/commits/master> > > Commit > 2db30279 >

On Thu, Mar 23, 2023 at 01:10:16PM +0100, Laszlo Ersek wrote: > When the user calls nbd_set_socket_activation_name before calling > nbd_connect_system_socket_activation, pass the name down to the server > through LISTEN_FDNAMES. This has no effect unless the new API has > been called to set the socket name to a non-empty string. > >

On 3/23/23 20:27, Eric Blake wrote: > On Thu, Mar 23, 2023 at 01:10:16PM +0100, Laszlo Ersek wrote: >> When the user calls nbd_set_socket_activation_name before calling >> nbd_connect_system_socket_activation, pass the name down to the server >> through LISTEN_FDNAMES. This has no effect unless the new API has >> been called to set the socket name to a non-empty string.

From: "Richard W.M. Jones" <rjones at redhat.com> To allow us to name the socket passed down to the NBD server when calling nbd_connect_systemd_socket_activation(3), we need to add the field to the handle and add access functions. [Laszlo's note: originally posted by Rich at <https://listman.redhat.com/archives/libguestfs/2023-January/030557.html>. I've renamed

V4 was here (incorrectly versioned on the mailing list as v3): <http://mid.mail-archive.com/20230323121016.1442655-1-lersek at redhat.com>. See the Notes section on each patch for the v5 updates. Laszlo Ersek (2): socket activation: generalize environment construction socket activation: set LISTEN_FDNAMES Richard W.M. Jones (2): common/include: Copy ascii-ctype functions from nbdkit

On 3/28/23 04:06, Eric Blake wrote: > On Sat, Mar 25, 2023 at 12:39:28PM +0100, Laszlo Ersek wrote: >> From: "Richard W.M. Jones" <rjones at redhat.com> >> >> To allow us to name the socket passed down to the NBD server when >> calling nbd_connect_systemd_socket_activation(3), we need to add the >> field to the handle and add access functions.

On Sat, Mar 25, 2023 at 12:39:28PM +0100, Laszlo Ersek wrote: > From: "Richard W.M. Jones" <rjones at redhat.com> > > To allow us to name the socket passed down to the NBD server when > calling nbd_connect_systemd_socket_activation(3), we need to add the > field to the handle and add access functions. > > [Laszlo's notes: > > - Originally posted by

[attempting to loop in systemd folks; this started in libnbd at https://listman.redhat.com/archives/libguestfs/2023-March/031178.html - although I may have to retry since I'm not a usual subscriber of systemd-devel] On Fri, Mar 24, 2023 at 11:32:26AM +0100, Laszlo Ersek wrote: > >> @@ -245,6 +245,9 @@ CONNECT_SA.START: > >> "LISTEN_PID=",

From: "Richard W.M. Jones" <rjones at redhat.com> To allow us to name the socket passed down to the NBD server when calling nbd_connect_systemd_socket_activation(3), we need to add the field to the handle and add access functions. [Laszlo's notes: - Originally posted by Rich at <https://listman.redhat.com/archives/libguestfs/2023-January/030557.html> (Message-Id:

When the user calls nbd_set_socket_activation_name before calling nbd_connect_system_socket_activation, pass the name down to the server through LISTEN_FDNAMES. This has no effect unless the new API has been called to set the socket name to a non-empty string. --- generator/states-connect-socket-activation.c | 35 +++++++++++++++----- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git

On 1/28/23 13:47, Richard W.M. Jones wrote: > systemd allows sockets passed through socket activation to be named > with the protocol they require. We only ever pass one socket, name > it. This environment variable is currently ignored by qemu-nbd and > nbdkit, but might be used by qemu-storage-daemon: > > https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg06114.html

On 3/23/23 13:09, Laszlo Ersek wrote: > V3 was here: > <http://mid.mail-archive.com/20230215141158.2426855-1-lersek at redhat.com>. Meh, *this* version is of course v4. I updated everything in my git-format-series command line, from my bash history, from the time of posting v3, *except* of course the "-v3" option... Laszlo

V3 was here: <http://mid.mail-archive.com/20230215141158.2426855-1-lersek at redhat.com>. See the Notes section on each patch for the v4 updates. The series is nearly ready for merging: every patch has at least one R-b tag, except "socket activation: avoid manipulating the sign bit". The series builds, and passes "make check" and "make check-valgrind", at

Pipeline #785487102 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: b5101fbc ( https://gitlab.com/nbdkit/libnbd/-/commit/b5101fbc59cbdaef47e7843c735e8cc9f63fce10 ) Commit Message: use space consistently in function and function... Commit Author: Laszlo Ersek ( https://gitlab.com/lersek ) Pipeline

Pipeline #813094663 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 65631e5d ( https://gitlab.com/nbdkit/libnbd/-/commit/65631e5dfff5d0b8f691aba1e838c83dceb621d0 ) Commit Message: lib/utils: try to placate attribute placement r... Commit Author: Laszlo Ersek ( https://gitlab.com/lersek ) Pipeline

systemd allows sockets passed through socket activation to be named with the protocol they require. We only ever pass one socket, name it. This environment variable is currently ignored by qemu-nbd and nbdkit, but might be used by qemu-storage-daemon: https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg06114.html --- generator/states-connect-socket-activation.c | 41

This is an alternative approach to https://listman.redhat.com/archives/libguestfs/2023-January/030535.html After discussing this with Dan Berrange we came to the conclusion that you really might want to set LISTEN_FDNAMES to arbitrary short strings (or not set it). Especially when talking to qemu-storage-daemon which would allow you to use these names on the command line. Rich.

To allow us to name the socket passed down to the NBD server when calling nbd_connect_systemd_socket_activation(3), we need to add the field to the handle and add access functions. --- generator/API.ml | 49 ++++++++++++++++++++++++++++++++++++++++++ lib/handle.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++ lib/internal.h | 1 + 3 files changed, 106 insertions(+) diff --git

Anyone looked into almalinux? I was sort of waiting for rocky, but I see from over the weekend on slashdot that almalinux stable is released. mark

"Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 20079 qemu-upstream-4.3-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/20079/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: