similar to: [RFC PATCH v5 2/2] virtio/vsock: check argument to avoid no effect call

On Tue, Mar 21, 2023 at 06:03:14PM +0300, Arseniy Krasnov wrote: >This adds small optimization for tx path: instead of allocating single >skbuff on every call to transport, allocate multiple skbuff's until >credit space allows, thus trying to send as much as possible data without >return to af_vsock.c. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru>

On Mon, Mar 20, 2023 at 09:02:19PM +0300, Arseniy Krasnov wrote: > > >On 20.03.2023 17:29, Stefano Garzarella wrote: >> On Sun, Mar 19, 2023 at 09:46:10PM +0300, Arseniy Krasnov wrote: >>> This adds small optimization for tx path: instead of allocating single >>> skbuff on every call to transport, allocate multiple skbuff's until >>> credit space

On Tue, Mar 21, 2023 at 12:31:48AM +0300, Arseniy Krasnov wrote: >This adds small optimization for tx path: instead of allocating single >skbuff on every call to transport, allocate multiple skbuff's until >credit space allows, thus trying to send as much as possible data without >return to af_vsock.c. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru>

On Sun, Mar 05, 2023 at 11:06:26PM +0300, Arseniy Krasnov wrote: >Substraction of 'skb->len' is redundant here: 'skb_headroom()' is delta >between 'data' and 'head' pointers, e.g. it is number of bytes returned >to user (of course accounting size of header). 'skb->len' is number of >bytes rest in buffer. > >Fixes: 71dc9ec9ac7d

On Sun, Mar 05, 2023 at 11:08:38PM +0300, Arseniy Krasnov wrote: >This fixes two things in case when 'memcpy_to_msg()' fails: >1) Update credit parameters of the socket, like this skbuff was > copied to user successfully. This is needed because when skbuff was > received it's length was used to update 'rx_bytes', thus when we drop > skbuff here, we must

On Thu, Mar 09, 2023 at 11:27:02PM +0300, Arseniy Krasnov wrote: >Since we now no longer use 'skb->len' to update credit, there is no sense >to update skbuff state, because it is used only once after dequeue to >copy data and then will be released. > >Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") >Signed-off-by: Arseniy Krasnov

> On Mar 30, 2023, at 1:18 PM, Arseniy Krasnov <AVKrasnov at sberdevices.ru> wrote: > > !! External Email > > On 30.03.2023 23:13, Arseniy Krasnov wrote: >> This adds conversion of VMCI specific error code to general -ENOMEM. It >> is needed, because af_vsock.c passes error value returned from transport >> to the user, which does not expect to get

On Mon, Feb 06, 2023 at 07:00:35AM +0000, Arseniy Krasnov wrote: >This adds main logic of MSG_ZEROCOPY flag processing for packet >creation. When this flag is set and user's iov iterator fits for >zerocopy transmission, call 'get_user_pages()' and add returned >pages to the newly created skb. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru>

On Mon, Jul 29, 2019 at 06:50:56PM +0200, Stefano Garzarella wrote: > On Mon, Jul 29, 2019 at 06:19:03PM +0200, Stefano Garzarella wrote: > > On Mon, Jul 29, 2019 at 11:49:02AM -0400, Michael S. Tsirkin wrote: > > > On Mon, Jul 29, 2019 at 05:36:56PM +0200, Stefano Garzarella wrote: > > > > On Mon, Jul 29, 2019 at 10:04:29AM -0400, Michael S. Tsirkin wrote: > >

On Mon, Mar 06, 2023 at 07:00:10PM +0300, Arseniy Krasnov wrote: > > >On 06.03.2023 18:51, Stefano Garzarella wrote: >> On Mon, Mar 06, 2023 at 06:31:22PM +0300, Arseniy Krasnov wrote: >>> >>> >>> On 06.03.2023 15:08, Stefano Garzarella wrote: >>>> On Sun, Mar 05, 2023 at 11:07:37PM +0300, Arseniy Krasnov wrote: >>>>> In case of

On Tue, Jul 30, 2019 at 11:35:39AM +0200, Stefano Garzarella wrote: > On Mon, Jul 29, 2019 at 03:10:15PM -0400, Michael S. Tsirkin wrote: > > On Mon, Jul 29, 2019 at 06:50:56PM +0200, Stefano Garzarella wrote: > > > On Mon, Jul 29, 2019 at 06:19:03PM +0200, Stefano Garzarella wrote: > > > > On Mon, Jul 29, 2019 at 11:49:02AM -0400, Michael S. Tsirkin wrote: > >

On Mon, Aug 14, 2023 at 10:40:17PM +0300, Arseniy Krasnov wrote: > > >On 04.08.2023 18:02, Stefano Garzarella wrote: >> On Fri, Aug 04, 2023 at 05:34:20PM +0300, Arseniy Krasnov wrote: >>> >>> >>> On 04.08.2023 17:28, Stefano Garzarella wrote: >>>> On Fri, Aug 04, 2023 at 03:46:47PM +0300, Arseniy Krasnov wrote: >>>>> Hi Stefano,

On Fri, Aug 04, 2023 at 05:34:20PM +0300, Arseniy Krasnov wrote: > > >On 04.08.2023 17:28, Stefano Garzarella wrote: >> On Fri, Aug 04, 2023 at 03:46:47PM +0300, Arseniy Krasnov wrote: >>> Hi Stefano, >>> >>> On 02.08.2023 10:46, Stefano Garzarella wrote: >>>> On Tue, Aug 01, 2023 at 05:17:26PM +0300, Arseniy Krasnov wrote: >>>>>

On Thu, Mar 09, 2023 at 07:20:20PM +0300, Arseniy Krasnov wrote: > > >On 09.03.2023 19:21, Stefano Garzarella wrote: >> On Thu, Mar 09, 2023 at 01:10:36PM +0300, Arseniy Krasnov wrote: >>> Hello, >>> >>> this patchset evolved from previous v2 version (see link below). It does >>> several updates to virtio/vsock: >>> 1) Changes

On Mon, Aug 14, 2023 at 10:46:05PM +0300, Arseniy Krasnov wrote: > > >On 04.08.2023 17:28, Stefano Garzarella wrote: >> On Fri, Aug 04, 2023 at 03:46:47PM +0300, Arseniy Krasnov wrote: >>> Hi Stefano, >>> >>> On 02.08.2023 10:46, Stefano Garzarella wrote: >>>> On Tue, Aug 01, 2023 at 05:17:26PM +0300, Arseniy Krasnov wrote: >>>>>

On Fri, Aug 04, 2023 at 03:46:47PM +0300, Arseniy Krasnov wrote: >Hi Stefano, > >On 02.08.2023 10:46, Stefano Garzarella wrote: >> On Tue, Aug 01, 2023 at 05:17:26PM +0300, Arseniy Krasnov wrote: >>> POSIX requires to send SIGPIPE on write to SOCK_STREAM socket which was >>> shutdowned with SHUT_WR flag or its peer was shutdowned with SHUT_RD >>> flag.

On Mon, Jul 29, 2019 at 06:19:03PM +0200, Stefano Garzarella wrote: > On Mon, Jul 29, 2019 at 11:49:02AM -0400, Michael S. Tsirkin wrote: > > On Mon, Jul 29, 2019 at 05:36:56PM +0200, Stefano Garzarella wrote: > > > On Mon, Jul 29, 2019 at 10:04:29AM -0400, Michael S. Tsirkin wrote: > > > > On Wed, Jul 17, 2019 at 01:30:26PM +0200, Stefano Garzarella wrote: > >

On Mon, Jul 29, 2019 at 06:19:03PM +0200, Stefano Garzarella wrote: > On Mon, Jul 29, 2019 at 11:49:02AM -0400, Michael S. Tsirkin wrote: > > On Mon, Jul 29, 2019 at 05:36:56PM +0200, Stefano Garzarella wrote: > > > On Mon, Jul 29, 2019 at 10:04:29AM -0400, Michael S. Tsirkin wrote: > > > > On Wed, Jul 17, 2019 at 01:30:26PM +0200, Stefano Garzarella wrote: > >

Hi Arseniy, On Sat, Aug 26, 2023 at 08:58:58PM +0300, Arseniy Krasnov wrote: >Hello, > >this small patchset adds POSIX compliant behaviour on writes to the >socket which was shutdowned with 'shutdown()' (both sides - local with >SHUT_WR flag, peer - with SHUT_RD flag). According POSIX we must send >SIGPIPE in such cases (but SIGPIPE is not send when MSG_NOSIGNAL is set).

On Mon, Jul 29, 2019 at 03:10:15PM -0400, Michael S. Tsirkin wrote: > On Mon, Jul 29, 2019 at 06:50:56PM +0200, Stefano Garzarella wrote: > > On Mon, Jul 29, 2019 at 06:19:03PM +0200, Stefano Garzarella wrote: > > > On Mon, Jul 29, 2019 at 11:49:02AM -0400, Michael S. Tsirkin wrote: > > > > On Mon, Jul 29, 2019 at 05:36:56PM +0200, Stefano Garzarella wrote: > >