similar to: libnbd | Failed pipeline for master | 65631e5d

Pipeline #819889104 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 2db30279 ( https://gitlab.com/nbdkit/libnbd/-/commit/2db30279bad4f9923baa541008f5da11624d2d1f ) Commit Message: socket activation: set LISTEN_FDNAMES Add LIST... Commit Author: Laszlo Ersek ( https://gitlab.com/lersek ) Pipeline

On 3/28/23 08:59, GitLab wrote: > GitLab > ? Pipeline #819889104 has failed! > > ? > Project nbdkit <https://gitlab.com/nbdkit> / libnbd > <https://gitlab.com/nbdkit/libnbd> > Branch > master <https://gitlab.com/nbdkit/libnbd/-/commits/master> > > Commit > 2db30279 >

Pipeline #785487102 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: b5101fbc ( https://gitlab.com/nbdkit/libnbd/-/commit/b5101fbc59cbdaef47e7843c735e8cc9f63fce10 ) Commit Message: use space consistently in function and function... Commit Author: Laszlo Ersek ( https://gitlab.com/lersek ) Pipeline

On Sun, Mar 19, 2023 at 10:41:37AM +0100, Laszlo Ersek wrote: > This is version 4 of the following sub-series: > > [libnbd PATCH v3 09/29] lib/utils: introduce async-signal-safe execvpe() > [libnbd PATCH v3 10/29] lib/utils: add unit tests for async-signal-safe execvpe() > > http://mid.mail-archive.com/20230215141158.2426855-10-lersek at redhat.com >

On 3/22/23 11:24, Daniel P. Berrang? wrote: > On Tue, Mar 21, 2023 at 03:56:22PM +0100, Laszlo Ersek wrote: >> On 3/21/23 15:05, Eric Blake wrote: >>> On Tue, Mar 21, 2023 at 07:04:59AM +0100, Laszlo Ersek wrote: >>>> On 3/20/23 20:41, Eric Blake wrote: >>>>> On Sun, Mar 19, 2023 at 10:41:37AM +0100, Laszlo Ersek wrote: >>>>>> This is

On Tue, Mar 21, 2023 at 03:56:22PM +0100, Laszlo Ersek wrote: > On 3/21/23 15:05, Eric Blake wrote: > > On Tue, Mar 21, 2023 at 07:04:59AM +0100, Laszlo Ersek wrote: > >> On 3/20/23 20:41, Eric Blake wrote: > >>> On Sun, Mar 19, 2023 at 10:41:37AM +0100, Laszlo Ersek wrote: > >>>> This is version 4 of the following sub-series: > >>>> >

On Wed, Feb 15, 2023 at 03:11:31PM +0100, Laszlo Ersek wrote: > Apply the ideas in the previous patch to the C-language bindings > generator. > > Signed-off-by: Laszlo Ersek <lersek at redhat.com> > --- > generator/C.ml | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > pr "#ifndef LIBNBD_ATTRIBUTE_NONNULL\n"; > -

We usually zero-initialize vectors like string_vector names = empty_vector; Allocating and zeroing separately is frequently useful however. Document the pattern string_vector names; names = (string_vector)empty_vector; where "(string_vector)empty_vector" is a compound literal. Link: http://mid.mail-archive.com/20230221183810.vjilfbmj3woqivlj at redhat.com Suggested-by: Eric

On 3/21/23 15:05, Eric Blake wrote: > On Tue, Mar 21, 2023 at 07:04:59AM +0100, Laszlo Ersek wrote: >> On 3/20/23 20:41, Eric Blake wrote: >>> On Sun, Mar 19, 2023 at 10:41:37AM +0100, Laszlo Ersek wrote: >>>> This is version 4 of the following sub-series: >>>> >>>> [libnbd PATCH v3 09/29] lib/utils: introduce async-signal-safe execvpe()

"Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 20079 qemu-upstream-4.3-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/20079/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking:

"Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 20078 qemu-upstream-4.2-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/20078/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking:

This is version 4 of the following sub-series: [libnbd PATCH v3 06/29] lib/utils: introduce xwrite() as a more robust write() [libnbd PATCH v3 07/29] lib/utils: add async-signal-safe assert() [libnbd PATCH v3 08/29] lib/utils: add unit test for async-signal-safe assert() http://mid.mail-archive.com/20230215141158.2426855-7-lersek at redhat.com

On Wed, Feb 15, 2023 at 03:11:34PM +0100, Laszlo Ersek wrote: > The "name##_iter" function is used 11 times in libnbd; in all those cases, > "name" is "string_vector", and the "f" callback is "free": > > string_vector_iter (..., (void *) free); > > Casting "free" to (void*) is ugly. (Well-defined by POSIX, but

From: Gerd Hoffmann <kraxel at redhat.com> [ Upstream commit 9b2a0a1ef66f96bf34921a3865581eca32ff05ec ] We must make sure our scatterlist segments are not too big, otherwise we might see swiotlb failures (happens with sev, also reproducable with swiotlb=force). Suggested-by: Laszlo Ersek <lersek at redhat.com> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> Reviewed-by:

On Tue, Mar 21, 2023 at 07:04:59AM +0100, Laszlo Ersek wrote: > On 3/20/23 20:41, Eric Blake wrote: > > On Sun, Mar 19, 2023 at 10:41:37AM +0100, Laszlo Ersek wrote: > >> This is version 4 of the following sub-series: > >> > >> [libnbd PATCH v3 09/29] lib/utils: introduce async-signal-safe execvpe() > >> [libnbd PATCH v3 10/29] lib/utils: add unit tests

flight 8803 xen-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/8803/ Regressions :-( Tests which did not succeed and are blocking: test-amd64-i386-rhel6hvm-intel 4 xen-install fail REGR. vs. 8769 test-amd64-i386-xl 4 xen-install fail REGR. vs. 8769 test-amd64-i386-pair 6 xen-install/dst_host fail REGR. vs. 8769

On 7/14/2023 4:13 PM, Eric Blake wrote: > On Fri, Jul 14, 2023 at 09:13:42AM +0200, Laszlo Ersek wrote: >> On 7/13/23 21:29, Eric Blake wrote: >>> The documentation has claimed since commit 6f4dcdab that any >>> completion callback will be called exactly once; but this is not >>> consistent with the code: if nbd_aio_* itself returns an error, then >>>

On Thu, Mar 23, 2023 at 01:10:16PM +0100, Laszlo Ersek wrote: > When the user calls nbd_set_socket_activation_name before calling > nbd_connect_system_socket_activation, pass the name down to the server > through LISTEN_FDNAMES. This has no effect unless the new API has > been called to set the socket name to a non-empty string. > >

<signal.h> in POSIX reserves the "sa_" prefix: https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_02_02 Let's use "saddr_" instead. Signed-off-by: Laszlo Ersek <lersek at redhat.com> --- ocaml/helpers.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ocaml/helpers.c b/ocaml/helpers.c index

From: "Richard W.M. Jones" <rjones at redhat.com> Original commit message: Thanks: Eric Blake Porting notes: We already have the nesting fix in the "common/include/minmax.h" header file, from nbdkit commit 9f462af12e3b ("common/include: Fix MIN and MAX macros so they can be nested", 2022-02-22), via libnbd commit 2f25695212db5. However, that port didn't