similar to: [PATCH] virtio_ring: Suppress tx interrupt when napi_tx disable

On Thu, Mar 23, 2023 at 4:01?PM ?? <huangjie.albert at bytedance.com> wrote: > > Jason Wang <jasowang at redhat.com> ?2023?3?22??? 10:37??? > > > > On Tue, Mar 21, 2023 at 5:00?PM Albert Huang > > <huangjie.albert at bytedance.com> wrote: > > > > > > From: "huangjie.albert" <huangjie.albert at bytedance.com> > > >

On Fri, Mar 24, 2023 at 02:47:02PM +0800, Jason Wang wrote: > On Fri, Mar 24, 2023 at 2:42?PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Fri, Mar 24, 2023 at 02:32:40PM +0800, Jason Wang wrote: > > > On Fri, Mar 24, 2023 at 1:59?PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > > > On Fri, Mar 24, 2023 at

is the below same as what I posted or different? how? On Sat, Mar 25, 2023 at 06:56:33PM +0800, Albert Huang wrote: > in virtio_net, if we disable the napi_tx, when we triger a tx interrupt, > the vq->event_triggered will be set to true. It will no longer be set to > false. Unless we explicitly call virtqueue_enable_cb_delayed or > virtqueue_enable_cb_prepare. > > If we

Hi Michael, Albert, Albert Huang wrote on Sat, Mar 25, 2023 at 06:56:33PM +0800: > in virtio_net, if we disable the napi_tx, when we triger a tx interrupt, > the vq->event_triggered will be set to true. It will no longer be set to > false. Unless we explicitly call virtqueue_enable_cb_delayed or > virtqueue_enable_cb_prepare. This patch (commited as 35395770f803

virtio_disable_cb is currently a nop for split ring with event index. This is because it used to be always called from a callback when we know device won't trigger more events until we update the index. However, now that we run with interrupts enabled a lot we also poll without a callback so that is different: disabling callbacks will help reduce the number of spurious interrupts. Further, if

On Thu, May 4, 2023 at 10:27?AM Wenliang Wang <wangwenliang.1995 at bytedance.com> wrote: > > For multi-queue and large ring-size use case, the following error > occurred when free_unused_bufs: > rcu: INFO: rcu_sched self-detected stall on CPU. > > Fixes: 986a4f4d452d ("virtio_net: multiqueue support") > Signed-off-by: Wenliang Wang <wangwenliang.1995 at

On Fri, May 05, 2023 at 11:28:25AM +0800, Jason Wang wrote: > On Thu, May 4, 2023 at 10:27?AM Wenliang Wang > <wangwenliang.1995 at bytedance.com> wrote: > > > > For multi-queue and large ring-size use case, the following error > > occurred when free_unused_bufs: > > rcu: INFO: rcu_sched self-detected stall on CPU. > > > > Fixes: 986a4f4d452d

On Fri, Aug 07, 2020 at 11:00:11AM +0800, ?? wrote: > Xin He <hexin.op at bytedance.com> ?2020?7?21??? ??6:17??? > > > > From: Qi Liu <liuqi.16 at bytedance.com> > > > > We should put the reference count of the fence after calling > > virtio_gpu_cmd_submit(). So add the missing dma_fence_put(). > > > > Fixes: 2cd7b6f08bc4 ("drm/virtio:

Add types and macros for packed ring. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- include/uapi/linux/virtio_config.h | 3 +++ include/uapi/linux/virtio_ring.h | 52 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 55 insertions(+) diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h index 449132c76b1c..1196e1c1d4f6 100644 ---

On Fri, Nov 30, 2018 at 04:10:55PM +0800, Jason Wang wrote: > > On 2018/11/21 ??6:03, Tiwei Bie wrote: > > Add types and macros for packed ring. > > > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > > --- > > include/uapi/linux/virtio_config.h | 3 +++ > > include/uapi/linux/virtio_ring.h | 52 ++++++++++++++++++++++++++++++++++++++ >

From: Xin He <hexin.op at bytedance.com> [ Upstream commit 836b194d65782aaec4485a07d2aab52d3f698505 ] Before setting shmem->pages to NULL, kfree() should be called. Signed-off-by: Xin He <hexin.op at bytedance.com> Reviewed-by: Qi Liu <liuqi.16 at bytedance.com> Link: http://patchwork.freedesktop.org/patch/msgid/20200722051851.72662-1-hexin.op at bytedance.com

From: Xin He <hexin.op at bytedance.com> [ Upstream commit 836b194d65782aaec4485a07d2aab52d3f698505 ] Before setting shmem->pages to NULL, kfree() should be called. Signed-off-by: Xin He <hexin.op at bytedance.com> Reviewed-by: Qi Liu <liuqi.16 at bytedance.com> Link: http://patchwork.freedesktop.org/patch/msgid/20200722051851.72662-1-hexin.op at bytedance.com

On Tue, Mar 28, 2023 at 12:05?PM Yongji Xie <xieyongji at bytedance.com> wrote: > > On Tue, Mar 28, 2023 at 11:44?AM Jason Wang <jasowang at redhat.com> wrote: > > > > On Tue, Mar 28, 2023 at 11:33?AM Yongji Xie <xieyongji at bytedance.com> wrote: > > > > > > On Tue, Mar 28, 2023 at 11:14?AM Jason Wang <jasowang at redhat.com> wrote: >

From: Cong Wang <cong.wang at bytedance.com> When virtqueue_add_sgs() fails, the skb is put back to send queue, we should not deliver the copy to tap device in this case. So we need to move virtio_transport_deliver_tap_pkt() down after all possible failures. Fixes: 82dfb540aeb2 ("VSOCK: Add virtio vsock vsockmon hooks") Cc: Stefan Hajnoczi <stefanha at redhat.com> Cc:

On Fri, Nov 30, 2018 at 02:01:06PM +0100, Maxime Coquelin wrote: > > > On 11/30/18 1:47 PM, Michael S. Tsirkin wrote: > > On Fri, Nov 30, 2018 at 05:53:40PM +0800, Tiwei Bie wrote: > > > On Fri, Nov 30, 2018 at 04:10:55PM +0800, Jason Wang wrote: > > > > > > > > On 2018/11/21 ??6:03, Tiwei Bie wrote: > > > > > Add types and macros

On Tue, Mar 28, 2023 at 11:03?AM Yongji Xie <xieyongji at bytedance.com> wrote: > > On Fri, Mar 24, 2023 at 2:28?PM Jason Wang <jasowang at redhat.com> wrote: > > > > On Thu, Mar 23, 2023 at 1:31?PM Xie Yongji <xieyongji at bytedance.com> wrote: > > > > > > To support interrupt affinity spreading mechanism, > > > this makes use of

On Fri, Nov 30, 2018 at 11:37:37PM +0800, Tiwei Bie wrote: > On Fri, Nov 30, 2018 at 08:52:42AM -0500, Michael S. Tsirkin wrote: > > On Fri, Nov 30, 2018 at 02:01:06PM +0100, Maxime Coquelin wrote: > > > On 11/30/18 1:47 PM, Michael S. Tsirkin wrote: > > > > On Fri, Nov 30, 2018 at 05:53:40PM +0800, Tiwei Bie wrote: > > > > > On Fri, Nov 30, 2018 at

On Sat, Dec 01, 2018 at 12:24:16AM +0800, Tiwei Bie wrote: > On Fri, Nov 30, 2018 at 10:53:07AM -0500, Michael S. Tsirkin wrote: > > On Fri, Nov 30, 2018 at 11:37:37PM +0800, Tiwei Bie wrote: > > > On Fri, Nov 30, 2018 at 08:52:42AM -0500, Michael S. Tsirkin wrote: > > > > On Fri, Nov 30, 2018 at 02:01:06PM +0100, Maxime Coquelin wrote: > > > > > On

On Tue, Feb 28, 2023 at 07:04:33PM +0000, Bobby Eshleman wrote: > Add support for sockmap to vsock. > > We're testing usage of vsock as a way to redirect guest-local UDS > requests to the host and this patch series greatly improves the > performance of such a setup. > > Compared to copying packets via userspace, this improves throughput by > 121% in basic testing.

On Sat, 2023-04-29 at 23:47 +0800, Wenliang Wang wrote: > For multi-queue and large ring-size use case, the following error > occurred when free_unused_bufs: > rcu: INFO: rcu_sched self-detected stall on CPU. > > Signed-off-by: Wenliang Wang <wangwenliang.1995 at bytedance.com> Net next is currently closed, but this patch could arguably land on the net tree - assuming