similar to: [PATCH 1/2] vdpa/mlx5: Make VIRTIO_NET_F_MRG_RXBUF off by default

On 3/12/2023 6:28 AM, Parav Pandit wrote: > >> From: Michael S. Tsirkin <mst at redhat.com> >> Sent: Sunday, March 12, 2023 6:25 AM >> >> On Sun, Mar 12, 2023 at 11:10:25AM +0200, Eli Cohen wrote: >>> On 12/03/2023 10:58, Michael S. Tsirkin wrote: >>>> On Sun, Mar 12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: >>>>> One can still

On Mon, Mar 13, 2023 at 09:14:38PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin <mst at redhat.com> > > Sent: Sunday, March 12, 2023 12:24 PM > > > > On Sun, Mar 12, 2023 at 01:28:06PM +0000, Parav Pandit wrote: > > > > > > > > > > From: Michael S. Tsirkin <mst at redhat.com> > > > > Sent: Sunday,

On Sun, Mar 12, 2023 at 01:28:06PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin <mst at redhat.com> > > Sent: Sunday, March 12, 2023 6:25 AM > > > > On Sun, Mar 12, 2023 at 11:10:25AM +0200, Eli Cohen wrote: > > > > > > On 12/03/2023 10:58, Michael S. Tsirkin wrote: > > > > On Sun, Mar 12, 2023 at 10:39:19AM +0200,

In below example, before the fix, mtu attribute is supported by the parent mgmtdev, but the error message showing "All provided are not supported" is just misleading. $ vdpa mgmtdev show vdpasim_net: supported_classes net max_supported_vqs 3 dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR ANY_LAYOUT VERSION_1 ACCESS_PLATFORM $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 mtu 5000

On Tue, Mar 21, 2023 at 01:28:08PM +0200, Eli Cohen wrote: > Following patch adds driver support for VIRTIO_NET_F_MRG_RXBUF. > > Current firmware versions show degradation in packet rate when using > MRG_RXBUF. Users who favor memory saving over packet rate could enable > this feature but we want to keep it off by default. > > One can still enable it when creating the vdpa

On Sun, Mar 12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: > One can still enable it when creating the vdpa device using vdpa tool by > providing features that include it. > > For example: > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features 0x300cb982b > > Signed-off-by: Eli Cohen <elic at nvidia.com> What's the reason to turn it off by default?

On Sun, Mar 12, 2023 at 11:10:25AM +0200, Eli Cohen wrote: > > On 12/03/2023 10:58, Michael S. Tsirkin wrote: > > On Sun, Mar 12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: > > > One can still enable it when creating the vdpa device using vdpa tool by > > > providing features that include it. > > > > > > For example: > > > $ vdpa dev add

Otherwise the virtqueue object to instate could point to invalid address that was unmapped from the MTT: mlx5_core 0000:41:04.2: mlx5_cmd_out_err:782:(pid 8321): CREATE_GENERAL_OBJECT(0xa00) op_mod(0xd) failed, status bad parameter(0x3), syndrome (0x5fa1c), err(-22) Fixes: cae15c2ed8e6 ("vdpa/mlx5: Implement susupend virtqueue callback") Cc: Eli Cohen <elic at nvidia.com>

Hi Eli, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20200717] url: https://github.com/0day-ci/linux/commits/Eli-Cohen/VDPA-support-for-Mellanox-ConnectX-devices/20200720-160220 base: aab7ee9f8ff0110bfcd594b33dc33748dc1baf46 config: x86_64-allyesconfig (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project

On Wed, Feb 15, 2023 at 9:31 AM Si-Wei Liu <si-wei.liu at oracle.com> wrote: > > Otherwise the virtqueue object to instate could point to invalid address > that was unmapped from the MTT: > > mlx5_core 0000:41:04.2: mlx5_cmd_out_err:782:(pid 8321): > CREATE_GENERAL_OBJECT(0xa00) op_mod(0xd) failed, status > bad parameter(0x3), syndrome (0x5fa1c), err(-22) > >

On 2/15/2023 8:48 PM, Jason Wang wrote: > On Wed, Feb 15, 2023 at 9:31 AM Si-Wei Liu <si-wei.liu at oracle.com> wrote: >> Otherwise the virtqueue object to instate could point to invalid address >> that was unmapped from the MTT: >> >> mlx5_core 0000:41:04.2: mlx5_cmd_out_err:782:(pid 8321): >> CREATE_GENERAL_OBJECT(0xa00) op_mod(0xd) failed, status

On Thu, Sep 24, 2020 at 05:32:31PM +0300, Eli Cohen wrote: > Change core vdpa functionality into a loadbale module such that upcoming > block implementation will be able to use it. > > Signed-off-by: Eli Cohen <elic at nvidia.com> Why don't we merge this patch together with the block module? > --- > V0 --> V1: > Removed "default n" for configu options

Today, mlx5_vdpa gets started by preallocate 1:1 DMA mapping at device creation time, while this 1:1 mapping will be implicitly destroyed when the first .set_map call is invoked. Everytime when the .reset callback is invoked, any mapping left behind will be dropped then reset back to the initial 1:1 DMA mapping. In order to reduce excessive memory mapping cost during live migration, it is

Live migration of vdpa would typically require re-instate vdpa device with an idential set of configs on the destination node, same way as how source node created the device in the first place. In order to allow live migration orchestration software to export the initial set of vdpa attributes with which the device was created, it will be useful if the vdpa tool can report the config on demand

On Tue, Sep 29, 2020 at 09:20:26AM +0300, Eli Cohen wrote: > On Mon, Sep 28, 2020 at 03:55:09PM -0400, Michael S. Tsirkin wrote: > > On Thu, Sep 24, 2020 at 05:32:31PM +0300, Eli Cohen wrote: > > > Change core vdpa functionality into a loadbale module such that upcoming > > > block implementation will be able to use it. > > > > > > Signed-off-by: Eli

On Tue, Sep 29, 2020 at 09:34:33AM +0300, Eli Cohen wrote: > On Tue, Sep 29, 2020 at 02:26:44AM -0400, Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 09:20:26AM +0300, Eli Cohen wrote: > > > On Mon, Sep 28, 2020 at 03:55:09PM -0400, Michael S. Tsirkin wrote: > > > > On Thu, Sep 24, 2020 at 05:32:31PM +0300, Eli Cohen wrote: > > > > > Change core

Hi Eli, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20200717] url: https://github.com/0day-ci/linux/commits/Eli-Cohen/VDPA-support-for-Mellanox-ConnectX-devices/20200720-160220 base: aab7ee9f8ff0110bfcd594b33dc33748dc1baf46 config: arc-allyesconfig (attached as .config) compiler: arc-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget

On Tue, Sep 29, 2020 at 09:57:44AM +0300, Eli Cohen wrote: > On Tue, Sep 29, 2020 at 02:51:12AM -0400, Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 09:34:33AM +0300, Eli Cohen wrote: > > > On Tue, Sep 29, 2020 at 02:26:44AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Sep 29, 2020 at 09:20:26AM +0300, Eli Cohen wrote: > > > > > On Mon, Sep

On Mon, Mar 13, 2023 at 09:34:50PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin <mst at redhat.com> > > Sent: Monday, March 13, 2023 5:24 PM > > I mean if this is claiming to fix a performance regression it should have a Fixes: > > tag with the commit that introduced the regression. > > The fixes tag should be, > > Fixes:

On Sun, Jan 15, 2023 at 7:08 PM Eli Cohen <elic at nvidia.com> wrote: > > > From: Jason Wang <jasowang at redhat.com> > > Sent: Wednesday, 11 January 2023 8:28 > > To: mst at redhat.com; jasowang at redhat.com > > Cc: Eli Cohen <elic at nvidia.com>; gdawar at amd.com; > > virtualization at lists.linux-foundation.org; linux-kernel at