similar to: [PATCH 3/3] virtio_ring: Use const to annotate read-only pointer params

On Tue, Mar 7, 2023 at 11:57?AM Feng Liu <feliu at nvidia.com> wrote: > > Add const to make the read-only pointer parameters clear, similar to > many existing functions. > > Signed-off-by: Feng Liu <feliu at nvidia.com> > Reviewed-by: Jiri Pirko <jiri at nvidia.com> > Reviewed-by: Parav Pandit <parav at nvidia.com> > Reviewed-by: Gavin Li <gavinl

Add const to make the read-only pointer parameters clear, similar to many existing functions. To implement this change, the commit also introduces the use of `container_of_const` to implement `to_vvq`, which ensures the const-ness of read-only parameters and avoids accidental modification of their members. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at

Add const to make the read-only pointer parameters clear, similar to many existing functions. Use `container_of_const` to implement `to_vvq`, which ensures the const-ness of read-only parameters and avoids accidental modification of their members. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> --- v0 -> v1 feedbacks from Michael S.

On Thu, Mar 16, 2023 at 2:55?AM Feng Liu <feliu at nvidia.com> wrote: > > According to the Virtio Specification, the Queue Size parameter of a > virtqueue corresponds to the maximum number of descriptors in that > queue, and it does not have to be a power of 2 for packed virtqueues. > However, the virtio_pci_modern driver enforced a power of 2 check for > virtqueue sizes,

According to the Virtio Specification, the Queue Size parameter of a virtqueue corresponds to the maximum number of descriptors in that queue, and it does not have to be a power of 2 for packed virtqueues. However, the virtio_pci_modern driver enforced a power of 2 check for virtqueue sizes, which is unnecessary and restrictive for packed virtuqueue. Split virtqueue still needs to check the

On Wed, Apr 11, 2018 at 10:03:32AM +0200, Jiri Pirko wrote: > Wed, Apr 11, 2018 at 08:24:43AM CEST, sridhar.samudrala at intel.com wrote: > >On 4/10/2018 11:03 PM, Jiri Pirko wrote: > >> Tue, Apr 10, 2018 at 05:59:02PM CEST, sridhar.samudrala at intel.com wrote: > >> > On 4/10/2018 8:43 AM, Jiri Pirko wrote: > >> > > Tue, Apr 10, 2018 at 05:27:48PM

On 4/10/2018 11:03 PM, Jiri Pirko wrote: > Tue, Apr 10, 2018 at 05:59:02PM CEST, sridhar.samudrala at intel.com wrote: >> On 4/10/2018 8:43 AM, Jiri Pirko wrote: >>> Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudrala at intel.com wrote: >>>> On 4/10/2018 8:22 AM, Jiri Pirko wrote: >>>>> Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudrala at

? 2023/2/20 21:56, Jiri Pirko ??: > Mon, Feb 20, 2023 at 01:55:33PM CET, mst at redhat.com wrote: >> On Mon, Feb 20, 2023 at 09:35:00AM +0100, Jiri Pirko wrote: >>> Fri, Feb 17, 2023 at 02:47:36PM CET, mst at redhat.com wrote: >>>> On Fri, Feb 17, 2023 at 01:53:55PM +0100, Jiri Pirko wrote: >>>>> Fri, Feb 17, 2023 at 01:22:01PM CET, mst at redhat.com

On 4/10/2018 8:43 AM, Jiri Pirko wrote: > Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudrala at intel.com wrote: >> On 4/10/2018 8:22 AM, Jiri Pirko wrote: >>> Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudrala at intel.com wrote: >>>> On 4/10/2018 3:55 AM, Jiri Pirko wrote: >>>>> Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudrala at

Tue, May 22, 2018 at 06:52:21PM CEST, mst at redhat.com wrote: >On Tue, May 22, 2018 at 05:45:01PM +0200, Jiri Pirko wrote: >> Tue, May 22, 2018 at 05:32:30PM CEST, mst at redhat.com wrote: >> >On Tue, May 22, 2018 at 05:13:43PM +0200, Jiri Pirko wrote: >> >> Tue, May 22, 2018 at 03:39:33PM CEST, mst at redhat.com wrote: >> >> >On Tue, May 22, 2018 at

On Fri, Feb 17, 2023 at 01:53:55PM +0100, Jiri Pirko wrote: > Fri, Feb 17, 2023 at 01:22:01PM CET, mst at redhat.com wrote: > >On Fri, Feb 17, 2023 at 01:15:47PM +0100, Jiri Pirko wrote: > >> From: Jiri Pirko <jiri at nvidia.com> > >> > >> virtio_net_hdr_from_skb() fills up hdr_len to skb_headlen(skb). > >> > >> Virtio spec introduced a

Jiri Pirko wrote: > Tue, Feb 21, 2023 at 05:12:33PM CET, willemdebruijn.kernel at gmail.com wrote: > >Jiri Pirko wrote: > >> Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.kernel at gmail.com wrote: > >> >Jiri Pirko wrote: > >> >> From: Jiri Pirko <jiri at nvidia.com> > >> >> > >> >> Virtio spec introduced a

On 4/10/2018 8:22 AM, Jiri Pirko wrote: > Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudrala at intel.com wrote: >> On 4/10/2018 3:55 AM, Jiri Pirko wrote: >>> Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudrala at intel.com wrote: >>>> On 4/9/2018 1:07 AM, Jiri Pirko wrote: >>>>> Sat, Apr 07, 2018 at 12:59:14AM CEST, sridhar.samudrala at

Wed, Apr 11, 2018 at 08:24:43AM CEST, sridhar.samudrala at intel.com wrote: >On 4/10/2018 11:03 PM, Jiri Pirko wrote: >> Tue, Apr 10, 2018 at 05:59:02PM CEST, sridhar.samudrala at intel.com wrote: >> > On 4/10/2018 8:43 AM, Jiri Pirko wrote: >> > > Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudrala at intel.com wrote: >> > > > On 4/10/2018 8:22 AM,

Wed, Apr 11, 2018 at 08:24:43AM CEST, sridhar.samudrala at intel.com wrote: >On 4/10/2018 11:03 PM, Jiri Pirko wrote: >> Tue, Apr 10, 2018 at 05:59:02PM CEST, sridhar.samudrala at intel.com wrote: >> > On 4/10/2018 8:43 AM, Jiri Pirko wrote: >> > > Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudrala at intel.com wrote: >> > > > On 4/10/2018 8:22 AM,

On Tue, May 22, 2018 at 05:45:01PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 05:32:30PM CEST, mst at redhat.com wrote: > >On Tue, May 22, 2018 at 05:13:43PM +0200, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 03:39:33PM CEST, mst at redhat.com wrote: > >> >On Tue, May 22, 2018 at 03:26:26PM +0200, Jiri Pirko wrote: > >> >> Tue, May 22, 2018 at

On Tue, May 22, 2018 at 05:45:01PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 05:32:30PM CEST, mst at redhat.com wrote: > >On Tue, May 22, 2018 at 05:13:43PM +0200, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 03:39:33PM CEST, mst at redhat.com wrote: > >> >On Tue, May 22, 2018 at 03:26:26PM +0200, Jiri Pirko wrote: > >> >> Tue, May 22, 2018 at

On Mon, Feb 20, 2023 at 09:35:00AM +0100, Jiri Pirko wrote: > Fri, Feb 17, 2023 at 02:47:36PM CET, mst at redhat.com wrote: > >On Fri, Feb 17, 2023 at 01:53:55PM +0100, Jiri Pirko wrote: > >> Fri, Feb 17, 2023 at 01:22:01PM CET, mst at redhat.com wrote: > >> >On Fri, Feb 17, 2023 at 01:15:47PM +0100, Jiri Pirko wrote: > >> >> From: Jiri Pirko <jiri

Mon, Feb 20, 2023 at 01:55:33PM CET, mst at redhat.com wrote: >On Mon, Feb 20, 2023 at 09:35:00AM +0100, Jiri Pirko wrote: >> Fri, Feb 17, 2023 at 02:47:36PM CET, mst at redhat.com wrote: >> >On Fri, Feb 17, 2023 at 01:53:55PM +0100, Jiri Pirko wrote: >> >> Fri, Feb 17, 2023 at 01:22:01PM CET, mst at redhat.com wrote: >> >> >On Fri, Feb 17, 2023 at

Tue, May 22, 2018 at 05:32:30PM CEST, mst at redhat.com wrote: >On Tue, May 22, 2018 at 05:13:43PM +0200, Jiri Pirko wrote: >> Tue, May 22, 2018 at 03:39:33PM CEST, mst at redhat.com wrote: >> >On Tue, May 22, 2018 at 03:26:26PM +0200, Jiri Pirko wrote: >> >> Tue, May 22, 2018 at 03:17:37PM CEST, mst at redhat.com wrote: >> >> >On Tue, May 22, 2018 at