similar to: Suggestion: Make _R_CHECK_LENGTH_1_LOGIC2_=warn the default for R 3.6.2

.On Mon, Nov 18, 2019 at 12:35 AM Martin Maechler <maechler at stat.math.ethz.ch> wrote: > > >>>>> Henrik Bengtsson > >>>>> on Sun, 17 Nov 2019 20:42:32 -0800 writes: > > > Hi, > > > I'm not sure where we are in getting CRAN packages getting their > > _R_CHECK_LENGTH_1_LOGIC2_=true bugs fixed (*), but maybe

On 11/18/19 3:44 PM, Henrik Bengtsson wrote: > .On Mon, Nov 18, 2019 at 12:35 AM Martin Maechler > <maechler at stat.math.ethz.ch> wrote: >>>>>>> Henrik Bengtsson >>>>>>> on Sun, 17 Nov 2019 20:42:32 -0800 writes: >> > Hi, >> >> > I'm not sure where we are in getting CRAN packages getting their

>>>>> Henrik Bengtsson >>>>> on Sun, 17 Nov 2019 20:42:32 -0800 writes: > Hi, > I'm not sure where we are in getting CRAN packages getting their > _R_CHECK_LENGTH_1_LOGIC2_=true bugs fixed (*), but maybe it'd help to > make _R_CHECK_LENGTH_1_LOGIC2_=warn the new default in the upcoming R > 3.6.2? Interesting, I had

Thank you. To correct myself, I can indeed reproduce this with R --vanilla too. A reproducible example is: $ R --vanilla R version 3.6.0 Patched (2019-05-31 r76629) -- "Planting of a Tree" ... > Sys.setenv("_R_CHECK_LENGTH_1_LOGIC2_" = "true") > loadNamespace("oligo") Error in omittedSig && (signature[omittedSig] != "missing") :

**Maybe this bug needs to be understood further before applying the patch because patch is most likely also wrong** Because, from just looking at the expressions, I think neither the R 3.6.0 version: omittedSig <- omittedSig && (signature[omittedSig] != "missing") nor the patched version (I proposed): omittedSig <- omittedSig & (signature[omittedSig] !=

DISCLAIMER: I can not get this error with R --vanilla, so it only occurs when some other package is also loaded. I don't have time to find to narrow that down for a reproducible example, but I believe the following error in R 3.6.0: > Sys.setenv("_R_CHECK_LENGTH_1_LOGIC2_" = "true") > library(oligo) Error in omittedSig && (signature[omittedSig] !=

>>>>> Ben Bolker >>>>> on Mon, 13 Jan 2020 11:49:09 -0500 writes: > From R NEWS (changes in 3.6.0) > Experimentally, setting environment variable _R_CHECK_LENGTH_1_LOGIC2_ > will lead to warnings (or errors if the variable is set to a ?true? > value) when && or || encounter and use arguments of length more than one. Indeed,

Henrik, If a minimal reprex is hard to construct, could you perhaps instrument your version of R to include a browser() call at the start of the else if(!all(signature[omittedSig] == "missing")) { branch, run the code that triggers the issue for you (and must hit that branch) and tell us what the "signature" and "omittedSig" objects look like at that point?

>>>>> Pages, Herve >>>>> on Thu, 14 Nov 2019 19:13:47 +0000 writes: > On 11/14/19 05:47, Hadley Wickham wrote: >> On Sun, Nov 10, 2019 at 2:37 AM Martin Maechler >> <maechler at stat.math.ethz.ch> wrote: >>> >>>>>>>> Gabriel Becker >>>>>>>> on Sat, 2 Nov 2019

Using: untrace(methods::conformMethod) at <- c(12,4,3,2) str(body(methods::conformMethod)[[at]]) ## language omittedSig <- omittedSig && (signature[omittedSig] != "missing") cc <- 0L trace(methods::conformMethod, tracer = quote({ cc <<- cc + 1L print(cc) if (cc == 31) { ## manually identified untrace(methods::conformMethod)

>>>>> Henrik Bengtsson via R-core >>>>> on Sun, 23 Jun 2019 11:29:58 -0700 writes: > Thank you. > To correct myself, I can indeed reproduce this with R --vanilla too. > A reproducible example is: > $ R --vanilla > R version 3.6.0 Patched (2019-05-31 r76629) -- "Planting of a Tree" > ... >>

Further, in addition to the `val <- FALSE` patch a few hours ago by Martin, the line after should also be changed - if(!is.logical(val) || is.na(val) || length(val) != 1L) + if(!is.logical(val) || length(val) != 1L || is.na(val)) ## Consider Sys.setenv("_R_CHECK_LENGTH_1_LOGIC2_" = "TRUE") options(stringsAsFactors = c(TRUE, FALSE)) default.stringsAsFactors() # correct

Argh! Yes you are right, the "fix" doesn't. And I fell into the same "hey it's a vector so && has to be wrong"-trap. So this has to be reverted to something that has at least failed unconspicuously for a decade.... Will do. Thanks to Martin for remaining suspicious! [This code was originally from 2009, by John Chambers. It is not too likely that he'll

>>>>> peter dalgaard >>>>> on Thu, 27 Jun 2019 16:23:14 +0200 writes: > Henrik, > If a minimal reprex is hard to construct, could you perhaps instrument your version of R to include a browser() call at the start of the > else if(!all(signature[omittedSig] == "missing")) { > branch, run the code that triggers the issue

>>>>> Avraham Adler >>>>> on Mon, 13 Jan 2020 14:38:12 -0500 writes: > Those of us stuck on Windows but who attempt to develop properly are > wounded to the quick, sir! > :) > Avi Indeed, you had a ' :) ' , but others have perceived this as an insult. I'm really really sorry for that and do want to apologize to all of

I run checks with R-devel rev. 76756 on several of my packages which use S4, with no ill effects. With the risk of not adding much, it seems that Martin's example, which I repeat below, suggests a crossover between several "signatures" involved here - the signature of the generic, the signature of the method (the argument for setMethod()), and the signature of the function object

On Sun, Nov 10, 2019 at 2:37 AM Martin Maechler <maechler at stat.math.ethz.ch> wrote: > > >>>>> Gabriel Becker > >>>>> on Sat, 2 Nov 2019 12:37:08 -0700 writes: > > > I agree that we can be careful and narrow and still see a > > nice improvement in behavior. While Herve's point is valid > > and I understand his

On Thu, Feb 1, 2018 at 12:14 AM, Martin Maechler <maechler at stat.math.ethz.ch> wrote: >>>>>> Michael Lawrence <lawrence.michael at gene.com> >>>>>> on Tue, 30 Jan 2018 15:57:42 -0800 writes: > > > I just meant that the minimal contract for as.list() appears to be that it > > returns a VECSXP. To the user, we might say

> On 28 Jun 2019, at 16:03 , Martin Maechler <maechler at stat.math.ethz.ch> wrote: > >>>>>> Henrik Bengtsson >>>>>> on Thu, 27 Jun 2019 16:00:39 -0700 writes: > >> Using: >> >> untrace(methods::conformMethod) >> at <- c(12,4,3,2) >> str(body(methods::conformMethod)[[at]]) >> ## language omittedSig

>>>>> Martin Maechler >>>>> on Sat, 29 Jun 2019 10:33:10 +0200 writes: >>>>> peter dalgaard >>>>> on Fri, 28 Jun 2019 16:20:03 +0200 writes: >> > On 28 Jun 2019, at 16:03 , Martin Maechler <maechler at stat.math.ethz.ch> wrote: >> > >> >>>>>> Henrik Bengtsson