similar to: [PATCH] remove check for OS SSE support from src/libFLAC/cpu.c

1. A program can use SSE instructions only if both CPU and OS support SSE. Currently libFLAC tests both CPU and OS for this support, but is it really necessary? Maybe CPU check is enough? Operating systems that don't support SSE (Win95, WinNT 4.0, Linux kernel 2.2 (iirc), ...) are really outdated now. Removing OS check will greatly simplify src/libFLAC/cpu.c. 2. "configure" build

Erik de Castro Lopo wrote: > lvqcl.mail wrote: >> now. Removing OS check will greatly simplify src/libFLAC/cpu.c. > > That makes sense. Should I post a patch that removes OS check and keeps only CPU check? >> 2. >> "configure" build system adds -msse2 option by default. It means that >> x86 (32-bit) library won't work on older, non-SSE2

lvqcl wrote: > Found a bug in Android OS SSE test. Sorry, what is the bug and how does this fix it? Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

lvqcl.mail wrote: > 1. > A program can use SSE instructions only if both CPU and OS support SSE. > Currently libFLAC tests both CPU and OS for this support, but is it really > necessary? Maybe CPU check is enough? Operating systems that don't support > SSE (Win95, WinNT 4.0, Linux kernel 2.2 (iirc), ...) are really outdated > now. Removing OS check will greatly simplify

libFLAC for Windows compiled with GCC/MinGW can't detect SSE OS support: it can't use GCC+Linux detection code and can't use MSVC+Win32 code that uses SEH (__try/__except). So it doesn't use any SSE/SSE2/etc routines. One way to fix it is to call configure script with --enable-sse (flac will probably crash on Win95/WinNT4 but who cares). Another way is to add a new code just for

Erik de Castro Lopo wrote: >> part 1: fixes >> >> part 2: new code >> >> Any comments? > > Applied cpu_part2.patch. Thanks! Thanks. I hope that this code will help to avoid "bug" reports such as http://sourceforge.net/p/flac/bugs/409/ (it seems that the author of this report compiled FLAC without --enable-sse option). OTOH, SSE support is

First off, this code is horrible to read and work on. The recent commits are the first of what I hope is a massive clean up of this code. lvqcl wrote: > So if I understand things correctly, the current meaning of --(en|dis)able-sse is: > > on Linux: > --enable-sse: > add -msse2 to the compiler switches > do not test SSE OS support (assume that SSE is

Hi all, Julian Calaby has weighed in and provided a bunch of fixes for the dreaded cpu.c file. I've pushed them to the wip/cpu branch and I'd appreciate it if people could test them. Assuming you already have a clone of the repo: git pull git checkout wip/cpu and then build as normal. Cheers, Erik -- ---------------------------------------------------------------------- Erik

Dave Yeo wrote: >>> >on other OSes: >>> > --enable-sse: >>> > add -msse2 to the compiler switches >>> > test SSE OS support (why?) >>> >It's a bit contradictory: why test whether *BSD etc support SSE or not >>> >but at the same time allow compiler to use SSE/SSE2 unconditionally? >> Yes,

Erik de Castro Lopo wrote: >> About part 1:does it have any problems? I can split it into several patches >> (1 fix = 1 patch) or explain the changes in it in detail. > > I didn't apply patch1 because I mis-read your comment here: > > http://lists.xiph.org/pipermail/flac-dev/2014-March/004582.html > > So, for the patches in this email: > >

lvqcl wrote: > Erik de Castro Lopo wrote: > > >> Found a bug in Android OS SSE test. > > > > Sorry, what is the bug and how does this fix it? > > FLAC__cpu_info(FLAC__CPUInfo *info): detects CPU features > that can be used and sets corresponding flags in the info > struct. This code is in flux and in the current state the logic probably has

The second version of the patch for OS SSE support detection part 1: fixes part 2: new code Any comments? -------------- next part -------------- A non-text attachment was scrubbed... Name: cpu_part1.patch Type: application/octet-stream Size: 3103 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140311/62b5ba0c/attachment.obj -------------- next part

lvqcl wrote: > 1) if FLAC__SSE_OS==1 then MSVC cannot compile current cpu.c: > "#include <windows.h>" line is inactive and MSVC complains: > cpu.c(278): error C2065: 'EXCEPTION_EXECUTE_HANDLER': undeclared identifier > cpu.c(279): error C2065: 'STATUS_ILLEGAL_INSTRUCTION': undeclared identifier > > 2) the current code (simplified): > >

Erik de Castro Lopo wrote: > I actually think my change is correct. It should be easier to see if you > look at the github version of the change: > > https://github.com/xiph/flac/commit/e120037f3c67b23fd9eef7ccd04d2df57fa1a9a6#diff-9f048b83ff55071de36263cf0f403b2eL209 > FLAC__NO_SSE_OS was never defined anywhere, so I think that the following changes should be made:

This patch tries to simplify the code that tries to detect whether OS supports SSE instructions. a) Linux: "old" vs "new" sigaction OBSOLETE_SIGCONTEXT_FLAVOR was disabled in Mar 2007 in commit <http://git.xiph.org/?p=flac.git;a=commit;h=1ca3a445f832be5e8a99364fb38d9e2ea9a3a772> According to <http://unixhelp.ed.ac.uk/CGI/man-cgi?sigaction>: "Support for

It's not possible to use ia32/*.nasm code in 64-bit compiles. There's still no 64-bit asm code in FLAC. I'm not familiar with asm too, so I wrote SSE-accelerated code using intrinsics. This code uses two new preprocessor macros: FLAC__CPU_X86_64 (analogous to FLAC__CPU_IA32) and FLAC__HAS_X86INTRIN (analogous to FLAC__HAS_NASM) Patch for cpu.c/cpu.h adds CPU features (sse3, ssse3)

1) Some time ago all project files for MSVC 6 were removed; it makes sense to remove the code that is necessary only for MSVC 6 and older compilers. --- a\src\libFLAC\cpu.c 2013-08-13 13:30:24.000000000 +0400 +++ b\src\libFLAC\cpu.c 2013-08-16 21:46:42.177485300 +0400 @@ -285,14 +285,7 @@ # ifdef USE_TRY_CATCH_FLAVOR _try { __asm { -# if _MSC_VER <= 1200 - /* VC6 assembler

More specifically, about this patch: http://git.xiph.org/?p=flac.git;a=commitdiff;h=70b078cfd5f9d4b0692c33f018cac3c652b14f90 I downloaded the latest code from git (flac-70b078c), disabled all SSE optimizations in the code and compiled it (GCC 4.8.2). This patch doesn't change FLAC output. Either gcc is too smart and optimizes this new code back to the old, or this fix is MSVS-specific. Or

Olivier Tristan <o.tristan at uvi.net> ?????(?) ? ????? ?????? Fri, 21 Mar 2014 22:41:00 +0400: > Check with -mfpmath=387 to be sure that x87 FPU code is used and not some > SSE optim made by GCC I added "XIPH_ADD_CFLAGS([-mfpmath=387])" into configure.ac Still the result is different from SSE version. --------------- MSVS adds two instructions to the generated code after

Here is patch for checking OS SSE support for systems having vfork()/fork() function. Index: src/libFLAC/cpu.c =================================================================== RCS file: /cvsroot/flac/flac/src/libFLAC/cpu.c,v retrieving revision 1.8 diff -u -r1.8 cpu.c --- src/libFLAC/cpu.c 2001/07/18 00:24:46 1.8 +++ src/libFLAC/cpu.c 2001/07/27 08:57:04 @@ -21,6 +21,20 @@