similar to: About the commit "Fix compiler warnings from new compiler flags."

Hi all, I finally managed to bite the bullet and roll a pre-release. Its here: http://downloads.xiph.org/releases/flac/beta/ I have personally tested this code on: x86-linux x86_64-linux powerpc-linux I have not yet done any work on making sure the changelog is up-to-date. That will be done between now and the release. What I'm after now is testing of this source tarball

lvqcl wrote: >>> Win_utf8 stuff should not be included in libflac since it's only to be >>> used by the flac.exe frontend. It is not needed by other programs nor >>> would they benefit from it without doing the extra work of converting >>> their ansi filenames and functions to utf-8. >>> >>>> Version 2 of my patch attached, which fixes

Martijn van Beurden wrote: > > 'chown', declared with attribute warn_unused_result [-Wunused-result] > > metadata_iterators.c:3299:2: warning: ignoring return value of > > 'chown', declared with attribute warn_unused_result [-Wunused-result] > > In file included from /usr/include/stdio.h:934:0, Thats an Ubuntu special. They have patched their libc headers

On 03-03-13 00:22, Erik de Castro Lopo wrote: > I have personally tested this code on: > > x86-linux > x86_64-linux > powerpc-linux Have you tried static building too? I just tried a bunch of switches for ../configure and both "--enable-static" as well as "--disable-shared --enable-static" fails for me on Kubuntu 12.04 64-bit with the following

JonY wrote: > What is your link test checking and how does it fail? My m4 macro is really simple, TRY_LINK a simple program with the stack protect CFLAGS: AC_DEFUN([XIPH_GCC_STACK_PROTECTOR], [AC_LANG_ASSERT(C) AC_MSG_CHECKING([if $CC supports stack smash protection]) xiph_stack_check_old_cflags="$CFLAGS" SSP_FLAGS="-fstack-protector --param ssp-buffer-size=4"

Janne Hyv?rinen wrote: > Patch v2, now handles more malformed cases. Original patch was for a > file for which I had a sample from a user but this allows handling some > manually broken test cases. Err, I'm getting warning messages on that patch: CC metadata_iterators.lo metadata_iterators.c: In function ?read_metadata_block_data_vorbis_comment_cb_?:

lvqcl wrote: > When I compile flac project with MSYS/MinGW-w64, I can see two files: > libFLAC.a and libFLAC-static.a. The only difference between them > is that libFLAC.a contains functions from win_utf8_io. > But 'make install' adds libFLAC.a into /local/lib, not libFLAC-static.a. Thank you for checking this. I've always had trouble with Autotools on Windows, even when

Hi Josh et al, I'm compiling on an Ubuntu Edgy x86 machine. Edgy comes standard with gcc-4.1 and I'm getting a number of warnings: memory.c: In function 'FLAC__memory_alloc_aligned': memory.c:52: warning: cast from pointer to integer of different size memory.c:52: warning: cast to pointer from integer of different size metadata_iterators.c: In function

Janne Hyv?rinen wrote: > Win_utf8 stuff should not be included in libflac since it's only to be > used by the flac.exe frontend. It is not needed by other programs nor > would they benefit from it without doing the extra work of converting > their ansi filenames and functions to utf-8. > >> Version 2 of my patch attached, which fixes the problem for the >>

Dear R People: I am attempting to install SparseM on R 2.15.0 on a Linux 11.10 system. Here is the output > install.packages("SparseM",depen=TRUE) Installing package(s) into ?/home/erin/R/x86_64-pc-linux-gnu-library/2.15? (as ?lib? is unspecified) --- Please select a CRAN mirror for use in this session --- Loading Tcl/Tk interface ... done trying URL

Erik de Castro Lopo wrote: > JonY wrote: > > > Please do a link time test instead, I am not getting this error and > > would like to keep stack protector on. > > I'll write an m4 macro. I have attampted to write a macro that reliably detects the availability of stack smash protection. I currently have two configurations where my detection says that SSP is available

From: Gene Cumm <gene.cumm at gmail.com> linux/syslinux.c: Silence warnings from GCC with asprintf's attribute warn_unused_result in certain glibc versions/patches. Assign it to a variable and ignore it as the string is already tested for null before using it. Signed-off-by: Gene Cumm <gene.cumm at gmail.com> --- diff --git a/libinstaller/setadv.c b/libinstaller/setadv.c index

My 2 cents: get rid of LLVM_UNUSED_RESULT, and move to LLVM_NODISCARD. For compilers that support it, it should be a strict superset of features and functionality. The standard feature was written directly based on the clang warn_unused_result stuff. I would just migrate us onto the spelling and usage pattern that got standardized. All we have to lose are warnings from compilers other than Clang

Here's a patch to allow flac and metaflac handle files with malformed vorbiscomment metadata block. -------------- next part -------------- diff --git a/src/libFLAC/metadata_iterators.c b/src/libFLAC/metadata_iterators.c index d50df39..39cb276 100644 --- a/src/libFLAC/metadata_iterators.c +++ b/src/libFLAC/metadata_iterators.c @@ -78,7 +78,7 @@ static FLAC__Metadata_SimpleIteratorStatus

Sanjoy Das <sanjoy at playingwithpointers.com> writes: > Hi Justin, > > This SGTM generally, but please make the difference between > LLVM_NODISCARD and LLVM_UNUSED_RESULT clear in the code. :) Right, this is where it gets a little weird. LLVM_NODISCARD would be for types, whereas LLVM_UNUSED_RESULT would be for functions. Depending on your host compiler, using the wrong one

There are new build errors in xen-unstable since revision 23368. Wether the _libxl_paths.h.tmp/_libxl_paths.h errros/warnings are new, no idea. Olaf .......... make -C libxl install make[3]: Entering directory `/usr/src/packages/BUILD/xen-unstable.hg-4.2.23437/tools/libxl'' python gentypes.py libxl.idl __libxl_types.h __libxl_types.c rm -f _libxl_paths.h.tmp.tmp; echo

I'm a neewbie in Linux, so please bear with me. I have a school assignment to make communication between 10 SIP softphones (kphone). So far I got trouble installing Asterisk. The information in asterisk web site seems to be a bit outdated because it's mentioned only kernel 2.4. Since Mandrake cooker (10.2beta3) witch I'm using is using kernel 2.6.10, I wander if I have a chance to

I started to try to use llvm::Error recently. This has nice runtime checks for if you didn't check the result, but I thought it would be really nice to get a compiler warning for the obvious cases of this rather than having to wait for a runtime check. This, of course, is exactly what the C++17 [[nodiscard]] attribute is for - with new enough compilers in C++17 mode we can just declare the

Hi, When I do the "make install-tools" with xen-4.2-unstable, there are some errors about "warn_unused_result". Is it the error in code or the error in the compiling environment? Thank you so much. gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .tapdisk-queue.o.d

This commit will break OS/2's EMX 0.9d library (GCC 2.8.1) which has been been replaced by klibc. Considering the age of EMX and lack of testing and that klibc contains so many improvements I think this is exceptable. --- include/FLAC/ordinals.h | 17 +++++++++-------- src/flac/main.c | 2 +- src/libFLAC/metadata_iterators.c | 2 +-