similar to: [PATCH] about configure.ac

1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty, even if x86intrin.h is not available. 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true': AM_CONDITIONAL(FLaC__SSE_OS, test "x$sse_os" = xtrue) It seems that it should be changed to AM_CONDITIONAL(FLaC__SSE_OS, test "x$sse_os" = xyes) 3) configure

lvqcl wrote: > lvqcl wrote: > > > 1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty, > > even if x86intrin.h is not available. > > > > 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true': > > The patch is attached. Please check it. Looks good. I need to do a little testing. > > 3)

lvqcl wrote: > 1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty, > even if x86intrin.h is not available. > > 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true': The patch is attached. Please check it. > 3) configure --disable-sse prints: > " SSE optimizations : ................... no" >

> lvqcl wrote: > >> 1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty, >> even if x86intrin.h is not available. >> >> 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true': > > The patch is attached. Please check it. Ping. Is the fix of FLAC__HAS_X86INTRIN definition necessary? Anyway I think

On 03/14/16 03:51 PM, lvqcl wrote: > With --disable-sse, FLAC__SSE_OS is undefined and FLAC__cpu_info() uses > sigemptyset/sigaction to determine OS SSE support. That's not quite right as I have to build binaries with --disable-sse (I build and distribute both with and without) so that some users on PII's don't get a sigill, even though the OS supports SSE. So it seems to

Erik de Castro Lopo wrote: > I actually think my change is correct. It should be easier to see if you > look at the github version of the change: > > https://github.com/xiph/flac/commit/e120037f3c67b23fd9eef7ccd04d2df57fa1a9a6#diff-9f048b83ff55071de36263cf0f403b2eL209 > FLAC__NO_SSE_OS was never defined anywhere, so I think that the following changes should be made:

Thomas Zander wrote: > In any case, the disable-SSE matter is still important. People are > still using flac on x86 machines without SSE, for instance AMD Geode > CPUs seem to live forever. libFLAC detects CPU SSE support in runtime, so --disable-sse is necessary for cuch CPUs only because it disables -msse2 switch. Maybe it makes sense to add new switch, --no-force-sse2 or

About the commit <http://git.xiph.org/?p=flac.git;a=commitdiff;h=e120037f3c67b23fd9eef7ccd04d2df57fa1a9a6> I admit I don't understand the following lines: #if !FLAC__SSE_OS /* assume user knows better than us; turn it off */ disable_sse(info); #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ...... Probably it should be #if FLAC__SSE_OS /*

I found that FLAC__cpu_have_cpuid_x86() was removed in the commit <http://git.xiph.org/?p=flac.git;a=commitdiff;h=fa24613ad94ba8fb8e23bcb9ca80b4548bb617e6> with the message: "Remove `FLAC__cpu_have_cpuid_x86` altogether as it wasn't actually being used but that was difficult to tell because of all the #ifdef nonsense." But FLAC__cpu_have_cpuid_x86() actually WAS used

On Fri, Apr 10, 2015 at 1:40 PM, lvqcl <lvqcl.mail at gmail.com> wrote: > Tristan Matthews wrote: > > > if test "x$asm_optimisation$sse_os" = "xyesyes" ; then > > XIPH_ADD_CFLAGS([-msse2]) > > - XIPH_ADD_CFLAGS([-mstackrealign]) > > + if test "$host_os" = "mingw32" ; then >

--- configure.ac | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..4347c07 100644 --- a/configure.ac +++ b/configure.ac @@ -399,9 +399,10 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) +

Building 1.3.2 on OpenBSD/i386, I get this error: cpu.c: In function 'ia32_cpu_info': cpu.c:128: error: 'FLAC__CPUINFO_IA32_CPUID_SSE3' undeclared (first use in this function) cpu.c:128: error: (Each undeclared identifier is reported only once cpu.c:128: error: for each function it appears in.) cpu.c:129: error: 'FLAC__CPUINFO_IA32_CPUID_SSSE3' undeclared (first use in

Function FLAC__cpu_xgetbv_x86() is declared and defined only if FLAC__HAS_X86INTRIN is defined. But now FLAC__cpu_info() tries to call it even if FLAC__HAS_X86INTRIN is undefined, which results in link error. This patch fixes the bug. -------------- next part -------------- A non-text attachment was scrubbed... Name: cpu_xgetbv.patch Type: application/octet-stream Size: 653 bytes Desc: not

Hi Guys, The following code in CPU.c (line 155) won't link if you don't have NASM code built even if FLAC__HAS_X86INTRIN is true as FLAC__cpu_info_asm_ia32 don't exists and the else is compiled if there is no dead code stripping if (FLAC__HAS_X86INTRIN) { FLAC__cpu_info_x86(0, &flags_eax, &flags_ebx, &flags_ecx, &flags_edx); info->ia32.intel =

Tristan Matthews wrote: > --- > configure.ac | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index eb9b0cc..e7d68c3 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then > > if test "x$asm_optimisation$sse_os" =

It's not possible to use ia32/*.nasm code in 64-bit compiles. There's still no 64-bit asm code in FLAC. I'm not familiar with asm too, so I wrote SSE-accelerated code using intrinsics. This code uses two new preprocessor macros: FLAC__CPU_X86_64 (analogous to FLAC__CPU_IA32) and FLAC__HAS_X86INTRIN (analogous to FLAC__HAS_NASM) Patch for cpu.c/cpu.h adds CPU features (sse3, ssse3)

Erik de Castro Lopo wrote: > When should FLAC__HAS_X86INTRIN be defined? What header file should I be > checking for? Ah, should be checking for <x86intrin.h>. The rest seems to be coming together. Testing this now. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

Erik de Castro Lopo wrote: > lvqcl.mail wrote: > >> Currently libFLAC doesn't check the existence of CPUID instruction if >> FLAC__HAS_X86INTRIN is set to 1. >> It's not a real problem because x86 CPUs without CPUID are probably >> extinct, but if libFLAC performs this check then it should do it >> in all cases (when NASM is available or intrinsics are

Hello All: I just checked out the whole icecast but cannot build anything because autogen wouldn't cooperate. I have automake-1.7.6 just installed from ftp.gnu.org. Below is an example output in trying to build "icecast"; it's not very short... Thanks in advance for any help. --- $~/icecast/icecast> ./autogen.sh Checking for automake version found automake found

Dave Yeo wrote: > Doesn't SSE support imply SSE2+ support? Not for the CPU. Just because a CPU supports SSE, does not mean it is guaranteed to support SSE2+. For OS support, I'm not sure. Didn't later version of SSE add new registers? > I have a '96 install of an OS, it has been upgraded until end of life, > and it handles SSE4+ instructions fine even though the