similar to: [PATCH] PPC/Altivec removal

Here's what I listed in that email. Merging doesn't appear to be necessary. If you have any build problems, let me know. Note that my detection code is Darwin-specific. It's a BSD call (sysctl()), so a change to the platform-detection macros should enable it to work on other BSDs. However, I don't know what that would be, and I couldn't determine any safe way to do the check

Erik de Castro Lopo wrote: >> > I'll try to power up my Linux/PPC machine in the next couple of days >> > so I can test this. >> >> Any news? > > Sorry, haven't had a chance to set up that machine. Hopefully this > weekend. I have several patches, but they interfere with this ppc/altivec patch. (one of them changes lpc.h,another changes

Erik de Castro Lopo wrote: > lvqcl wrote: > >> The most problematic parts are 3 and 4 since I cannot directly >> test them neither on Darwin PPC nor on Linux PPC. > > I'll try to power up my Linux/PPC machine in the next couple of days > so I can test this. Any news?

thanks for the feedback, but it would really help if you supply a patch (diff -c), I didn't understand all the changes you described. someone reported a problem with src/libFLAC/include/private/lpc.h that was fixed in CVS and may fix the problem building with asm disabled http://cvs.sourceforge.net/viewcvs.py/*checkout*/flac/flac/src/libFLAC/include/private/lpc.h?rev=1.24 Josh --- Luca

Erik de Castro Lopo wrote: >> There's the following code in stream_decoder.c: > > Like you, I don't see a lot of value in these. I think I'll decline > these. FLAC__lpc_restore_signal_asm_ia32_mmx compares 'order' argument with 4 and if it's greater then it jumps to FLAC__lpc_restore_signal_asm_ia32. I wonder why the same wasn't done for PPC/Altivec:

I think I've gotten FLAC__lpc_restore_signal() about as good as I'm going to get it. Here's what I have: -a new file, lpc_asm.s, which has the assembly routines -changes to cpu.h, cpu.c, and stream_decoder.c to enable them -changes to configure.in to support the new cpu stuff -a preliminary Makefile.am -maybe something else I'm forgetting Now automake complains that configure.in

Sadly the latest optimization broke completely everything. The asm code isn't gas compliant. the libFLAC linker script has a typo, disabling the asm optimization and/or altivec won't let a correct build anyway. Instant fixes for the asm stuff: sed -i -e"s:;:\#:" on the lpc_asm.s to load address instead of addis+ori you could use lis and la and PLEASE use the @l(register)

--- Luca Barbato <lu_zero@gentoo.org> wrote: > Josh Coalson wrote: > > since I don't know how to resolve this, in current CVS I have > > checked in a system where there are src/libFLAC/ppc/as and > > src/libFLAC/ppc/gas selected by configure. I have also checked > > in as many patches as I could make sense of (the cpu.c detection > > stuff and the

--- John Steele Scott <toojays@toojays.net> wrote: > Josh Coalson <xflac@yahoo.com> writes: > > > --- John Steele Scott <toojays@toojays.net> wrote: > >> Back in October 2004, I did a bit of work on FLAC to get version > >> 1.1.1 to > >> build correctly under GNU/Linux/PPC. Only now have I realised that > >> somewhere > >>

Josh Coalson wrote: > --- Luca Barbato <lu_zero@gentoo.org> wrote: > >>Josh Coalson wrote: >> >>>since I don't know how to resolve this, in current CVS I have >>>checked in a system where there are src/libFLAC/ppc/as and >>>src/libFLAC/ppc/gas selected by configure. I have also checked >>>in as many patches as I could make sense of

Josh Coalson wrote: > since I don't know how to resolve this, in current CVS I have > checked in a system where there are src/libFLAC/ppc/as and > src/libFLAC/ppc/gas selected by configure. I have also checked > in as many patches as I could make sense of (the cpu.c detection > stuff and the configure.in stuff). can you guys take a look at > current CVS and help me get

Josh Coalson <xflac@yahoo.com> writes: > --- John Steele Scott <toojays@toojays.net> wrote: >> Back in October 2004, I did a bit of work on FLAC to get version >> 1.1.1 to >> build correctly under GNU/Linux/PPC. Only now have I realised that >> somewhere >> along the way something broke in FLAC's decoding. On my machine, >> roughly 50%

Luca Barbato <lu_zero@gentoo.org> writes: > Josh Coalson wrote: >>>Probably a version check could help. >> how about this logic: >> if cpu is ppc >> if as exists >> if as is apple version >> use as >> else if as is gnu version >> use as to assemble but src/libFLAC/ppc/gas directory >> else >>

Anybody knows the reason for the following code (you can see it in flac/decode.c, flac/encode.c, libFLAC/fixed.c and libFLAC/stream_decoder.c) ? #if defined _MSC_VER || defined __MINGW32__ /* with MSVC you have to spoon feed it the casting */ residual_bits_per_sample[0] = (FLAC__float)((total_error_0 > 0) ? log(M_LN2 * (FLAC__double)(FLAC__int64)total_error_0 /

I don't understand the comment in src/libFLAC/stream_decoder.c: /*@@@@@@ technically not pessimistic enough, should be more like if( (FLAC__uint64)order * ((((FLAC__uint64)1)<<bps)-1) * ((1<<subframe->qlp_coeff_precision)-1) < (((FLAC__uint64)-1) << 32) ) */ if(bps + subframe->qlp_coeff_precision + FLAC__bitmath_ilog2(order) <= 32) see

lvqcl wrote: > The most problematic parts are 3 and 4 since I cannot directly > test them neither on Darwin PPC nor on Linux PPC. I'll try to power up my Linux/PPC machine in the next couple of days so I can test this. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

1) lpc.c, FLAC__lpc_quantize_coefficients(): This function declares "const int nshift = -(*shift)" variable when *shift is less than 0. Then nshift is used in the loop: for(i = 0; i < order; i++) { error += lp_coeff[i] / (1 << nshift); This patch adds "const int pshift = *shift" variable. Pros: * more symmetry for two branches * compiler doesn't

lvqcl wrote: > When I compile flac project with MSYS/MinGW-w64, I can see two files: > libFLAC.a and libFLAC-static.a. The only difference between them > is that libFLAC.a contains functions from win_utf8_io. > But 'make install' adds libFLAC.a into /local/lib, not libFLAC-static.a. Thank you for checking this. I've always had trouble with Autotools on Windows, even when

hello! Today I tried to compile the new FLAC 0.8 sourcecode on my SuSE Linux 7.1 machine and failed. Below is the output of "make" and "configure". I hope the information is enough that somebody can help me to compile the source. Thanks a lot. PS: A lot of thanks to all developers of FLAC. Its very useful to me!! ------------------------------------------------------ This

In function read_metadata_vorbiscomment_ from stream_decoder.c, at various locations where we short circuit the computation, we also set `obj->num_comments` accordingly. For example: https://git.xiph.org/?p=flac.git;a=blob;f=src/libFLAC/stream_decoder.c;h=e0f1b14d30dd548268a88e4341af3f38290816e3;hb=HEAD#l1736