similar to: [PATCH] missed --force-raw-format

On Nov 26 22:39:27, hans at stare.cz wrote: > ./test_replaygain.sh fails for me in tonegenerator(), saying: > > ./test_replaygain.sh[91]: mawk: not found > Testing FLAC replaygain 8000 (8000 x 1) ... -: ERROR: got partial sample > > Apparently, the tone-generating awk script does not work with > my system's awk, which is "awk version 20110810" as distributed

Not only test_replaygain.sh (commit 1988855), but also test_flac.sh requires additional --force-raw-format option. -------------- next part -------------- A non-text attachment was scrubbed... Name: test_flac.patch Type: application/octet-stream Size: 2176 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140709/1ab42e3d/attachment.obj

On Dec 10 23:04:44, mle+la at mega-nerd.com wrote: > Definitely interested in a cross platform solution to this. Diff below. Please test. On Dec 03 13:21:16, hans at stare.cz wrote: > On Nov 30 14:33:47, hans at stare.cz wrote: > > On Nov 26 22:39:27, hans at stare.cz wrote: > > > ./test_replaygain.sh fails for me in tonegenerator(), saying: > > > > > >

In the precompute_partition_info_sums_ function, instead of selecting 64-bit accumulator when the signal bps is larger than 16, revert to the original approach based on partition size, but make room for few extra bits to not overflow with unusual signals where the average residual magnitude may be larger than bps. It slightly improves the performance with standard encoding levels and 16-bit files

Erik de Castro Lopo wrote: >> It slightly improves the performance with standard encoding levels and >> 16-bit files as the 17-bit side channel can still be processed with the >> 32-bit accumulator and correctly selects the 64-bit accumulator with >> very large 16-bit partitions. >> >> This is related to commits 6f7ec60c and 187e596e. > > Sorry I

I changed the condition in *_precompute_partition_info_sums_*() functions from if(bps <= 16) to if(FLAC__bitmath_ilog2(default_partition_samples) + bps < 32) and then changed the 'subframe_bps' argument of find_best_partition_order_() in evaluate_fixed_subframe_() and evaluate_lpc_subframe_() as follows: evaluate_fixed_subframe_(): evaluate_lpc_subframe_(): 1)

On Nov 26 22:39:27, hans at stare.cz wrote: > On Nov 25 00:43:22, mle+la at mega-nerd.com wrote: > > http://downloads.xiph.org/releases/flac/beta/ > > Please test. > > ./test_replaygain.sh fails for me in tonegenerator(), saying: > > ./test_replaygain.sh[91]: mawk: not found > Testing FLAC replaygain 8000 (8000 x 1) ... -: ERROR: got partial sample > >

On Thu, Aug 14, 2014 at 12:34 PM, lvqcl <lvqcl.mail at gmail.com> wrote: > Jose Pablo Carballo <jose.carballo at ridgerun.com> wrote: > >> - channels = 2; >> - bps = 16; >> + channels = ((unsigned)buffer[23] << 8) | buffer[22]; >> + bps = ((unsigned)buffer[35] << 8) | buffer[34]; >> total_samples = (((((((unsigned)buffer[43] << 8)

When decoding a FLAC file with bits per sample that is not a multiple of 8 and outputting in raw format, the decoder gets as far as the write callback before realising that it doesn't know how to write the data. It then fails with an unhelpful message (or trips an assert() in debug mode). The attached patch performs the check earlier, and gives a more helpful error message. Kind

(ping, if there is any interest). On Dec 03 13:21:16, hans at stare.cz wrote: > On Nov 30 14:33:47, hans at stare.cz wrote: > > On Nov 26 22:39:27, hans at stare.cz wrote: > > > ./test_replaygain.sh fails for me in tonegenerator(), saying: > > > > > > ./test_replaygain.sh[91]: mawk: not found > > > Testing FLAC replaygain 8000 (8000 x 1) ... -: ERROR:

Hi Guys, I've just faced a wrong warning trying to encode a 24 bits WAV file if(wFormatTag == 1) { if(bps != 8 && bps != 16) { if(bps == 24 || bps == 32) { /* let these slide with a warning since they're unambiguous */ flac__utils_printf(stderr, 1, "%s: WARNING: legacy WAVE file has

On Thu, Jun 19, 2014 at 03:30:22PM +0400, lvqcl wrote: > BTW, what can you say about the following place in stream_decoder.c > in read_subframe_lpc_() function: > > /*@@@@@@ technically not pessimistic enough, should be more like > if( (FLAC__uint64)order * ((((FLAC__uint64)1)<<bps)-1) * ((1<<subframe->qlp_coeff_precision)-1) < (((FLAC__uint64)-1)

Hi, In the last days I've been taking as reference the example found in examples/c/encode/file/main.c. With it I've been able to encode a 2ch, 16 bps, 44100 sample rate input WAV file to a FLAC file. Now I've been trying to modify this example to encode a 2ch, 24 bps, 96000 sample rate WAV file. I have to say I'm a bit lost on how I should read the input file in this case, and

Here I attach a preliminary version of a patch for precompute_partition_info_sums_() function that should accelerate encoding of 24-bit input data. 1) SSE2, SSSE3 and AVX2 versions of this function should be updated, too 2) the patch also changes if(FLAC__bitmath_ilog2(default_partition_samples) + bps + FLAC__MAX_EXTRA_RESIDUAL_BPS < 32) into (in effect)

I don't understand the comment in src/libFLAC/stream_decoder.c: /*@@@@@@ technically not pessimistic enough, should be more like if( (FLAC__uint64)order * ((((FLAC__uint64)1)<<bps)-1) * ((1<<subframe->qlp_coeff_precision)-1) < (((FLAC__uint64)-1) << 32) ) */ if(bps + subframe->qlp_coeff_precision + FLAC__bitmath_ilog2(order) <= 32) see

Hi all, As people may have seen there's a pre-release here: http://downloads.xiph.org/releases/flac/beta/ Specifically: flac-1.3.1pre1.tar.xz : The source code flac-1.3.1pre1-win.zip : Windows 32 and 64 bit binaries Please test. I'm particularly interested in hearing about the windows binaries which were cross compiled from Linux to Windows. Unfortunately there is a bug

On Nov 30 14:33:47, hans at stare.cz wrote: > On Nov 26 22:39:27, hans at stare.cz wrote: > > ./test_replaygain.sh fails for me in tonegenerator(), saying: > > > > ./test_replaygain.sh[91]: mawk: not found > > Testing FLAC replaygain 8000 (8000 x 1) ... -: ERROR: got partial sample > > > > Apparently, the tone-generating awk script does not work with >

The commit http://git.xiph.org/?p=flac.git;a=commitdiff;h=0a0a10f358345f749e4a05021301461994f1ffc5 (from 31 Mar 2007) adds the following conditional: if(FLAC__bitmath_ilog2(default_partition_samples) + bps < 32) And the commit http://git.xiph.org/?p=flac.git;a=commitdiff;h=f081524c19eeafd08f4db6ee5d52a9634c60f475 has this: if(FLAC__bitmath_ilog2(default_partition_samples) +

On Fri, Jun 20, 2014 at 01:21:03PM +0400, lvqcl wrote: > Miroslav Lichvar ?????: > > > +/* > > + * This is used to avoid overflow with unusual signals in 32-bit > > + * accumulator in the *precompute_partition_info_sums_* functions. > > + */ > > +#define FLAC__MAX_EXTRA_RESIDUAL_BPS 4 > > > + /* WATCHOUT: "+ bps +

Just realized that it's also possible to do the same with "if(bps <= 16)" branch of code and remove FLAC__uint32 abs_residual_partition_sum variable. -------------- next part -------------- A non-text attachment was scrubbed... Name: precomp_part2.patch Type: application/octet-stream Size: 5153 bytes Desc: not available Url :