similar to: Bug in FLAC or in GCC or somewhere else?

On Sat, Jun 04, 2005 at 08:00:45AM -0700, Ralph Giles wrote: > The replay gain code has dos line endings in CVS, which causes problems > for the Sun compiler, among others. Attached is a patch for the lazy, > but it's probably easier to fix locally and commit. Now with actual patch... -r -------------- next part -------------- Index:

The replay gain code has dos line endings in CVS, which causes problems for the Sun compiler, among others. Attached is a patch for the lazy, but it's probably easier to fix locally and commit. -r

lvqcl wrote: > I noticed that 32-bit flac (from git) compiled with GCC 4.8.3 or 4.9.0 > calculates incorrect ReplayGain values. The most common value it produces > is -55.17 dB. It seems that it's a bug in GCC: it cannot correctly calculate the value of 'elems * (1. - RMS_PERCENTILE)' in the line upper = (Int32_t) ceil (elems * (1. - RMS_PERCENTILE)); Since elems *

Erik de Castro Lopo wrote: >> 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test "x$cpu_x86_64" = xtrue)' >> >> Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, >> not FLAC__. A quote from configure.ac: "NOTE that for many of the AM_CONDITIONALs >> we use the prefix FLaC__ instead of FLAC__ since

Some projects/makefiles add both 'include' and 'include/share' to the list of additional include directories. For example, src/share/utf8/utf8.c includes 'include/share/alloc.h' as "share/alloc.h" but 'include/share/utf8.h' as just "utf8.h". Also src/share/replaygain_analysis/replaygain_analysis.c includes "replaygain_analysis.h", not

Erik de Castro Lopo wrote: > lvqcl wrote: > > > Some projects/makefiles add both 'include' and 'include/share' > > to the list of additional include directories. > > I think that is suboptimal. > > > For example, src/share/utf8/utf8.c includes 'include/share/alloc.h' > > as "share/alloc.h" but

lvqcl wrote: > Some projects/makefiles add both 'include' and 'include/share' > to the list of additional include directories. I think that is suboptimal. > For example, src/share/utf8/utf8.c includes 'include/share/alloc.h' > as "share/alloc.h" but 'include/share/utf8.h' as just "utf8.h". > > Also

another small bug: in src\share\replaygain_analysis\replaygain_analysis.c there are two assignments to sampleWindow: sampleWindow = (int) ceil ((double)samplefreq * (double)RMS_WINDOW_TIME / 1000.0); sampleWindow = (replaygainfilter->rate * RMS_WINDOW_TIME + 1000-1) / 1000; -------------- next part -------------- A non-text attachment was scrubbed... Name:

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Tried to do this, gcc complained a lot about undefined references. After a bit of mucking with the code, i came up with a few patches. This might be a good conversation starter. The build that i've got out of this does pass the testsuite. To enable LTO you just need to apply these (for non-W32 builds you probably only need one of the patches)

On 5/24/14, lvqcl <lvqcl.mail at gmail.com> wrote: > Ozkan Sezer <sezeroz at gmail.com> ?????(?) ? ????? ?????? Sat, 24 May 2014 > 10:16:15 +0400: > >> - changes the _MSC_VER condition to universally _WIN32: MSVC, as well >> as GCC supports this. > > MSYS/MinGW 4.8.3, 4.9.0 can't compile code from git after this patch: > > format.c:47:22: error:

Josh: > fixed, thanks! Thanks. However, I think there is a better patch to fix these problems. I reworked this patch not long ago to do better testing for what inline to use in configure, and also a better way to calculate the size of the #defines in replaygain_analysis.c. This was submitted to the SourceForge bug tracker as bug 1701960. See here, and note attached patch.

The autoreconf tool is provided by autoconf to do what custom autogen.sh scripts in many projects used to do. Only it is more robust and widely tested. It has been available for several years, too. No reason to rely on custom code for this. Signed-off-by: Max Horn <max at quendi.de> --- Makefile.am | 2 - autogen.sh | 168

Hello, This is a patch to allow building of the project using MSYS, MinGW, and MinGW-w64 with the following invocation: make -f Makefile.lite libFLAC libFLAC++ flac metaflac test_libs_common test_libFLAC test_libFLAC++ test_grabbag test_seeking test_streams utils examples This patch addresses eight points: 1. `uname -p` in MSYS returns "unknown" so we must use `gcc -dumpmachine`

Hello, This is a patch to allow building of the project using MSYS, MinGW, and MinGW-w64 with the following invocation: make -f Makefile.lite libFLAC libFLAC++ flac metaflac test_libs_common test_libFLAC test_libFLAC++ test_grabbag test_seeking test_streams utils examples This patch addresses eight points: 1. `uname -p` in MSYS returns "unknown" so we must use `gcc -dumpmachine`

Most of the programs don't use libogg or libm directly and should not link to them (overlinking). --- examples/c/decode/file/Makefile.am | 4 +--- src/flac/Makefile.am | 1 - src/metaflac/Makefile.am | 4 +--- src/plugin_xmms/Makefile.am | 1 - src/test_grabbag/cuesheet/Makefile.am | 4 +--- src/test_grabbag/picture/Makefile.am | 4

That enables an special implementation that checks for common memory errors and will save us from a lot pain. --- test/test_bins.sh | 2 ++ test/test_flac.sh | 2 ++ test/test_grabbag.sh | 2 ++ test/test_libFLAC++.sh | 2 ++ test/test_libFLAC.sh | 3 +++ test/test_metaflac.sh | 2 ++ test/test_seeking.sh | 2 ++ test/test_streams.sh | 2 ++ 8 files

- INCLUDES is deprecated, and CPPFLAGS is an user-defined variable, use the proper AM_CPPFLAGS instead - Remove FLAC__INLINE definition, providing proper replacement for MSVC compilers. - Detect if we have C99 's lround and provide a replacement for windows... --- configure.ac | 32 ++++++++-------------------- examples/c/decode/file/Makefile.am

On Mon, Jun 16, 2014 at 4:10 AM, lvqcl <lvqcl.mail at gmail.com> wrote: > Erik de Castro Lopo wrote: > >> Ok, done for the autotool build system. Would appreciate it if someone >> could look that the VS build files. > > > I'll do it, but: I cannot build 32-bit flac with MinGW: > > <-------------------------------------------------------------> >

Hi, I'm trying to build current git on i386, but it fails with the following error: make[3]: Entering directory '/tmp/flac/src/share' CC grabbag/replaygain.lo In file included from grabbag/replaygain.c:38:0: ../../include/share/replaygain_analysis.h:45:15: error: conflicting types for 'float_t' typedef float float_t; /* Type used for filtering */

On Tue, Aug 17, 2010 at 3:12 PM, Paul Davis <paul at linuxaudiosystems.com> wrote: > On Mon, Aug 16, 2010 at 11:09 PM, Glenn McCord <glenn.mccord at gmail.com> wrote: > >> libtool: link: gcc -I/Users/glennm/libOGG-i386/include -O3 >> -funroll-loops -finline-functions -Wall -W -Winline -arch i386 -arch >> i386 -o flac analyze.o decode.o encode.o