similar to: Building FLAC with LTO

On 5/24/14, lvqcl <lvqcl.mail at gmail.com> wrote: > Ozkan Sezer <sezeroz at gmail.com> ?????(?) ? ????? ?????? Sat, 24 May 2014 > 10:16:15 +0400: > >> - changes the _MSC_VER condition to universally _WIN32: MSVC, as well >> as GCC supports this. > > MSYS/MinGW 4.8.3, 4.9.0 can't compile code from git after this patch: > > format.c:47:22: error:

Ozkan Sezer wrote: > flac.exe built with mingw with or without the dllimport/dllexport patch > always requires libFLAC-8.dll (because flac/Makefile.am has libFLAC.la > in flac_LDADD and not libFLAC-static.la), and the patch doesn't make it > any more or any less dependent on any 'foreign' dlls: the patch doesn't > change the existent situation in that regard. If

The following patch changes export.h so that the dllimport/dllexport attributes work with mingw/mingw-w64 and others: - changes _declspec keyword to __declspec: the former may not be defined by some toolchains. - changes the _MSC_VER condition to universally _WIN32: MSVC, as well as GCC supports this. Attached patch: declspec.diff Regards. -- O.S. -------------- next part --------------

--- src/libFLAC/include/private/ogg_mapping.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libFLAC/include/private/ogg_mapping.h b/src/libFLAC/include/private/ogg_mapping.h index b8f2d2f..4e3bdea 100644 --- a/src/libFLAC/include/private/ogg_mapping.h +++ b/src/libFLAC/include/private/ogg_mapping.h @@ -29,17 +29,17 @@ * SOFTWARE, EVEN IF ADVISED OF THE

With gcc >= 4 and ELF, set default visibility to hidden and make visible only the symbols with FLAC_API or FLACPP_API. A convenience libFLAC-static.la is created for test_libFLAC as it depends on the hidden symbols. --- configure.ac | 8 +++++++- include/FLAC++/export.h | 13 +++++++++---- include/FLAC/export.h | 13 +++++++++---- src/libFLAC/Makefile.am | 10

* This is required, as otherwise -Wl,--as-needed could fail. --- src/flac/Makefile.am | 2 +- src/metaflac/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/flac/Makefile.am b/src/flac/Makefile.am index bf3bf468..fe6fa489 100644 --- a/src/flac/Makefile.am +++ b/src/flac/Makefile.am @@ -60,7 +60,7 @@ flac_LDADD = \

Erik de Castro Lopo wrote: > Ozkan Sezer wrote: > >> My apologies, obviously sent an old testing patch. Correct one is >> attached (declspec2.diff). Compilation tested using MinGW (gcc-3.4.5, >> binutils-2.20), and MinGW-w64 (gcc-4.5.4, binutils-2.21.90.) > > lvqcl, > > Can you please validate this new patch? It works, but only if i call ./configure without

libFLAC* must never have undefined symbols no matter what is the target platform. --- configure.ac | 10 +--------- src/libFLAC++/Makefile.am | 2 +- src/libFLAC/Makefile.am | 2 +- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 50ef80e..ba46caf 100644 --- a/configure.ac +++ b/configure.ac @@ -129,19 +129,11 @@

They are not needed since the section is defined in nasm.h. --- src/libFLAC/ia32/bitreader_asm.nasm | 4 ---- src/libFLAC/ia32/cpu_asm.nasm | 4 ---- src/libFLAC/ia32/fixed_asm.nasm | 4 ---- src/libFLAC/ia32/lpc_asm.nasm | 4 ---- src/libFLAC/ia32/stream_encoder_asm.nasm | 4 ---- 5 files changed, 20 deletions(-) diff --git

Not all linux hosts match the *-pc-linux-gnu wildcard, causing build failures for older glibc versions where we need to link with -lrt for clock_gettime - E.G.: - arm-unknown-linux-musleabihf - powerpc-unknown-linux-gnuspe - bfin-linux-linux-uclibc .. Signed-off-by: Peter Korsgaard <peter at korsgaard.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Not all linux hosts match the *-pc-linux-gnu wildcard, causing build failures for older glibc versions where we need to link with -lrt for clock_gettime - E.G.: - arm-unknown-linux-musleabihf - powerpc-unknown-linux-gnuspe - bfin-linux-linux-uclibc .. Signed-off-by: Peter Korsgaard <peter at korsgaard.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

The underscores are wrong. The comment is also correct. Also remove the configure.ac option. Otherwise it tries to compile the windows unicode stuff which POSIX(cygwin) does not understand. --- configure.ac | 2 +- include/share/compat.h | 2 +- src/libFLAC/stream_decoder.c | 3 --- src/libFLAC/stream_encoder.c | 3 --- src/share/grabbag/file.c | 8 +------- 5 files

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01.04.2013 16:26, LRN wrote: > On 01.04.2013 14:40, Erik de Castro Lopo wrote: >> Hi all, > >> The latest pre-release is here: > >> http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz > >> > flac-1.3.0pre3/include/share/compat.h:146:31: fatal error: > share/win_utf8_io.h: No such file or

Dear FLAC devs, I would like to get some of our patches merged into master. Most of them deal with adhering to GNU conventions, respectively not overriding flags/variables that are up to the user to set. For instance, honoring $(htmldir) is important, as we have installation paths for the documentation that differ from what is currently coded in the various Makefile.am's. Regards David

HI all, I think its time for a new release. The current code base is stable and I've been building it for x86_64/linux, powerpc/linux, armhf/linux, x86_64/darwin in a Jenkins build bot. I'm pretty sure others have been building regularly on their platforms of interest. I made a first pass on an update to the changelog.html. I' also putting toether a release checklist that I will add

When building outside of the source tree, the Doxyfile needs to be generated in the build tree and should point to the proper paths for include directories and html footer. The generated api files to install should also be taken from the build tree instead of the source tree. --- configure.ac | 1 + doc/Doxyfile | 1220 --------------------------------------------------

When building outside of the source tree, the Doxyfile needs to be generated in the build tree and should point to the proper paths for include directories and html footer. The generated api files to install should also be taken from the build tree instead of the source tree. --- configure.ac | 1 + doc/Doxyfile | 1220 --------------------------------------------------

It seems the mail you are referring to never made the list: it's not in the archives and not in my mailbox. Take a look here: http://lists.xiph.org/pipermail/flac-dev/2012-December/thread.html It's probably still waiting for moderation. On 07-01-13 17:07, Olivier BLIN wrote: > On 29/12/2012 00:06, Olivier Blin wrote: >> When building outside of the source tree, the Doxyfile