similar to: [PATCH] Suppress MSVS warnings for lpc.c

With current settings, MSVS links debug version of flac.exe (and other .exe and .dll files) with the release version of libogg_static.lib. MSVS issues a "warning LNK4098: defaultlib 'libcmt.lib' conflicts with use of other libs; use /NODEFAULTLIB:library" What's the reason in this setting? What is better: * to change the settings so that MSVS will link debug .exe files with

Erik de Castro Lopo wrote: >> because MSVS2005 doesn't provide stdint.h. According to MSDN, >> uintptr_t is defined in "STDDEF.H and other include files". > > Does the rest of FLAC actually support those compilers? Yes. I removed this #include and all projects were successfully built with MSVS 2005 Express. > Is it worth > continuing to support them? * At

Ralph Giles wrote: >> With current settings, MSVS links debug version of flac.exe (and other >> .exe and .dll files) with the release version of libogg_static.lib. >> MSVS issues a "warning LNK4098: defaultlib 'libcmt.lib' conflicts with use >> of other libs; use /NODEFAULTLIB:library" > > Sounds like a bug. Debug targets should link to debug builds

By default, FLAC requires ogg library. Support of old versions of Visual Studio was removed from libogg code about 2 years ago: https://git.xiph.org/?p=ogg.git;a=commit;h=18c401c6bc8814d06f3ae53ebf5d4399f90871cc libogg 1.3.3 (released 2017-11-07) cannot be built with MSVS 2005/2008 anymore. Are there any developers that want to use libFLAC in their programs and still use Visual Studio 2005 or

src/libFLAC/memory.c cannot be compiled with MSVS 2005 (and probably VS2008 too) after this commit: http://git.xiph.org/?p=flac.git;a=commitdiff;h=7cbecbae9f70be770f7651d09531fec0de6f9cf5 because MSVS2005 doesn't provide stdint.h. According to MSDN, uintptr_t is defined in "STDDEF.H and other include files".

This patch allows MSVS to use M_LN2 const defined in math.h -------------- next part -------------- A non-text attachment was scrubbed... Name: mathln2.patch Type: application/octet-stream Size: 963 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130904/14cd34db/attachment.obj

lvqcl wrote: > Ralph Giles wrote: > > >> With current settings, MSVS links debug version of flac.exe (and other > >> .exe and .dll files) with the release version of libogg_static.lib. > >> MSVS issues a "warning LNK4098: defaultlib 'libcmt.lib' conflicts with use > >> of other libs; use /NODEFAULTLIB:library" > > > > Sounds

I don't like the decision to remove the old VS project files, in my opinion it's better to keep them, marked "not updated anymore". I personnally use VS2013, and the reason I don't want to upgrade is the fact that VS2017 requires online registration to work. I'm pretty sure some users also have valid reasons to keep their old VS. On 2 May 2018 at 14:37, lvqcl

On 2013-09-30 4:53 PM, Erik de Castro Lopo wrote: > I'd be keen to have the windows build automatically do the sanest possible thing, > preferably with anyone having to copy files. The way we've been doing the Opus stuff is to have the project files expect a build in a parallel checkout. so: c:\dev\flac\FLAC.sln expects to find an ogg build in c:\dev\ogg\win32\VS2010\ Not as

This patch adds flac_restrict to share/compat.h and adds it to arguments of ...lpc_compute_residual...()/...lpc_restore_signal...() functions. As a result, FLAC__lpc_compute_residual_from_qlp_coefficients_wide_intrin_sse41() now offers no advantage for 64-bit compiles and was removed from x86-64 part of stream_encoder.c -------------- next part -------------- A non-text attachment was scrubbed...

Tests show that FLAC__fixed_compute_residual/FLAC__fixed_restore_signal are slightly faster when flac_restrict modifier is added to their arguments. (Encoding speed increase for flac -8 is about 2%. The difference is not very big yet measurable). -------------- next part -------------- A non-text attachment was scrubbed... Name: fixed.patch Type: application/octet-stream Size: 2503 bytes Desc:

lvqcl wrote: > Why? We can use vsnprintf_s for MSVS, and vsnprintf for MinGW. > > MSVS version of vsnprintf_s is located inside (statically linked) msvcp???.lib > or (dynamically linked) msvcp???.dll. They are part of MSVS runtime, and compatible > with WinXP. So it is safe to use it in FLAC. Oh, ok. I missed this bit. I know so very little about Windows. However, if you compile

lvqcl wrote: > This patch allows MSVS to use M_LN2 const defined in math.h For this one, I'd prefer to see the _USE_MATH_DEFINES definition in the *.vcproj and FLAC.sln files. I'd be happy to have the removal of the two comments in the same commit. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

On 2.10.2013 20:27, lvqcl wrote: > Ralph Giles wrote: > >> The way we've been doing the Opus stuff is to have the project files >> expect a build in a parallel checkout. so: >> >> c:\dev\flac\FLAC.sln expects to find an ogg build in >> c:\dev\ogg\win32\VS2010\ >> >> Not as obvious as having a monolithic build, but it seems to work once >>

The latest stable version of libogg is 1.3.2 (released in May 2014). It has support for MS Visual Studio 6, 2003, 2005, 2008 and 2010. Support for VS 2013 was added in May 2015, and for VS 2015 was added in May 2016. But then support from anything except VS 2015 was removed: <http://git.xiph.org/?p=ogg.git;a=commitdiff;h=18c401c6bc8814d06f3ae53ebf5d4399f90871cc> Actually it should be

SimplifyLibCalls.cpp is no longer part of Transforms\IPO and Transforms\Scalar\SimplifyCFG.cpp is renamed to SimplifyCFG.cpp or something to that effect ( I didn't look up the actual checkins ). Having fixed that, I still can't get through the build: Creating library C:\work\s\llvm\win32\\bin\Win32\Debug/opt.lib and object C:\work\s\llvm\win32\\bin\Win32\Debug/opt.exp 1>opt.obj : error

MSVS profiler shows that the encoder spends too much time inside format_input() when the input is 24-bit. The attached patch increases encoding speed: FLAC -5: from 27.1 to 24.2 seconds FLAC -8: from 76.2 to 73.1 seconds (MSVS 2010, 32-bit flac.exe, 24-bit stereo input file) For GCC compiles the encoding speed remains the same. I suspect that GCC is smart enough to use strict aliasing rule to

Hugo Beauzée-Luyssen <hugo at beauzee.fr> wrote: > --- > src/share/win_utf8_io/win_utf8_io.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/src/share/win_utf8_io/win_utf8_io.c > b/src/share/win_utf8_io/win_utf8_io.c > index c61d27f3..1437b41e 100644 > --- a/src/share/win_utf8_io/win_utf8_io.c > +++ b/src/share/win_utf8_io/win_utf8_io.c >

On Fri, Oct 2, 2020 at 1:48 AM George Rimar <grimar at accesssoftek.com> wrote: > Thanks, David! > > > Few minor additions to the topic: > > > > I'm not sure which MSVC version on godbolt would be "MSVC 2017" that > the LLVM docs refer to > > > I've found that the minimal available version of MSVC on > godbolt is "WINE MSVC 2015:

On Thu, Oct 1, 2020 at 2:08 AM George Rimar <grimar at accesssoftek.com> wrote: > FWIW, I've performed an experiment with the code below at godbolt. > (used -O2, https://godbolt.org/z/nY95nh) > > ``` > #include <vector> > #include "llvm/Support/Error.h" > > llvm::Expected<std::vector<int>> foo() { > std::vector<int> V; >