similar to: PATCH for FLAC__VENDOR_STRING definition

Move FLAC__STRCASECMP to share/compat.h and remove it from src/flac/main.c and src/share/grabbag/cuesheet.c -------------- next part -------------- A non-text attachment was scrubbed... Name: strcasecmp.patch Type: application/octet-stream Size: 1596 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140310/f2bd3db3/attachment.obj

a) A previous patch for stream_encoder_intrin_xxxx.c removes definitions of abs_residual_partition_sum variables but leaves unnecessary empty line after it. The first attached patch removes them. b) The second attached patch fixes coding style for lpc_asm.nasm: mov{space}ebp, esp to mov{tab}ebp, esp etc. -------------- next part -------------- A non-text attachment was scrubbed...

Anybody knows the reason for the following code (you can see it in flac/decode.c, flac/encode.c, libFLAC/fixed.c and libFLAC/stream_decoder.c) ? #if defined _MSC_VER || defined __MINGW32__ /* with MSVC you have to spoon feed it the casting */ residual_bits_per_sample[0] = (FLAC__float)((total_error_0 > 0) ? log(M_LN2 * (FLAC__double)(FLAC__int64)total_error_0 /

libFLAC for Windows compiled with GCC/MinGW can't detect SSE OS support: it can't use GCC+Linux detection code and can't use MSVC+Win32 code that uses SEH (__try/__except). So it doesn't use any SSE/SSE2/etc routines. One way to fix it is to call configure script with --enable-sse (flac will probably crash on Win95/WinNT4 but who cares). Another way is to add a new code just for

lvqcl wrote: > Anybody knows the reason for the following code > (you can see it in flac/decode.c, flac/encode.c, libFLAC/fixed.c and > libFLAC/stream_decoder.c) ? <snip> > Is it MSVC6 specific? The following web pages seem to confirm this: > http://www.winehq.org/pipermail/wine-patches/2004-September/012502.html >

This patch removes MSVC "spoon feeding". -------------- next part -------------- A non-text attachment was scrubbed... Name: no_vc6_workaround.patch Type: application/octet-stream Size: 6728 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140703/38c5b062/attachment.obj

--- include/share/compat.h | 8 ++++++++ src/flac/main.c | 37 +------------------------------------ src/share/grabbag/seektable.c | 31 +------------------------------ 3 files changed, 10 insertions(+), 66 deletions(-) diff --git a/include/share/compat.h b/include/share/compat.h index e9ac958..ff5c8af 100644 --- a/include/share/compat.h +++ b/include/share/compat.h

A preprocessor macro FLAC__ALIGN_MALLOC_DATA is defined in Makefiles but absent in *.vcproj files. This patch adds it to libFLAC_static.vcproj and libFLAC_dynamic.vcproj. -------------- next part -------------- A non-text attachment was scrubbed... Name: align_malloc.patch Type: application/octet-stream Size: 2862 bytes Desc: not available Url :

Analogous to M_LN2 patch: the patch moves definition of M_PI from src/libFLAC/window.c and src/test_streams/main.c to include/share/compat.h -------------- next part -------------- A non-text attachment was scrubbed... Name: M_PI.patch Type: application/octet-stream Size: 1581 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130925/6a0afebe/attachment.obj

Changes the definition of FLAC__I64L macro (analogous to FLAC__U64L macro in compat.h) -------------- next part -------------- A non-text attachment was scrubbed... Name: flac_i64l.patch Type: application/octet-stream Size: 536 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140310/2f035143/attachment.obj

Changes invalid (and commented) #pragma warning ( enable : 4800 ) with correct #pragma warning ( default : 4800 ) Also adds #pragma warning ( disable : 4800 ) to src/test_libFLAC++/encoders.cpp (analogous to src/test_libFLAC++/decoders.cpp) -------------- next part -------------- A non-text attachment was scrubbed... Name: warning4800.patch Type: application/octet-stream Size: 1079

For MSVS, share/compat.h redefines strtoull as _strtoui64, and there's no need in local__strtoull(). -------------- next part -------------- A non-text attachment was scrubbed... Name: strtoull.patch Type: application/octet-stream Size: 936 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140310/b959b299/attachment.obj

On 5/24/14, lvqcl <lvqcl.mail at gmail.com> wrote: > Ozkan Sezer <sezeroz at gmail.com> ?????(?) ? ????? ?????? Sat, 24 May 2014 > 10:16:15 +0400: > >> - changes the _MSC_VER condition to universally _WIN32: MSVC, as well >> as GCC supports this. > > MSYS/MinGW 4.8.3, 4.9.0 can't compile code from git after this patch: > > format.c:47:22: error:

The attached set of patches adds support for OS/2 using Watcom compiler (tested with Open Watcom 1.9). My only interest was building a working dll (the last patch in the set adds a makefile for it), therefore I did not touch other places: If there is interest, I can do so. Regards. -- O.S. -------------- next part -------------- A non-text attachment was scrubbed... Name:

Erik de Castro Lopo wrote: > That's a really good question. Haven't was already dropped support for > MSVC6? If so, we should drop this #ifdef hackery. Can test this without > the hackery for versions of MSVC > 6? I don't have VC 2002/2003, but the oldest Visual Studio that FLAC supports is MSVS 2005 anyway. It can compile FLAC__uint64 -> FLAC__double conversion

The following patch changes export.h so that the dllimport/dllexport attributes work with mingw/mingw-w64 and others: - changes _declspec keyword to __declspec: the former may not be defined by some toolchains. - changes the _MSC_VER condition to universally _WIN32: MSVC, as well as GCC supports this. Attached patch: declspec.diff Regards. -- O.S. -------------- next part --------------

Ozkan Sezer wrote: > On 8/21/13, lvqcl <lvqcl.mail at gmail.com> wrote: > > 1) Some time ago all project files for MSVC 6 were removed; it makes sense > > to remove the code that is necessary only for MSVC 6 and older compilers. > > > > One may still compile using command line instead of a project file. Does > it really hurt keeping such code? Its crufty old

Hi everybody, We have FLAC supported for input/output in REAPER (http://www.reaper.fm), and the problem is that when writing 24 bit FLAC files, the data isn't compressed (i.e. the FLAC is slightly larger than if it was writing to .WAV). The files play back fine, however, and 16 bit mode works great. We're using flac-1.1.2, built on win32 with MSVC6 w/ SP5 + VCPP, and NASM version 0.98.39

Currently it's possible to corrupt FLAC file with flac and metaflac tools. If image filesize is just slightly less than 2^24 bytes then the size of PICTURE metadata block will be more that this limit. The first patch (fix1.patch) adds additional check in /share/grabbag/picture.c/read_file() and removes rather useless check from FLAC__metadata_object_picture_set_data(). It's enough to fix

Erik de Castro Lopo wrote: > INFO: Make sure you know what you're doing when using --ignore-chunk-sizes. > Improper use can cause flac to encode non-audio data as audio. > -: WARNING: skipping unknown chunk 'LIST' (use --keep-foreign-metadata to keep) > -: WARNING: 'data' chunk has non-zero size, using --ignore-chunk-sizes is probably a bad