similar to: PATCH: move M_PI definition to share/compat.h

test_streams currently depends on grabbag and (on Windows) on win_utf8_io libs. It depends on win_utf8_io only because it uses flac_fopen() function. It will become to depend on libFLAC when all file functions will be moved from win_utf8_io to libFLAC. Not a big problem, but it is possible to avoid this dependency by replacing flac_fopen() with fopen(). test_streams doesn't open/create

Brian Willoughby <brianw at audiobanshee.com> ?????(?) ? ????? ?????? Sun, 31 Jan 2016 22:26:40 +0300: > My assumption is that the code was written to call flac_fopen() so that it is portable to every operating system, even those without fopen(). If you replace flac_fopen() with fopen(), then the tests won't compile on systems that don't have fopen(). I REALLY doubt it. Even if

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Well first of all, none of them apply :-). I'll try to redo the necessary patches with git. > * Remove restrict definition from include/share/compat.h. Applied. BTW, I tried to use 'restrict' keyword with MSVS 2010 and 2012 and in fact they don't support it. Only --restrict is supported. > * libFLAC and

> > After some intense debugging, I found the problem. One block in > > the file > > triggered a very rare bug in the LPC coefficient quantizer caused > > by > > insufficient floating point precision. There is a snippet to > > compute the > > log(base 2) of a number: > > > > floor(log(cmax) / M_LN2) > > > > It turns out on at

> Also, Kai has been kind enough to send me a copy of his file which > has a > problem only on -8, which I'll be looking into soon. After some intense debugging, I found the problem. One block in the file triggered a very rare bug in the LPC coefficient quantizer caused by insufficient floating point precision. There is a snippet to compute the log(base 2) of a number:

Anybody knows the reason for the following code (you can see it in flac/decode.c, flac/encode.c, libFLAC/fixed.c and libFLAC/stream_decoder.c) ? #if defined _MSC_VER || defined __MINGW32__ /* with MSVC you have to spoon feed it the casting */ residual_bits_per_sample[0] = (FLAC__float)((total_error_0 > 0) ? log(M_LN2 * (FLAC__double)(FLAC__int64)total_error_0 /

test_streams doesn't create/open files with non-ascii filenames, so there's no need in unicode support. The patch changes flac_fopen() calls to fopen(), and removes dependency of test_streams from win_utf8_io. -------------- next part -------------- A non-text attachment was scrubbed... Name: test_streams.zip Type: application/zip Size: 2445 bytes Desc: not available Url :

- INCLUDES is deprecated, and CPPFLAGS is an user-defined variable, use the proper AM_CPPFLAGS instead - Remove FLAC__INLINE definition, providing proper replacement for MSVC compilers. - Detect if we have C99 's lround and provide a replacement for windows... --- configure.ac | 32 ++++++++-------------------- examples/c/decode/file/Makefile.am

That enables an special implementation that checks for common memory errors and will save us from a lot pain. --- test/test_bins.sh | 2 ++ test/test_flac.sh | 2 ++ test/test_grabbag.sh | 2 ++ test/test_libFLAC++.sh | 2 ++ test/test_libFLAC.sh | 3 +++ test/test_metaflac.sh | 2 ++ test/test_seeking.sh | 2 ++ test/test_streams.sh | 2 ++ 8 files

This patch allows MSVS to use M_LN2 const defined in math.h -------------- next part -------------- A non-text attachment was scrubbed... Name: mathln2.patch Type: application/octet-stream Size: 963 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130904/14cd34db/attachment.obj

#bug 1: besselI() for nu<0 and expon.scaled=TRUE #tested with R-devel (2007-06-17 r41981) x <- 2.3 nu <- -0.4 print(paste(besselI(x, nu, TRUE), "=", exp(-x)*besselI(x, nu, FALSE))) #fix: #$ diff bessel_i_old.c bessel_i_new.c #57c57 #< bessel_k(x, -alpha, expo) * ((ize == 1)? 2. : 2.*exp(-x))/M_PI #--- #> bessel_k(x, -alpha, expo) * ((ize == 1)? 2. :

src/test_streams/main.c fails under MSVC because it doesn't provide snprintf(). The patch replaces snprintf() with flac_snprintf(). -------------- next part -------------- A non-text attachment was scrubbed... Name: test_streams.patch Type: application/octet-stream Size: 486 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20150223/b0908a26/attachment.obj

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Patch applied, tested, commited and pushed. Great. But, what about my other patches? I admit that many of them aren't necessary, but (imho) a couple of them are important. I can explain in detail why I think this.

math.h file in MS VC++ _does_ have M_LN2 constant but it requires _USE_MATH_DEFINES: --- a\src\libFLAC\fixed.c 2013-08-13 13:30:24.000000000 +0400 +++ b\src\libFLAC\fixed.c 2013-08-14 10:14:07.873648300 +0400 @@ -34,6 +34,9 @@ # include <config.h> #endif +#if defined(_MSC_VER) +#define _USE_MATH_DEFINES +#endif #include <math.h> #include <string.h> #include

Dear all, Compiling R-0.64.0 on DEC osf4.0 has the following error message (earlier version was OK). cc -ieee_with_inexact -g -I../include -I../../src/include -c pnf.c -o pnf.o cc -ieee_with_inexact -g -I../include -I../../src/include -c pnt.c -o pnt.o cc: Error: pnt.c, line 83: In this statement, "1021" is not an lvalue, but occurs in a context that requires one. if (df >

Full_Name: Tim Middelkoop Version: 0.64.0 OS: IRIX 6.3 on O2 Submission from: (NULL) (128.119.88.192) Various IRIX complile issues src/nmath/pnt.c IRIX cc does not like double negatives Makeconf,config.site,etc/Makeconf f77 pic hack, should change Makeconf.in or other... change -PIC with -KPIC enjoy, tim... === diff -ru orig/R-0.64.0/src/nmath/pnt.c R-0.64.0/src/nmath/pnt.c ---

On 10/18/2002 7:29 PM, Josh Coalson wrote: > --- Wagner One <wagner@wagnerone.com> wrote: >> On 10/18/2002 12:50 PM, Josh Coalson wrote: >> >>>> i configured and built 1.0.4 in osx 10.2. seemed to build fine, but each >>>> time i attemped to use the newly compiled flac binary I received this error >>>> >>>> "bus

Thanks, Erik. This is the delta that should fix everything up. I hope that #include "share/compat.h" is acceptable from the test_streams binary. If not, you can probably change it to FLAC/ordinals.h instead Also don't forget to commit my earlier VERSION="1.3.0" patch. You can add the "pre1" in a normal text editor without risk. I didn't include those

--- src/test_grabbag/cuesheet/Makefile.am | 2 +- src/test_grabbag/picture/Makefile.am | 2 +- src/test_libFLAC++/Makefile.am | 2 +- src/test_libFLAC/Makefile.am | 2 +- src/test_seeking/Makefile.am | 2 +- src/test_streams/Makefile.am | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/test_grabbag/cuesheet/Makefile.am

--- configure.ac | 7 +++++ src/libFLAC/bitreader.c | 12 ++------- src/libFLAC/bitwriter.c | 8 ++---- src/libFLAC/fixed.c | 18 +++++-------- src/libFLAC/format.c | 8 ++---- src/libFLAC/include/private/macros.h | 29 ++++++++++++++++++++ src/libFLAC/metadata_iterators.c | 17 +++---------