similar to: Metaflac UTF-8 fixes

Hi all, I added -Wmissing-prototypes -Wstrict-prototypes to the CFLAGS and found that there were a number warnings generated. The patch below fixes those warnings and adds the two -W flags to configure.in. Cheers, Erik ----------------------8<----------------------8<---------------------- --- src/metaflac/operations_shorthand.h 1970-01-01 00:00:00 +0000 +++

Brian Willoughby wrote: > Jan Stary wrote: >>> This is 1.3.1 on OpenBSD/amd64. >>> The --no-utf8-convert option of metaflac(1) does not work for me: ... >> The problem seems to be in >> src/metaflac/operations_shorthand_vorbiscomment.c >> in the set_vc_field() function. > By the way, I've never used FLAC inside Ogg Vorbis. > Instead, I use pure

On Dec 05 20:16:47, hans at stare.cz wrote: > This is 1.3.1 on OpenBSD/amd64. > The --no-utf8-convert option of metaflac(1) does not work for me: > > $ metaflac --no-utf8-convert --set-tag="Artist=?ou?l??ek" aladin.flac > aladin.flac: ERROR: tag value for 'Artist' is not valid UTF-8 > (You probably can't see the Czech letters properly in my mail, > but

Here's a patch that stops the flac binary from writing empty tag fields. At least in Windows world these come to files by accident. CD extraction programs pass all possible metadata entries they allow setting in the UI to flac binary and most of the time most fields are empty when basic info like artist, album, title, track number and release date are the only fields that are set.

On 24.4.2013 15:42, Erik de Castro Lopo wrote: > Janne Hyv?rinen wrote: > >> +#define PPR if(filename) if(raw) printf("%s:",filename); else flac_printf("%s:",filename); > Are you sure about that line? > > GCC complains about an ambiguous 'else'. It definitely needs some > curly braces somewhere there to make the intend explicit. > So it

Small change to metaflac hexdump function. Changed so utf-8 decoding is only used for filename printing and changed hex output printing to not rely only on isprint. That function seems to return true for tabulator control character under Windows when application isn't using C-locale. At least it did so for all locales I tried (Finnish, German, English US). -------------- next part

This is 1.3.1 on OpenBSD/amd64. The --no-utf8-convert option of metaflac(1) does not work for me: $ metaflac --no-utf8-convert --set-tag="Artist=?ou?l??ek" aladin.flac aladin.flac: ERROR: tag value for 'Artist' is not valid UTF-8 (You probably can't see the Czech letters properly in my mail, but that's beside the point.) Indeed, it is not valid UTF8 (it's LATIN2),

Erik de Castro Lopo wrote: >> Oops. It seems that vsnprintf_s isn't always available on MinGW platform: >> MinGW declares this function only if MINGW_HAS_SECURE_API macro is defined. >> That's because WinXP version of msvcrt.dll doesn't contain secure functions >> like vsnprintf_s. >> >> Maybe it's better to revert vsnprintf_s to vsprintf or to

That's how I understand how flac.exe works with unicode under Windows: There's a flag win_utf8_io_codepage that is equal either to CP_ACP or to CP_UTF8. Initially it's equal to CP_ACP. Then flac.exe/metaflac.exe call get_utf8_argv() that do some things and sets win_utf8_io_codepage to CP_UTF8 on success. This is the only way to set this flag to CP_UTF8. The programs continue to work

Hi! I have trouble compiling the flac library using Microsofts free (yes MS gives it away including the optimizing C++ compiler msvc8.0) Visual Studio Express 2005. I get the output shown below. Does anyone have a way to make flac compile in VS 2005? Thanks! Ulrik 1>------ Rebuild All started: Project: replaygain_analysis_static, Configuration: Debug Win32 ------ 1>Deleting

--- COPYING.GPL | 43 +++++++++++----------- doc/Makefile.am | 6 +-- doc/Makefile.lite | 6 +-- examples/c/decode/file/Makefile.am | 6 +-- examples/c/decode/file/Makefile.lite | 6 +-- examples/c/decode/file/main.c | 6 +--