similar to: [PATCH] Ensure AM_LDFLAGS is used consistently

libFLAC* must never have undefined symbols no matter what is the target platform. --- configure.ac | 10 +--------- src/libFLAC++/Makefile.am | 2 +- src/libFLAC/Makefile.am | 2 +- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 50ef80e..ba46caf 100644 --- a/configure.ac +++ b/configure.ac @@ -129,19 +129,11 @@

--- include/FLAC++/export.h | 4 ++-- include/FLAC/export.h | 4 ++-- src/libFLAC++/Makefile.am | 2 +- src/libFLAC/Makefile.am | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/FLAC++/export.h b/include/FLAC++/export.h index d3bd136..1cb0214 100644 --- a/include/FLAC++/export.h +++ b/include/FLAC++/export.h @@ -76,9 +76,9 @@ /* These #defines will mirror the

With gcc >= 4 and ELF, set default visibility to hidden and make visible only the symbols with FLAC_API or FLACPP_API. A convenience libFLAC-static.la is created for test_libFLAC as it depends on the hidden symbols. --- configure.ac | 8 +++++++- include/FLAC++/export.h | 13 +++++++++---- include/FLAC/export.h | 13 +++++++++---- src/libFLAC/Makefile.am | 10

They are not needed since the section is defined in nasm.h. --- src/libFLAC/ia32/bitreader_asm.nasm | 4 ---- src/libFLAC/ia32/cpu_asm.nasm | 4 ---- src/libFLAC/ia32/fixed_asm.nasm | 4 ---- src/libFLAC/ia32/lpc_asm.nasm | 4 ---- src/libFLAC/ia32/stream_encoder_asm.nasm | 4 ---- 5 files changed, 20 deletions(-) diff --git

- INCLUDES is deprecated, and CPPFLAGS is an user-defined variable, use the proper AM_CPPFLAGS instead - Remove FLAC__INLINE definition, providing proper replacement for MSVC compilers. - Detect if we have C99 's lround and provide a replacement for windows... --- configure.ac | 32 ++++++++-------------------- examples/c/decode/file/Makefile.am

JonY wrote: > On 2/5/2012 13:30, Erik de Castro Lopo wrote: > > Dave Yeo wrote: > > > >> --- > >> configure.ac | 1 + > > > > Both applied (first with a minor tweak). Thanks. > > > > Erik > > Unfortunately, this steps on my patch. Updated patch attached. Cygwin > really shouldn't be calling win32 API. > > On the

ok, great, thanks. checked in. Josh --- Luca Barbato <lu_zero@gentoo.org> wrote: > I spent a bit of time trying to make the configure behave. > > that's the result, I didn't check if the asm output runs correctly > (looks forcefully disabled) but at least builds as should. > > lu > > -- > > Luca Barbato > > Gentoo/linux Developer

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Tried to do this, gcc complained a lot about undefined references. After a bit of mucking with the code, i came up with a few patches. This might be a good conversation starter. The build that i've got out of this does pass the testsuite. To enable LTO you just need to apply these (for non-W32 builds you probably only need one of the patches)

/usr/bin/ld: bad -rpath option collect2: ld returned 1 exit status make[4]: *** [libFLAC.la] Error 1 --- flac-1.1.2/src/libFLAC/Makefile.in.orig 2005-02-04 21:23:37.000000000 -0500 +++ flac-1.1.2/src/libFLAC/Makefile.in 2006-04-30 20:30:00.000000000 -0400 @@ -399,7 +399,7 @@ rm -f "$${dir}/so_locations"; \ done libFLAC.la: $(libFLAC_la_OBJECTS)

On 5/24/14, lvqcl <lvqcl.mail at gmail.com> wrote: > Ozkan Sezer <sezeroz at gmail.com> ?????(?) ? ????? ?????? Sat, 24 May 2014 > 10:16:15 +0400: > >> - changes the _MSC_VER condition to universally _WIN32: MSVC, as well >> as GCC supports this. > > MSYS/MinGW 4.8.3, 4.9.0 can't compile code from git after this patch: > > format.c:47:22: error:

Hi, > automake1.4 fails with error: > > vq/Makefile.am:9: invalid unused variable name: `AM_LDFLAGS' > > automake1.6 succeeds > > automake1.8 succeeds (with a bunch of "underquoted" warnings for > referenced macros) (the underquoted warnings are due to installed .m4 files being underquoted, and harmless) > it seems the AM_LDFLAGS magic was introduced

Most of the programs don't use libogg or libm directly and should not link to them (overlinking). --- examples/c/decode/file/Makefile.am | 4 +--- src/flac/Makefile.am | 1 - src/metaflac/Makefile.am | 4 +--- src/plugin_xmms/Makefile.am | 1 - src/test_grabbag/cuesheet/Makefile.am | 4 +--- src/test_grabbag/picture/Makefile.am | 4

--- configure.ac | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 36ac6c6..32bdd5f 100644 --- a/configure.ac +++ b/configure.ac @@ -103,9 +103,11 @@ esac AC_SUBST(OBJ_FORMAT) case "$host" in - *-*-cygwin|*mingw*) - # define this variable for enabling strict exports with libtool; for now, it's only supported by Win32

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01.04.2013 16:26, LRN wrote: > On 01.04.2013 14:40, Erik de Castro Lopo wrote: >> Hi all, > >> The latest pre-release is here: > >> http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz > >> > flac-1.3.0pre3/include/share/compat.h:146:31: fatal error: > share/win_utf8_io.h: No such file or

Hi, To simplify a static compile you could change the -l order to add ogg after vorbis, else a static compile won't work. You could also add a LIBTOOLFLAGS that is at the right place in the linking stage with a comment like "add '-all-static' here to do a static compile.(usefull for chroot installs) Right place is: LINK = $(LIBTOOL) --mode=link $(CCLD) -all-static

I did a check-out of vorbis trunk (revision 7445), but I'm getting problems with the autogen.sh. It complains that the required files vorbis{,enc,file}-uninstalled.pc.in are not present. $ ./autogen.sh checking for autoconf... checking for automake... checking for libtool... libtoolize I am going to run ./configure with no arguments - if you wish to pass any to it, please specify them on the

Not sure if this is the right place to post this... I have attached a patch for the build system which lets FLAC build on IRIX and Cygwin. -------------- next part -------------- ? Makefile ? aclocal.m4 ? autom4te.cache ? config.guess ? config.log ? config.status ? config.sub ? configure ? depcomp ? install-sh ? irix.patch ? libtool ? libtool-disable-static ? ltmain.sh ? missing ? mkinstalldirs ?

Dave Yeo wrote: > --- > configure.ac | 1 + Both applied (first with a minor tweak). Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

I spent a bit of time trying to make the configure behave. that's the result, I didn't check if the asm output runs correctly (looks forcefully disabled) but at least builds as should. lu -- Luca Barbato Gentoo/linux Developer Gentoo/PPC Operational Manager http://dev.gentoo.org/~lu_zero -------------- next part -------------- A non-text attachment was scrubbed... Name:

On 24 February 2015 at 09:01, Maarten Lankhorst <maarten.lankhorst at ubuntu.com> wrote: > While I've closed off most races in a previous patch, a small race still existed > where importing then unreffing cound cause an invalid bo. Add a test for this case. > > Racing sequence fixed: > > - thread 1 releases bo, refcount drops to zero, blocks on acquiring nvdev->lock.