similar to: Updated MSVC patch

Thanks, Erik. This is the delta that should fix everything up. I hope that #include "share/compat.h" is acceptable from the test_streams binary. If not, you can probably change it to FLAC/ordinals.h instead Also don't forget to commit my earlier VERSION="1.3.0" patch. You can add the "pre1" in a normal text editor without risk. I didn't include those

Those checks account for compiler changes/improvements introduced in Visual Studio 2010 that are not present in Visual Studio 2008. I will grab Visual Studio 2012 off of MSDN and make sure everything is OK there. -Ben > Hi Ben, > > Can you please remove the _MSC_VER >= 1600 check? > > _MSC_VER 1600 is set for Visual Studio 2010, which means > that Visual Studio 2012 will

This should be enough to fix it > Great. > > I need to correct my statement, the check for _MSC_VER <= 1600 > was the culprit, like this case: > > #if defined _MSC_VER || defined __BORLANDC__ || defined __MINGW32__ > #include <sys/types.h> /* for off_t */ > #if _MSC_VER <= 1600 || defined __BORLANDC__ /* @@@ [2G limit] */ > #ifndef fseeko > #define fseeko

Great. I need to correct my statement, the check for _MSC_VER <= 1600 was the culprit, like this case: #if defined _MSC_VER || defined __BORLANDC__ || defined __MINGW32__ #include <sys/types.h> /* for off_t */ #if _MSC_VER <= 1600 || defined __BORLANDC__ /* @@@ [2G limit] */ #ifndef fseeko #define fseeko fseek #ifndef fseeko #define fseeko fseek #endif #endif Cheers, Cristian. On

Hi Ben, Can you please remove the _MSC_VER >= 1600 check? _MSC_VER 1600 is set for Visual Studio 2010, which means that Visual Studio 2012 will get a lot of errors because _MSC_VER is defined as 1700. Cheers, Cristian. On Wed, Mar 6, 2013 at 5:53 PM, Ben Allison <benski at winamp.com> wrote: > Thanks, Erik. > > This is the delta that should fix everything up. > I hope

> Are the changes for FLAC/ordinals.h really necessary? Yhe FLAC/*.h > header files specify libFLAC's public API. In a previous thread on > this mailing list back in February we decided that for compilers > that didn't supply <stdint.h> the developer should supply something > suitable. Here's the commit: Yes, they are necessary. Here is the rationale 1)

Ben Allison wrote: > Erik, et al. > > This fixes the entire library and does it more cleanly. It puts most of > the guts into share/compat.h Thanks Ben. I applied a slightly tweaked version of the patch. The patch had to be tweaked because it broke the Linux build :-). Specifically, the file include/FLAC/ordinals.h is a public header file and should not include the project

Ben Allison wrote: > This is the delta that should fix everything up. > I hope that #include "share/compat.h" is acceptable from the test_streams > binary. Yes, the share/* header files are shared between the library internals, the test suite programs and flac and metaflac binary executables. > If not, you can probably change it to FLAC/ordinals.h instead Are the changes

Hi Erik, I've found a middleground for the problem of setting default CFLAGS. I've gone back to setting them if {C,CXX,CPP,LD}FLAGS are unset at the onset of the configure script (i.e., the user hasn't specified anything) and then proceed to set them to the defaults as before. This has been suggested before: https://lists.gnu.org/archive/html/autoconf/2006-04/msg00022.html In

src/test_streams/main.c fails under MSVC because it doesn't provide snprintf(). The patch replaces snprintf() with flac_snprintf(). -------------- next part -------------- A non-text attachment was scrubbed... Name: test_streams.patch Type: application/octet-stream Size: 486 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20150223/b0908a26/attachment.obj

Hi all, I've been notified of a CVE to be publish against FLAC early next week. I have a patch for it and have thoroughly tested it as well as had it verified by the Google Security Team member who found it. I've been asked not to publish that patch until Tuesday. Once I publis the patch, I like to release FLAC 1.3.1 immediately and would therefore like to make sure that all the

test_streams currently depends on grabbag and (on Windows) on win_utf8_io libs. It depends on win_utf8_io only because it uses flac_fopen() function. It will become to depend on libFLAC when all file functions will be moved from win_utf8_io to libFLAC. Not a big problem, but it is possible to avoid this dependency by replacing flac_fopen() with fopen(). test_streams doesn't open/create

These versions of Visual Studio don't have stdint.h and all [u]intNN_t types. But now these types are everywhere in FLAC codebase. An easy fix would be to move definitions of these types from share/compat.h into FLAC/ordinals.h (see attached patch). But it may break some 3rd party programs that include (directly or indirectly) this file and also have their own typedefs for these types.

Brian Willoughby <brianw at audiobanshee.com> ?????(?) ? ????? ?????? Sun, 31 Jan 2016 22:26:40 +0300: > My assumption is that the code was written to call flac_fopen() so that it is portable to every operating system, even those without fopen(). If you replace flac_fopen() with fopen(), then the tests won't compile on systems that don't have fopen(). I REALLY doubt it. Even if

One more set of MSVC project updates. Changed ogg_static.lib to libogg_static.lib as that's the name latest version uses. Removed MSVC 6.0 related parts from README and tweaked info there to be more up-to-date. Also changed nasmw.exe into nasm.exe as nasmw.exe has been long gone. LibFLAC_dynamic was complaining in debug mode about conflicts with libcmt, I excluded it from the project

Hi list, I am trying to compile and install flac 1.2. I $ ./configure(d) and $ make(d) without any errors or warnings. However I get the following error when $ make check(ing): > Testing 24-bit full-scale deflection streams... > fsd24-01 (--channels=1 --bps=24 -0 -l 16 --lax -m -e -p): encode...ERROR > during encode of fsd24-01 > FAIL: ./test_streams.sh > ===================

First off, this code is horrible to read and work on. The recent commits are the first of what I hope is a massive clean up of this code. lvqcl wrote: > So if I understand things correctly, the current meaning of --(en|dis)able-sse is: > > on Linux: > --enable-sse: > add -msse2 to the compiler switches > do not test SSE OS support (assume that SSE is

I rethought it and it seemed like a bad idea to post a big file, so you can get it here: http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/flac/junk/flac-1.0-src-candidate.tar.bz2 Josh __________________________________________________ Do You Yahoo!? Get personalized email addresses from Yahoo! Mail http://personal.mail.yahoo.com/

test_streams doesn't create/open files with non-ascii filenames, so there's no need in unicode support. The patch changes flac_fopen() calls to fopen(), and removes dependency of test_streams from win_utf8_io. -------------- next part -------------- A non-text attachment was scrubbed... Name: test_streams.zip Type: application/zip Size: 2445 bytes Desc: not available Url :

Hi all, As people may have seen there's a pre-release here: http://downloads.xiph.org/releases/flac/beta/ Specifically: flac-1.3.1pre1.tar.xz : The source code flac-1.3.1pre1-win.zip : Windows 32 and 64 bit binaries Please test. I'm particularly interested in hearing about the windows binaries which were cross compiled from Linux to Windows. Unfortunately there is a bug