similar to: Regain play analysis patches

Earl Chew wrote: > That being said, I think my patch leaves us better off than before ! I agree. We will add it as it is and then tweak futher as needed. Earl, would you be able to update your patch so that it applies against the current git master? Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

Earl Chew wrote: > I'm a little reluctant to introduce another compiled program when there are > so many other options that will work well enough out of the box. > > Here are two ideas: > > 1. Use bc(1) to compute the raw samples > 2. Use perl(1) to compute the raw samples > > To generate raw unsigned samples using bc(1) for example: > > samplerate = 1000;

Earl Chew wrote: > One per filter table entry. That's 12 files right now. Thats probably a bit much. > The files could be generated on the fly, but that would either require > another program or script (eg Perl), Anything but Perl. I can write Perl but I can't read it :-). > or a dependence on an external toolkit such as sox. I'd be ok with requiring sox to run the

Earl Chew wrote: > Erik, > > Ok. I've updated the patches, and made some additions to the test harness. > > For the test harness, I used sox to generate 1kHz wav files over a range of > sampling rates. The test harness runs the replaygain analysis, and compares > the resulting metadata. > > Are you ok with this approach ?? It means that the wav files need to be

Hello Earl, I used your patches while they cleanly applied to the Git tree. There is one question though, what do you think of?. http://www.hydrogenaudio.org/forums/index.php?showtopic=84086&st=0&p=782407&#entry782407 which apparently states (if I understand correctly) that your approach is not completely correct. Kind regards, Michael -------------- next part -------------- An

Brian Willoughby wrote: > What about using the C library sin() and cos() functions to generate > the test audio instead of sox? I did not see a description of how > the test files are generated, so maybe this is easy or maybe it is > hard. The benefit of shipping the test audio generation source code > around with the FLAC sources is that the tests won't break when

Erik, Ok. I've updated the patches, and made some additions to the test harness. For the test harness, I used sox to generate 1kHz wav files over a range of sampling rates. The test harness runs the replaygain analysis, and compares the resulting metadata. Are you ok with this approach ?? It means that the wav files need to be checked into the repository. (There are already some small image

Erik, It turns out bc(1) is too accurate, and a little slow, for this purpose. I've switched to using awk(1) which uses floating point. Do you feel I need to test for the presence of awk(1) ? It is specified as one of the standard commands in the LSB : http://refspecs.linuxfoundation.org/LSB_1.0.0/gLSB/command.html Earl ??? awk -- ' ??? BEGIN { ??????????? samplerate = 8000;

I'm having the same problem with an Acer Aspire One D150. I've tested 4.07, 5.00, 5.10 and 6.01. The keyboard is only working in 4.07.

Erik, One per filter table entry. That's 12 files right now. The files could be generated on the fly, but that would either require another program or script (eg Perl), or a dependence on an external toolkit such as sox. The tests increase the runtime of test_metaflac.sh from 11s to 15s on my machine. What are your thoughts ? Earl ----- Original Message ----- From: Erik de Castro Lopo

What about using the C library sin() and cos() functions to generate the test audio instead of sox? I did not see a description of how the test files are generated, so maybe this is easy or maybe it is hard. The benefit of shipping the test audio generation source code around with the FLAC sources is that the tests won't break when sox is modified. Brian Willoughby Sound

Mike, I'm not an expert at DSP work, and I'd gladly defer to any one with any reasonable amount of DSP experience. I followed the link, but I'm not sure how to interpret the graph exactly. I believe it's showing filter behaviour. The two curves look similar, but are clearly not the same. At the 1kHz mark, the blue shows -23, and the green shows perhaps 17.? Are they supposed to

I'm a little reluctant to introduce another compiled program when there are so many other options that will work well enough out of the box. Here are two ideas: 1. Use bc(1) to compute the raw samples 2. Use perl(1) to compute the raw samples To generate raw unsigned samples using bc(1) for example: samplerate = 1000; duration = 2; bitspersample = 24; samplerange = 2 ^ (bitspersample-1) -

The test is rather simple, and only compares the computed output values for a 1kHz signal at the known filter table sampling frequencies with previously obained golden values. As such, the test only verifies that the performance of the replay gain analyser has not changed. A better test would be to compare the computed value with an independently obtain theorectical value. This is possible by

Erik, I'll resync and have another look. Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Wednesday, February 1, 2012 10:30:21 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Earl Chew wrote: > When reading the INDEX

I've recently got a new flash drive (Kingston DT Micro 3.1 64GB) and found my existing SYSLINUX 6.02 fails to load on it, it just shows the version info and hangs forever. I've tried 6.03 as well as the latest git revision (currently 5483860), they both give me "Failed to load ldlinux.c32" The same builds and config work on my Kingston DT 101 G3 32GB. Both are formatted as NTFS

When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows metaflac_test.sh to pass. -------------- next part -------------- An HTML attachment was scrubbed... URL:

Erik, I'm using bash.? Before I alter the syntax, what shell are you using ? Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Sunday, March 11, 2012 3:16:11 AM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain Earl Chew wrote: > There is

Josh, I see my name is mentioned in passing ;-) I submitted that patch because I thought it preferable to keep the test harness running. Backing this change out would also entail changing metaflac_test.sh accordingly, which at the time, I was hesitant to do. At the time I figured that at some point metaflac_test.sh was passing, so the code should probably allow it to pass. I'm ok either

Josh, Sure. I can try. Would you give me a more detailed description of the requirement ? What exactly does "general MM:SS handling" mean ? Earl ________________________________ From: Josh Coalson <xflac at yahoo.com> To: Earl Chew <earl_chew at yahoo.com>; "flac-dev at xiph.org" <flac-dev at xiph.org> Sent: Tuesday, May 1, 2012 8:25:34 PM Subject: Re: