similar to: flac-dev Digest, Vol 87, Issue 10

JonY wrote: > Looks like there are some missed defines in the test_libFLAC++. Attached > patch fixes that. Good one. Thanks. > Also, wsock32 usage is deprecated, on Win7, wsock32 forwards everything > to ws2_32, suggest changing to -lwsock32 to -lws2_32 in configure.ac. > Additionally, using -lwsock32 on Cygwin is wrong. Fix in config.txt. For that I think I'd prefer to

On 2/4/2012 13:20, Erik de Castro Lopo wrote: > Hi all, especially David Yeo and JonY, > > I've started moving compiler specific CPP hacker into a separate file > at include/share/compat.h. > > Eventually I hope to be able to move all of the require CPP hackery > for $random_compiler into this file and have any C file which needs > any compiler specific tweak to

Hi all, especially David Yeo and JonY, I've started moving compiler specific CPP hacker into a separate file at include/share/compat.h. Eventually I hope to be able to move all of the require CPP hackery for $random_compiler into this file and have any C file which needs any compiler specific tweak to include this new compatibilty header. My belief is that one this CPP hackery is all in one

"Aren't Windows users accustomed to this feature being missing anyway?" I use Mac mostly now, but when I used Windows, now and then I always expected the wildcard to work, it just worked on most things so it was actually a bit of a pain in the ass when it didn't. On Mon, Mar 18, 2013 at 5:35 AM, <flac-dev-request at xiph.org> wrote: > Send flac-dev mailing list

JonY wrote: > What is your link test checking and how does it fail? My m4 macro is really simple, TRY_LINK a simple program with the stack protect CFLAGS: AC_DEFUN([XIPH_GCC_STACK_PROTECTOR], [AC_LANG_ASSERT(C) AC_MSG_CHECKING([if $CC supports stack smash protection]) xiph_stack_check_old_cflags="$CFLAGS" SSP_FLAGS="-fstack-protector --param ssp-buffer-size=4"

JonY wrote: > On 2/5/2012 13:30, Erik de Castro Lopo wrote: > > Dave Yeo wrote: > > > >> --- > >> configure.ac | 1 + > > > > Both applied (first with a minor tweak). Thanks. > > > > Erik > > Unfortunately, this steps on my patch. Updated patch attached. Cygwin > really shouldn't be calling win32 API. > > On the

JonY wrote: > On 3/17/2013 10:33, Janne Hyv?rinen wrote: > > Here's a patch that makes MSVC compiled flac.exe able to use wildcards > > and encode/decode files with Unicode characters in names. It may not be > > the prettiest code but it fulfills its primary purpose. > > I tried to alter FLAC code as little as possible. It replaces argv with > > utf-8 encoded

Erik de Castro Lopo wrote: > JonY wrote: > > > Please do a link time test instead, I am not getting this error and > > would like to keep stack protector on. > > I'll write an m4 macro. I have attampted to write a macro that reliably detects the availability of stack smash protection. I currently have two configurations where my detection says that SSP is available

JonY wrote: > Attached patch builds without any warnings for MinGW. Sorry JonY, that patch does not apply against current git master which is here: https://git.xiph.org/?p=flac.git;a=summary Specifically I pulled out much of the "#ifdef _MSC_VER" printf stuff in this commit: https://git.xiph.org/?p=flac.git;a=commit;h=ce8a75134cace056f6c436d54b57bad1a1d93797 For example

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 17.03.2013 18:55, JonY wrote: > On 3/17/2013 18:37, Erik de Castro Lopo wrote: >> JonY wrote: >> >>> On 3/17/2013 10:33, Janne Hyv?rinen wrote: >>>> Here's a patch that makes MSVC compiled flac.exe able to use >>>> wildcards and encode/decode files with Unicode characters in >>>>

On 2/3/2012 06:33, JonY wrote: > On 2/3/2012 02:50, Erik de Castro Lopo wrote: >> JonY wrote: >> >>> Attached patch builds without any warnings for MinGW. >> >> Sorry JonY, that patch does not apply against current git master >> which is here: >> >> https://git.xiph.org/?p=flac.git;a=summary >> >> Specifically I pulled out much

JonY wrote: > On 11/14/2011 18:01, JonY wrote: > > On 11/10/2011 19:22, JonY wrote: > >> On 11/10/2011 18:39, Erik de Castro Lopo wrote: > >>> > >>> I'm subscribed to the list (and I set my reply-to to the list). > >>> Please do not CC me. > >>> > >>> JonY wrote: > >>> > >>>> Its probably

JonY wrote: > On 3/17/2013 23:01, LRN wrote: > >> All those ifdefs will at least be confined rather than spread out > >> through the code. > > I did it plibc-style: > > > > in compat.h: > > #if defined(_WIN32) > > #define FOPEN grabbag__fopen_utf8_wrapper > > #else > > #define FOPEN fopen > > #endif > > > > in

--- configure.ac | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 36ac6c6..32bdd5f 100644 --- a/configure.ac +++ b/configure.ac @@ -103,9 +103,11 @@ esac AC_SUBST(OBJ_FORMAT) case "$host" in - *-*-cygwin|*mingw*) - # define this variable for enabling strict exports with libtool; for now, it's only supported by Win32

On 3/17/2013 18:37, Erik de Castro Lopo wrote: > JonY wrote: > >> On 3/17/2013 10:33, Janne Hyv?rinen wrote: >>> Here's a patch that makes MSVC compiled flac.exe able to use wildcards >>> and encode/decode files with Unicode characters in names. It may not be >>> the prettiest code but it fulfills its primary purpose. >>> I tried to alter FLAC

JonY wrote: > Alright, here's a quick fix, although it is more ugly than I remembered. > > Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h > where available, and falls back to I64 on MSVC and then ll for others, > all format warnings suppressed. JonY, Sorry for the delay on actually getting on to this. I tried your patch, but it wasn't quite right.

fedora comes with 1.75 so I used that. I also used some additional flags: cppcheck --enable=all --inconclusive --std=posix --force On Wed, Jan 18, 2017 at 11:36 PM, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Rosen Penev wrote: > >> src/libFLAC/bitreader.c | 4 ++-- >> src/libFLAC/bitwriter.c | 4 ++-- >> src/plugin_xmms/plugin.c |

Ben Allison wrote: > This is the delta that should fix everything up. > I hope that #include "share/compat.h" is acceptable from the test_streams > binary. Yes, the share/* header files are shared between the library internals, the test suite programs and flac and metaflac binary executables. > If not, you can probably change it to FLAC/ordinals.h instead Are the changes

lvqcl wrote: > Anybody knows the reason for the following code > (you can see it in flac/decode.c, flac/encode.c, libFLAC/fixed.c and > libFLAC/stream_decoder.c) ? <snip> > Is it MSVC6 specific? The following web pages seem to confirm this: > http://www.winehq.org/pipermail/wine-patches/2004-September/012502.html >

Dave Yeo wrote: > Another try Actually there are still some issues with this patch, mainly around your changes to incluce/FLAC/ordinals.h. This file is a public header file and hence, your changes: diff --git a/include/FLAC/ordinals.h b/include/FLAC/ordinals.h index 80d055b..dc2dafc 100644 --- a/include/FLAC/ordinals.h +++ b/include/FLAC/ordinals.h @@ -32,10 +32,18 @@