similar to: [PATCH] Fix use of uninitialized variable

--- include/share/compat.h | 8 ++++++++ src/flac/main.c | 37 +------------------------------------ src/share/grabbag/seektable.c | 31 +------------------------------ 3 files changed, 10 insertions(+), 66 deletions(-) diff --git a/include/share/compat.h b/include/share/compat.h index e9ac958..ff5c8af 100644 --- a/include/share/compat.h +++ b/include/share/compat.h

Hi, The --sign option in flac can be signed or unsigned, but the error message mentions "uint32_t". - Michael diff --git a/src/flac/main.c b/src/flac/main.c index 4e7361b3..c6d9b1e3 100644 --- a/src/flac/main.c +++ b/src/flac/main.c @@ -817,7 +817,7 @@ int parse_option(int short_option, const char *long_option, const char *option_a else if(0 == strncmp(option_argument,

Small change to metaflac hexdump function. Changed so utf-8 decoding is only used for filename printing and changed hex output printing to not rely only on isprint. That function seems to return true for tabulator control character under Windows when application isn't using C-locale. At least it did so for all locales I tried (Finnish, German, English US). -------------- next part

I have noticed flac -S- isn't working correctly, '-' isn't handled in parse_option() nor in convert_to_seek_table_template(). It makes SEEKTABLE with one seek point. Similar options -V-, -e-, -p-, ... are not allowed since 1.0.4, I think best would be drop -S- from documentation too and use --no-seektable option only. -- Miroslav Lichvar

make fullcheck fails on my computer: flac cannot recognize --skip option that contains decimal point, e.g. "--skip=1.234". System locale uses comma as a separator, so strtod/atof expect comma, not point, and "make fullcheck" fails. Here's what I can see in FLAC source code: atof() function found in: file: src/share/grabbag/seektable.c function:

If ‘virt-v2v -oo insecure’ is used then ‘openstack --insecure’ flag is added whenever we invoke the openstack command. This turns of SSL certificate validation. --- v2v/output_openstack.ml | 14 +++++++++++++- v2v/virt-v2v-output-openstack.pod | 1 + v2v/virt-v2v.pod | 7 +++++++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/v2v/output_openstack.ml

Hi all, I'm working on this item in Upstream Networking todolist: | - Sharing config interrupts | Support more devices by sharing a single msi vector | between multiple virtio devices. | (Applies to virtio-blk too). I have this solution here, and only have draft patches of Solution 1 & 2, let's discuss if solution 3 is feasible. * We should not introduce perf regression in

Hi all, I'm working on this item in Upstream Networking todolist: | - Sharing config interrupts | Support more devices by sharing a single msi vector | between multiple virtio devices. | (Applies to virtio-blk too). I have this solution here, and only have draft patches of Solution 1 & 2, let's discuss if solution 3 is feasible. * We should not introduce perf regression in

Mirrors virtio_cread_feature but for LE fields. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio_config.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index 5b5196fec899..cc7a2b1fd7b2 100644 --- a/include/linux/virtio_config.h +++ b/include/linux/virtio_config.h @@ -555,4 +555,14

If ‘virt-v2v -oo verify-server-certificate=false’ is used then ‘openstack --insecure’ flag is added whenever we invoke the openstack command. This turns off SSL certificate validation. The default is to verify the server certificate (which is the default of the openstack command). --- v2v/output_openstack.ml | 16 +++++++++++++++- v2v/test-v2v-o-openstack.sh | 2 ++

Secure firmwares provided by NVIDIA will follow the same overall principle, but may slightly differ in format, or not use the same bootloader descriptor even on the same chip. In order to handle this as gracefully as possible, turn the LS firmware functions into hooks that can be overloaded as needed. The current hooks cover the external firmware loading as well as the bootloader descriptor

More prep work for immutable biovecs - with immutable bvecs drivers won't be able to use the biovec directly, they'll need to use helpers that take into account bio->bi_iter.bi_bvec_done. This updates callers for the new usage without changing the implementation yet. Signed-off-by: Kent Overstreet <koverstreet at google.com> Cc: Jens Axboe <axboe at kernel.dk> Cc: Geert

More prep work for immutable biovecs - with immutable bvecs drivers won't be able to use the biovec directly, they'll need to use helpers that take into account bio->bi_iter.bi_bvec_done. This updates callers for the new usage without changing the implementation yet. Signed-off-by: Kent Overstreet <koverstreet at google.com> Cc: Jens Axboe <axboe at kernel.dk> Cc: Geert

More prep work for immutable biovecs - with immutable bvecs drivers won't be able to use the biovec directly, they'll need to use helpers that take into account bio->bi_iter.bi_bvec_done. This updates callers for the new usage without changing the implementation yet. Signed-off-by: Kent Overstreet <kmo at daterainc.com> Cc: Jens Axboe <axboe at kernel.dk> Cc: Geert

More prep work for immutable biovecs - with immutable bvecs drivers won't be able to use the biovec directly, they'll need to use helpers that take into account bio->bi_iter.bi_bvec_done. This updates callers for the new usage without changing the implementation yet. Signed-off-by: Kent Overstreet <kmo at daterainc.com> Cc: Jens Axboe <axboe at kernel.dk> Cc: Geert

More prep work for immutable biovecs - with immutable bvecs drivers won't be able to use the biovec directly, they'll need to use helpers that take into account bio->bi_iter.bi_bvec_done. This updates callers for the new usage without changing the implementation yet. Signed-off-by: Kent Overstreet <kmo at daterainc.com> Cc: Jens Axboe <axboe at kernel.dk> Cc: Geert

More prep work for immutable biovecs - with immutable bvecs drivers won't be able to use the biovec directly, they'll need to use helpers that take into account bio->bi_iter.bi_bvec_done. This updates callers for the new usage without changing the implementation yet. Signed-off-by: Kent Overstreet <kmo at daterainc.com> Cc: Jens Axboe <axboe at kernel.dk> Cc: Geert

More prep work for immutable biovecs - with immutable bvecs drivers won't be able to use the biovec directly, they'll need to use helpers that take into account bio->bi_iter.bi_bvec_done. This updates callers for the new usage without changing the implementation yet. Signed-off-by: Kent Overstreet <kmo at daterainc.com> Cc: Jens Axboe <axboe at kernel.dk> Cc: Geert

More prep work for immutable biovecs - with immutable bvecs drivers won't be able to use the biovec directly, they'll need to use helpers that take into account bio->bi_iter.bi_bvec_done. This updates callers for the new usage without changing the implementation yet. Signed-off-by: Kent Overstreet <kmo at daterainc.com> Cc: Jens Axboe <axboe at kernel.dk> Cc: Geert

More prep work for immutable biovecs - with immutable bvecs drivers won't be able to use the biovec directly, they'll need to use helpers that take into account bio->bi_iter.bi_bvec_done. This updates callers for the new usage without changing the implementation yet. Signed-off-by: Kent Overstreet <koverstreet at google.com> Cc: Jens Axboe <axboe at kernel.dk> Cc: Geert