similar to: [PATCH] resample: Fix input indexing bug from interleaved functions

There is a bug in "speex_resampler_process_interleaved_int" and "speex_resampler_process_interleaved_float" in the resampler. It seems that when "speex_resampler_process_int" is called for the first channel, "in_len" is set to the actual number of samples used (when output limited), which you would think would be OK to use for all the subsequent calls

.. And a version without the API changes. -------------- next part -------------- Index: libspeex/resample_sse.h =================================================================== --- libspeex/resample_sse.h (revision 0) +++ libspeex/resample_sse.h (revision 0) @@ -0,0 +1,128 @@ +/* Copyright (C) 2002-2008 Jean-Marc Valin + * Copyright (C) 2008 Thorvald Natvig + */ +/** + @file resample_sse.h +

Hi, Here's the (hopefully) final version of the resampler, now always using st->mem as the buffer area. It only allocates buffers on the stack when it's necesarry to convert the output between int and float. -------------- next part -------------- Index: include/speex/speex_resampler.h =================================================================== ---

Hi, I've attached a patch against SVN r14645 which adds GCC visibility information to all symbols exported from libspeex.so and libspeexdsp.so. It includes a configure.ac change to test that both the compiler flags and __attribute__((visibility)) works, and if so will #define EXPORT __attribute__((visibility("default"))) and if not #define EXPORT I've attached a diff output

Hi, I've attached a patch against SVN r14645 which adds GCC visibility information to all symbols exported from libspeex.so and libspeexdsp.so. It includes a configure.ac change to test that both the compiler flags and __attribute__((visibility)) works, and if so will #define EXPORT __attribute__((visibility("default"))) and if not #define EXPORT I've attached a diff output

From: Jyri Sarha <jsarha at ti.com> Semantics of inner_product_single have also been changed to contain the final right shift and saturation so it can also be implemented in the optimal way for the used platform. This change affects fixed point calculations only. I also added a new fixed point macro SATURATE32PSHR(x, shift, a). It does pretty much the same thing as SATURATE32(PSHR32(x,

Actually opus-tools-0.2 has the same issue. Sincerely Forrest Zhang -------------- next part -------------- Add "#define FIXED_POINT 1" into the top of resample.c, outputs of resample are all zeros. Actually the data transform is required before/after calling speex_resampler_process_native(). diff -Naupr libopusenc-0.2.1-vanilla/src/resample.c libopusenc-0.2.1/src/resample.c ---

From: Thorvald Natvig <slicer at users.sourceforge.net> Some optimizing compilers miscompile the current SSE optimizations when full optimizations are enabled. By using output value pointer instead of a return value, we can bypass this misbehaviour. --- libspeex/resample.c | 8 ++++---- libspeex/resample_sse.h | 24 ++++++++---------------- 2 files changed, 12 insertions(+), 20

From: Jyri Sarha <jsarha at ti.com> I optimized Speex resampler for NEON capable ARM CPUs. The first patch should speed up resampling on any platform that can spare the increased memory usage. It would be nice to have these merged to the master branch. Please let me know if there is anything I can do to help the the merge. The patches have been rebased on top of master branch in

Look, how about you start from the testresample.c file? Oh, and you seem to be reading 320 samples at a time and processing 640, so that can't be good (and even beyond that your code is wrong for other reasons). Jean-Marc On 11/6/19 1:56 AM, zhouyuchen at iauto.com wrote: > Hello, > I printed the log, in/out len is not truncated, which means that the > input and output are not

Hello, some misc. cleanup patches for speexdsp, nothing big I'm not sure about how to submit patches, so this is a test balloon :) ultimately, I'd like to fix the FIXED_POINT issue, see http://lists.xiph.org/pipermail/speex-dev/2013-December/008465.html currently, I think the only way to find out how speexdsp has been compiled is to resample some bytes and observe the output; which is

Be aware that inlen is an in/out parameter. It tells you how many samples the resampler read. That number can be smaller than what you passed -- in which case it means you need to buffer them and give them to the resampler again in the next call. Jean-Marc On 11/5/19 8:27 AM, zhouyuchen at iauto.com wrote: > Hello, > I have encountered some problems. I want to use speex to convert the

Hello everybody. I have the same problem like you. I use ARM microcontroller too. Here is the list of all functions called by speex_echo_cancel until goes into infinite loop: speex_echo_cancel() | spx_fft | kiss_fftr | kiss_fft | kiss_fft_stride | kf_work Function kf_work looks like: static void kf_work(kiss_fft_cpx * Fout, const kiss_fft_cpx * f, const size_t fstride, int

Need to adjust scale for floating input. diff -NaurbB a/libspeex/resample.c b/libspeex/resample.c --- a/libspeex/resample.c 2013-12-20 17:40:27.326576921 +0500 +++ b/libspeex/resample.c 2013-12-20 17:40:16.918577087 +0500 @@ -915,7 +915,7 @@ if (in) { for(j=0;j<ichunk;++j) #ifdef FIXED_POINT - x[j+st->filt_len-1]=WORD2INT(in[j*istride_save]); +

> > Hello everybody. > > I have the same problem like you. I use ARM microcontroller too. > > Here is the list of all functions called by speex_echo_cancel until goes > > into infinite loop: >... > > else > > { > > do > > { > > kf_work(Fout , f, fstride*p, in_stride, factors,st); // ><---------- > > here this

From: Jyri Sarha <jsarha at ti.com> Also adds inline asm implementations of WORD2INT(x) macro for fixed and floating point. --- libspeex/resample_neon.h | 101 ++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 101 insertions(+), 0 deletions(-) diff --git a/libspeex/resample_neon.h b/libspeex/resample_neon.h index ba93e41..e7e981e 100644 --- a/libspeex/resample_neon.h +++

Well, I don't quite understand why AC_C_BIGENDIAN and the solution you're proposing is likely to break other big endian machines (the ones that don't have __BIG_ENDIAN__). Can you send a patch that addresses that (i.e. still uses AC_C_BIGENDIAN when it works)? Jean-Marc Peter Grayson a ?crit : > Hi all, > > Speex currently decides endianness at configure-time. This causes

First of all, bufout_len = 320 is correct since that value is the number of stereo samples. Using 640 would be wrong (and no wonder that it crashes). Secondly, "speex_resampler_process_interleaved_float" has a bug that keeps it from working when it is output limited, so if you ever set "buf_len" to any value greater than 1764 the resampler will stop functioning properly

Hi Jean-Marc, I reported this bug a couple of months ago and either it got lost or I just didn't make my case very well. Let me see if I can explain why "speex_resampler_process_interleaved_int" and "speex_resampler_process_interleaved_float" in the resampler have a problem. If you call "speex_resampler_process_interleaved_int" with a small

Op 30-06-17 om 15:56 schreef Daniel Vetter: > On Wed, Jun 28, 2017 at 03:28:11PM +0200, Maarten Lankhorst wrote: >> We want to change swap_state to wait indefinitely, but to do this >> swap_state should wait interruptibly. This requires propagating >> the error to each driver. All drivers have changes to deal with the >> clean up. In order to allow easy reverting, the