similar to: Re: [libguestfs/nbdkit] Publish Rust bindings to crates.io (#4)

On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > The existing Rust bindings for nbdkit aren't very idiomatic Rust, and they > are missing a lot of features. So I've rewritten them. The new bindings > aren't backwards compatible, but I doubt that's a problem. Most likely, > nobody has tried to use them yet, since the crate hasn't even published to

On Mon, Jun 15, 2020 at 08:11:47AM -0600, alan somers wrote: > On Mon, Jun 15, 2020 at 8:04 AM Daniel P. Berrangé <berrange@redhat.com> > wrote: > > > On Mon, Jun 15, 2020 at 02:22:32PM +0100, Richard W.M. Jones wrote: > > > On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > > > > The existing Rust bindings for nbdkit aren't very idiomatic

On Mon, Jun 15, 2020 at 7:22 AM Richard W.M. Jones <rjones@redhat.com> wrote: > On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > > The existing Rust bindings for nbdkit aren't very idiomatic Rust, and > they > > are missing a lot of features. So I've rewritten them. The new bindings > > aren't backwards compatible, but I doubt that's a

On Mon, Jun 15, 2020 at 8:04 AM Daniel P. Berrangé <berrange@redhat.com> wrote: > On Mon, Jun 15, 2020 at 02:22:32PM +0100, Richard W.M. Jones wrote: > > On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > > > The existing Rust bindings for nbdkit aren't very idiomatic Rust, and > they > > > are missing a lot of features. So I've rewritten

On Mon, Jun 15, 2020 at 02:22:32PM +0100, Richard W.M. Jones wrote: > On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > > The existing Rust bindings for nbdkit aren't very idiomatic Rust, and they > > are missing a lot of features. So I've rewritten them. The new bindings > > aren't backwards compatible, but I doubt that's a problem. Most

On Wed, Jun 17, 2020 at 08:42:19AM -0600, alan somers wrote: > On Wed, Jun 17, 2020 at 5:23 AM Richard W.M. Jones <rjones@redhat.com> > wrote: > > > I pushed 2 & 3, thanks. > > > > But ... > > > > > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > > > From: Alan Somers <asomers@gmail.com> > > >

The existing Rust bindings for nbdkit aren't very idiomatic Rust, and they are missing a lot of features. So I've rewritten them. The new bindings aren't backwards compatible, but I doubt that's a problem. Most likely, nobody has tried to use them yet, since the crate hasn't even published to crates.io. Please review the attached patch. -Alan

On Wed, Jun 17, 2020 at 08:38:30AM -0600, alan somers wrote: > On Wed, Jun 17, 2020 at 7:33 AM Eric Blake <eblake@redhat.com> wrote: > > > On 6/17/20 6:23 AM, Richard W.M. Jones wrote: > > > I pushed 2 & 3, thanks. > > > > > > But ... > > > > > >> From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > >

I added - data required to publish this crate to `crates.io`. - README.md which contains the details of how to publish this crate. --- rust/Cargo.toml.in | 5 ++++- rust/README.md | 42 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 rust/README.md diff --git a/rust/Cargo.toml.in b/rust/Cargo.toml.in index b61e3ec7f..d217a530e

I pushed 2 & 3, thanks. But ... > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > From: Alan Somers <asomers@gmail.com> > Date: Mon, 15 Jun 2020 16:59:53 -0600 > Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level directory > > This is necessary for other Rust projects to depend on unrelesed > versions of the nbdkit crate. > ---

On Wed, Jun 17, 2020 at 5:23 AM Richard W.M. Jones <rjones@redhat.com> wrote: > I pushed 2 & 3, thanks. > > But ... > > > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > > From: Alan Somers <asomers@gmail.com> > > Date: Mon, 15 Jun 2020 16:59:53 -0600 > > Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level

On 6/17/20 6:23 AM, Richard W.M. Jones wrote: > I pushed 2 & 3, thanks. > > But ... > >> From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 >> From: Alan Somers <asomers@gmail.com> >> Date: Mon, 15 Jun 2020 16:59:53 -0600 >> Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level directory >> >> This is necessary

On Wed, Jun 17, 2020 at 7:33 AM Eric Blake <eblake@redhat.com> wrote: > On 6/17/20 6:23 AM, Richard W.M. Jones wrote: > > I pushed 2 & 3, thanks. > > > > But ... > > > >> From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > >> From: Alan Somers <asomers@gmail.com> > >> Date: Mon, 15 Jun 2020 16:59:53 -0600

On Fri, Jul 05, 2019 at 08:37:20AM +0100, Richard W.M. Jones wrote: >On Fri, Jul 05, 2019 at 01:28:12PM +0900, Hiroyuki Katsura wrote: >> > Have you decided whether we need to commit the generated files >> > (Cargo.toml, Cargo.lock)? It looks like in this series those files >> > are still included and not added to .gitignore. >> >> I'm sorry I forgot

On Sat, Jun 06, 2020 at 07:26:45AM -0600, alan somers wrote: > Yes, Rust uses native threads. Setting the errno explicitly with > nbdkit_set_error sounds good. I have a good start on new bindings, and > should have something to show next week. Thanks - let us know if you have any problems. Also we're usually around in #libguestfs on IRC. Rich. -- Richard Jones, Virtualization

On Mon, Jun 15, 2020 at 07:42:58AM -0600, Alan Somers wrote: > Ok, I can make those changes. Speaking of "make check", what about CI? It > would be pretty easy to add it to this project. Is there a reason you > haven't done it already? We're probably going to move to an open source hosting service at some point, and don't want to depend too deeply on closed

On Mon, Oct 19, 2020 at 10:58 AM alan somers <asomers@gmail.com> wrote: > On Wed, Oct 14, 2020 at 3:41 AM Daniel P. Berrangé <berrange@redhat.com> > wrote: > >> On Wed, Oct 14, 2020 at 10:37:26AM +0100, Richard W.M. Jones wrote: >> > On Tue, Oct 13, 2020 at 03:21:35PM -0600, alan somers wrote: >> > > Would libguestfs be willing to enable CI for the

[To continue the conversation from https://github.com/libguestfs/nbdkit/issues/5] > Currently there's no way for the Rust plugin to report an error. The > idiomatic way to do it would be for each callback to return a Result > object, much like how the Go plugin currently does it. I'm sure it's not idiomatic for Rust, but I just wanted to say that there is a way to return an

On Sat, Jun 6, 2020 at 3:39 AM Richard W.M. Jones <rjones@redhat.com> wrote: > [To continue the conversation from > https://github.com/libguestfs/nbdkit/issues/5] > > > Currently there's no way for the Rust plugin to report an error. The > > idiomatic way to do it would be for each callback to return a Result > > object, much like how the Go plugin currently

I fixed this patch based on comments. I merged all commits to a single commit. I'll send this final patch to this list. Regards, Hiroyuki 2019年7月8日(月) 19:36 Martin Kletzander <mkletzan@redhat.com>: > On Mon, Jul 08, 2019 at 10:04:57AM +0100, Richard W.M. Jones wrote: > >On Mon, Jul 08, 2019 at 10:49:55AM +0200, Martin Kletzander wrote: > >> On Mon, Jul 08, 2019 at