similar to: Re: Virt Customize features from python

Check that a path provided to --edit exists already; while the is_file call later will fail for non-existing files, with an explicit check a better error message can be provided. --- customize/customize_run.ml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/customize/customize_run.ml b/customize/customize_run.ml index ff7bd0d..054ee53 100644 --- a/customize/customize_run.ml +++

--update invokes a distribution update, updating all the installed packages and not just some "core" ones. --- customize/customize_run.ml | 2 +- generator/customize.ml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/customize/customize_run.ml b/customize/customize_run.ml index 82c4edd..83e70a6 100644 --- a/customize/customize_run.ml +++

FAT doesn't support file ownership, so show warning instead of error. --- customize/customize_run.ml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/customize/customize_run.ml b/customize/customize_run.ml index dbb77df..306b7f2 100644 --- a/customize/customize_run.ml +++ b/customize/customize_run.ml @@ -290,7 +290,10 @@ exec >>%s 2>&1 let perms =

I discovered that 'dnf upgrade' doesn't actually upgrade to the latest versions of packages unless you also supply the '--best' flag. This also changes update -> upgrade, since apparently 'dnf update' is deprecated. --- customize/customize_run.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/customize/customize_run.ml

This option was considered unsecure, found a fix on the generated opensuse images instead. --- customize/customize_run.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/customize/customize_run.ml b/customize/customize_run.ml index ad0ab7f..6cb2328 100644 --- a/customize/customize_run.ml +++ b/customize/customize_run.ml @@ -116,7 +116,7 @@ exec >>%s 2>&1

--- customize/customize_run.ml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/customize/customize_run.ml b/customize/customize_run.ml index ed3c818..48475af 100644 --- a/customize/customize_run.ml +++ b/customize/customize_run.ml @@ -97,6 +97,11 @@ exec >>%s 2>&1 let guest_install_command packages = let quoted_args = String.concat " " (List.map

Otherwise the installation will fail right away, since pacman by default asks for confirmation of the operation. --- customize/customize_run.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/customize/customize_run.ml b/customize/customize_run.ml index 6f0d615..3e759a2 100644 --- a/customize/customize_run.ml +++ b/customize/customize_run.ml @@ -117,7 +117,7 @@ exec >>%s

Wrap the command around an heredoc only if setarch needs to be used; otherwise the heredoc will not be run at all. Fix commit d875346ad441d4762455ea1b41d57ad6174d9b63. --- customize/customize_run.ml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/customize/customize_run.ml b/customize/customize_run.ml index 2283272..9d97522 100644 ---

When running (eg) dnf on a 32 bit i686 guest when the host is 64 bit x86_64, dnf believes it is running on a 64 bit machine and so tries to install x86_64 packages. We can 'trick' dnf into believing it's a 32 bit machine using the setarch program. $ virt-builder fedora-22 --arch i686 --install 'gperf' ... [ 27.4] Installing packages: gperf ... Running transaction test Error:

--- customize/customize_run.ml | 30 ++++++++++++++++++++++++++++++ generator/customize.ml | 17 +++++++++++++++-- 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/customize/customize_run.ml b/customize/customize_run.ml index c9d9d7d..b2506d1 100644 --- a/customize/customize_run.ml +++ b/customize/customize_run.ml @@ -151,6 +151,31 @@ exec >>%s 2>&1 | pm ->

This currently only works with numeric UID.GID. In theory in future we could look up IDs from the guest password file (eg. using Augeas) and do the right thing, but that's a bunch more work. For example: $ ./builder/virt-builder fedora-36 --chown 1.1:/var/tmp [ 1.0] Downloading: http://builder.libguestfs.org/fedora-36.xz [ 1.5] Planning how to build this image [ 1.5] Uncompressing [

On Wednesday 04 May 2016 14:12:30 Richard W.M. Jones wrote: > For Windows, we now print: > > $ virt-customize -a ./test-data/phony-guests/windows.img --install MSSQL > [ 0.0] Examining the guest ... > [ 14.2] Setting a random seed > virt-customize: warning: random seed could not be set for this type of > guest > [ 14.2] Installing packages: MSSQL > virt-customize:

On 6/29/23 14:50, Richard W.M. Jones wrote: > This currently only works with numeric UID.GID. In theory in future > we could look up IDs from the guest password file (eg. using Augeas) > and do the right thing, but that's a bunch more work. > > For example: > > $ ./builder/virt-builder fedora-36 --chown 1.1:/var/tmp > [ 1.0] Downloading:

FAT doesn't support file ownership, so show warning instead of error. Fixes RHBZ#1196101 Maros Zatko (1): customize: fix --upload to FAT partition (RHBZ#1196101) customize/customize_run.ml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 1.9.3

Some filesystems, such as FAT doesn't support file ownership, so show warning instead of error on EPERM. Maros Zatko (1): customize: fix --upload to FAT partition (RHBZ#1196101) customize/customize_run.ml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) -- 1.9.3

Pass to --commands-from-file the name of a file containing customization commands in each line, as if they were specified as command line arguments. This eases the reuse of commands among different builder/customize/sysprep invocations. --- builder/cmdline.ml | 3 +- customize/customize_run.ml | 5 +++ generator/customize.ml | 98 ++++++++++++++++++++++++++++++++++++++++++++-- 3

Fixes RHBZ#119673. Maros Zatko (1): customize: add --truncate option (RHBZ#119673) builder/cmdline.ml | 2 +- customize/customize_run.ml | 4 ++++ generator/customize.ml | 9 +++++++++ 3 files changed, 14 insertions(+), 1 deletion(-) -- 1.9.3

From: Maros Zatko <hacxman@gmail.com> This adds --copy SOURCE:DEST, equivalent of calling g#cp_a src dst. RFE: RHBZ#1203817 Maros Zatko (1): customize: add --copy builder/cmdline.ml | 2 +- customize/customize_run.ml | 4 ++++ generator/customize.ml | 10 ++++++++++ 3 files changed, 15 insertions(+), 1 deletion(-) -- 1.9.3

From: Maros Zatko <hacxman@gmail.com> This adds --move SOURCE:DEST, equivalent of calling g#mv src dst. RFE: RHBZ#1203817 Maros Zatko (1): customize: add --move builder/cmdline.ml | 2 +- customize/customize_run.ml | 4 ++++ generator/customize.ml | 10 ++++++++++ 3 files changed, 15 insertions(+), 1 deletion(-) -- 1.9.3

Allows user to recursively truncate all files in a directory. Related to RHBZ#119673 Maros Zatko (1): customize: add --truncate-recursive option builder/cmdline.ml | 3 ++- customize/customize_run.ml | 6 ++++++ generator/customize.ml | 8 ++++++++ 3 files changed, 16 insertions(+), 1 deletion(-) -- 1.9.3