similar to: [PATCH 1/3] nbdkit: fix build of the SSH plugin on FreeBSD

This time it should hopefully work. I tested all 3 combinations: autoconf ./configure [--disable-linuxdisk | --enable-linuxdisk | <nothing> ] make clean && make && make check and they all appear to do the right thing. Rich.

From: Alan Somers <asomers@gmail.com> This can be used to disable the linuxdisk plugin, which otherwise is always built if a suitable mke2fs command is present. --- configure.ac | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index f24c3734..c93e822b 100644 --- a/configure.ac +++ b/configure.ac @@ -483,18 +483,25 @@

When I was reviewing this I forgot the slightly ridiculous rules that autoconf uses for --enable/disable vs --with/without: https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/Package-Options.html https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/External-Software.html Since this is disabling an intrinsic feature of the software (a plugin) it should use

For v3 I reimplemented this using mke2fs -d. This obviously makes the implementation a whole lot simpler, but cannot support multiple directory merging. Patches 1-3 are the same as before. I've also reproduced the notes from v2 below. v2: - Fix inconsistent tab/space. - All 3 plugins now contain a block of text pointing to the other 2 plugins. - TMDIR -> TMPDIR - Unlink the

Another interesting thing you can do with this plugin: https://rwmj.wordpress.com/2019/02/19/nbdkit-linuxdisk-plugin/ v2: - Fix inconsistent tab/space. - All 3 plugins now contain a block of text pointing to the other 2 plugins. - TMDIR -> TMPDIR - Unlink the temporary file and other cleanups along error paths. - fclose -> pclose, and check the return value for errors. -

Turns out Japanese trains are good for coding! In supermin we have a bunch of code to create the libguestfs appliance. It creates it directly using libext2fs (part of e2fsprogs). We can use the same technique to create ext2 virtual disks in nbdkit, which is what this new plugin does. Why a new plugin instead of modifying the floppy plugin? See the 4/4 commit message for an explanation. The

Unfinished (needs tests). This is my attempt to make a "remote tmpfs" plugin as outlined in this prior email: https://www.redhat.com/archives/libguestfs/2020-March/msg00134.html Although it would be possible to construct something a bit like this using existing plugins and filters (perhaps with some new features in those filters) I think it may be nicer to have a dedicated plugin for

The nbdkit tests take a long time to run especially on armv7. To try to get an idea of which tests take the most time, and since I happen to have a qemu aarch64 *TCG* guest available, I ran the tests on that guest. A TCG guest is about the worst case for libguestfs, used by some tests, since it uses double-nested TCG, and as you can see below there are tests taking over 6 hours. In fact I

v2 was here: https://www.redhat.com/archives/libguestfs/2020-March/msg00154.html v3: - Micro-optimize tmpdir. - Quote $disk in default command shell fragment. - Don't redirect mkfs output to /dev/null. Instead use exec </dev/null >/dev/null before the shell fragment. We may want to do this in other places where we run external shell scripts, or more generally for all

On 6/17/20 6:23 AM, Richard W.M. Jones wrote: > I pushed 2 & 3, thanks. > > But ... > >> From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 >> From: Alan Somers <asomers@gmail.com> >> Date: Mon, 15 Jun 2020 16:59:53 -0600 >> Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level directory >> >> This is necessary

On Wed, Jun 17, 2020 at 5:23 AM Richard W.M. Jones <rjones@redhat.com> wrote: > I pushed 2 & 3, thanks. > > But ... > > > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > > From: Alan Somers <asomers@gmail.com> > > Date: Mon, 15 Jun 2020 16:59:53 -0600 > > Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level

I like this change. I think we were overloading the config_complete method before to do two different things (complete configuration; do any allocation/housekeeping necessary before we can start serving). The only questions in my mind are whether we want this before 1.18, and whether the name ("get_ready") is a good one. Rich.

On Mon, Oct 19, 2020 at 10:58 AM alan somers <asomers@gmail.com> wrote: > On Wed, Oct 14, 2020 at 3:41 AM Daniel P. Berrangé <berrange@redhat.com> > wrote: > >> On Wed, Oct 14, 2020 at 10:37:26AM +0100, Richard W.M. Jones wrote: >> > On Tue, Oct 13, 2020 at 03:21:35PM -0600, alan somers wrote: >> > > Would libguestfs be willing to enable CI for the

v1 was: https://www.redhat.com/archives/libguestfs/2019-September/thread.html#00361 v2: - Adds a patch to rename the reflection plugin to the info plugin. - Adds tests. Rich.

Question: Should the new directory= parameter of the file plugin be "dir="? It's shorter. It's also consistent with the plugins floppy, iso, linuxdisk, and of course ondemand ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to

I will be following up to this email with four separate threads each addressed to the appropriate single list, with proposed changes to: - the NBD protocol - qemu: both server and client - libnbd: client - nbdkit: server The feature in question adds a new optional NBD_INFO_ packet to the NBD_OPT_GO portion of handshake, adding up to 16 bits of information that the server can advertise to the

This creates libnbdkit.so as discussed in the following thread: https://www.redhat.com/archives/libguestfs/2020-March/thread.html#00203 test-delay-shutdown.sh fails for unclear reasons. This series starts by reverting "tests: Don't strand hung nbdkit processes" which is because several other tests fail randomly unless I revert this patch. I didn't investigate this yet so it

On Wed, Oct 14, 2020 at 10:37:26AM +0100, Richard W.M. Jones wrote: > On Tue, Oct 13, 2020 at 03:21:35PM -0600, alan somers wrote: > > Would libguestfs be willing to enable CI for the nbdkit project?  It's very > > easy to set up, at least for the Rust portion.  I'm comfortable with both > > Cirrus CI and Github's native CI.  I can get it started if you agree to do

This is a major rewrite compared to my v1 series, where I've tried a lot harder to ensure that we still accommodate building on Haiku (although I have not actually yet fired up a Haiku VM to try it for myself). I also managed to make the sh plugin fully parallel, on capable platforms. See also my question on patch 10 on whether I've picked the best naming convention. Eric Blake (17):