similar to: nbdkit rust plugin: copyright notices, Cargo workspace, and macro hygiene

On Wed, Jun 17, 2020 at 5:23 AM Richard W.M. Jones <rjones@redhat.com> wrote: > I pushed 2 & 3, thanks. > > But ... > > > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > > From: Alan Somers <asomers@gmail.com> > > Date: Mon, 15 Jun 2020 16:59:53 -0600 > > Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level

On 6/17/20 6:23 AM, Richard W.M. Jones wrote: > I pushed 2 & 3, thanks. > > But ... > >> From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 >> From: Alan Somers <asomers@gmail.com> >> Date: Mon, 15 Jun 2020 16:59:53 -0600 >> Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level directory >> >> This is necessary

On Wed, Jun 17, 2020 at 08:42:19AM -0600, alan somers wrote: > On Wed, Jun 17, 2020 at 5:23 AM Richard W.M. Jones <rjones@redhat.com> > wrote: > > > I pushed 2 & 3, thanks. > > > > But ... > > > > > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > > > From: Alan Somers <asomers@gmail.com> > > >

I pushed 2 & 3, thanks. But ... > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > From: Alan Somers <asomers@gmail.com> > Date: Mon, 15 Jun 2020 16:59:53 -0600 > Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level directory > > This is necessary for other Rust projects to depend on unrelesed > versions of the nbdkit crate. > ---

On Wed, Jun 17, 2020 at 08:38:30AM -0600, alan somers wrote: > On Wed, Jun 17, 2020 at 7:33 AM Eric Blake <eblake@redhat.com> wrote: > > > On 6/17/20 6:23 AM, Richard W.M. Jones wrote: > > > I pushed 2 & 3, thanks. > > > > > > But ... > > > > > >> From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > >

On Wed, Jun 17, 2020 at 7:33 AM Eric Blake <eblake@redhat.com> wrote: > On 6/17/20 6:23 AM, Richard W.M. Jones wrote: > > I pushed 2 & 3, thanks. > > > > But ... > > > >> From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > >> From: Alan Somers <asomers@gmail.com> > >> Date: Mon, 15 Jun 2020 16:59:53 -0600

The existing Rust bindings for nbdkit aren't very idiomatic Rust, and they are missing a lot of features. So I've rewritten them. The new bindings aren't backwards compatible, but I doubt that's a problem. Most likely, nobody has tried to use them yet, since the crate hasn't even published to crates.io. Please review the attached patch. -Alan

On Fri, Jul 05, 2019 at 08:37:20AM +0100, Richard W.M. Jones wrote: >On Fri, Jul 05, 2019 at 01:28:12PM +0900, Hiroyuki Katsura wrote: >> > Have you decided whether we need to commit the generated files >> > (Cargo.toml, Cargo.lock)? It looks like in this series those files >> > are still included and not added to .gitignore. >> >> I'm sorry I forgot

> Have you decided whether we need to commit the generated files > (Cargo.toml, Cargo.lock)? It looks like in this series those files > are still included and not added to .gitignore. I'm sorry I forgot adding Cargo.lock to .gitignore. I'll add it to .gitignore. However, I think Cargo.toml should be staged. This is because this is a file managed by hands. It contains

`cargo doc` will generate docs with long descriptions. I did not add the settings of outputting these docs to `/website`. This is because - by publishing this crate to crates.io, users can see the docs in `docs.rs` like `https://docs.rs/guestfs/<version>/guestfs/`. It is easy to hold multiple documents corresponding to each version. - the style of the documents generated by `cargo doc`

I managed to get a build of the async Rust handle compiling on FreeBSD (although the cirrus CI appears to not actually run 'make check' on non-Linux machines, at least when run on my fork): https://gitlab.com/ebblake/libnbd/-/jobs/4985192286 However, I'd really like Tage's review on patch 2 to see if my Rust makes sense. Eric Blake (2): maint: Favor 4-space indent in .rs files

On Thu, Jun 27, 2019 at 05:06:04PM +0900, Hiroyuki Katsura wrote: > From: Hiroyuki_Katsura <hiroyuki.katsura.0513@gmail.com> > > --- > generator/rust.ml | 13 ++++++++--- > run.in | 9 ++++++++ > rust/Cargo.lock | 6 +++++ > rust/Cargo.toml | 4 +--- > rust/tests/010_load.rs

This adds very rough support for writing nbdkit plugins in Rust. This is not very idiomatic -- essentially we're handling the direct C calls from nbdkit in Rust. We have to use ‘unsafe’ in a few places because there's no way to tell the Rust code that nbdkit satisfies guarantees (eg. around thread safety, always returning leaked pointers back to the close function, always doing bounds

There are few more things that could be cleaned up related to the coding style and other things, like explicitly specifying the abi style after "extern" (i.e. `extern "C" fn` instead of `extern fn`), but since those are configurable in rustfmt config, I'm not sure whether the config needs to be added or complying with the defaults should be the priority. But this was just

On Thu, Jun 27, 2019 at 06:27:05PM +0900, Hiroyuki Katsura wrote: > > I guess this is a stray debug message? > > Yes. I'm sorry... > > > we did *not* check them into git. > > Really? Does it mean that every time you build the library, Cargo.toml is > generated? That's how it has worked in nbdkit. Whether it's right or not I don't know. Normally

On Mon, Jul 08, 2019 at 10:10:10AM +0200, Pino Toscano wrote: >On Saturday, 6 July 2019 13:03:24 CEST Martin Kletzander wrote: >> Just one thing, the Cargo.toml includes a version under which the crate would be >> published. I presume the version would be the same as the one of the project >> itself, i.e. when releasing libguestfs-x.y.z, we publish guestfs-rs-x.y.z to

Hi Hiroyuki, sorry for the late reply. Most of the work is definitely nice! There are few notes below, although they are not big issues. I will check this patch once more on monday, especially the rust parts. Otherwise, I'd say that we are close to merging this :) On Tuesday, 23 July 2019 10:37:17 CEST Hiroyuki Katsura wrote: > From: Hiroyuki_Katsura

Still not working, but I took the latest patch and: - rebased it against libnbd 1.0 - fixed it so it handles new args and cbargs The generator now runs without warnings. This patch doesn't handle optargs at all. In C these are converted to non-optional parameter. Rust doesn't (AFAIK) have optional or labelled arguments unfortunately. Rich.

On Mon, Oct 19, 2020 at 10:58 AM alan somers <asomers@gmail.com> wrote: > On Wed, Oct 14, 2020 at 3:41 AM Daniel P. Berrangé <berrange@redhat.com> > wrote: > >> On Wed, Oct 14, 2020 at 10:37:26AM +0100, Richard W.M. Jones wrote: >> > On Tue, Oct 13, 2020 at 03:21:35PM -0600, alan somers wrote: >> > > Would libguestfs be willing to enable CI for the

> Is this just trying if the guestfs can be linked with? Yes. In OCaml bindings, there is the corresponding test( https://github.com/libguestfs/libguestfs/blob/master/ocaml/t/guestfs_010_load.ml). I just mimicked it. If it is not required, I will remove it. divided the generated files and handmade files in rust/src/ directory. I'll send this fixed patch to this mailing list. I'm not