similar to: nbdkit: run rust plugin's tests during "make check"

On Wed, Jun 17, 2020 at 5:23 AM Richard W.M. Jones <rjones@redhat.com> wrote: > I pushed 2 & 3, thanks. > > But ... > > > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > > From: Alan Somers <asomers@gmail.com> > > Date: Mon, 15 Jun 2020 16:59:53 -0600 > > Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level

Ignore the previous patch; it didn't update EXTRA_DIST. Use this one instead.

On 6/17/20 6:23 AM, Richard W.M. Jones wrote: > I pushed 2 & 3, thanks. > > But ... > >> From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 >> From: Alan Somers <asomers@gmail.com> >> Date: Mon, 15 Jun 2020 16:59:53 -0600 >> Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level directory >> >> This is necessary

The existing Rust bindings for nbdkit aren't very idiomatic Rust, and they are missing a lot of features. So I've rewritten them. The new bindings aren't backwards compatible, but I doubt that's a problem. Most likely, nobody has tried to use them yet, since the crate hasn't even published to crates.io. Please review the attached patch. -Alan

On Mon, Oct 19, 2020 at 10:58 AM alan somers <asomers@gmail.com> wrote: > On Wed, Oct 14, 2020 at 3:41 AM Daniel P. Berrangé <berrange@redhat.com> > wrote: > >> On Wed, Oct 14, 2020 at 10:37:26AM +0100, Richard W.M. Jones wrote: >> > On Tue, Oct 13, 2020 at 03:21:35PM -0600, alan somers wrote: >> > > Would libguestfs be willing to enable CI for the

On Mon, Jun 15, 2020 at 02:22:32PM +0100, Richard W.M. Jones wrote: > On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > > The existing Rust bindings for nbdkit aren't very idiomatic Rust, and they > > are missing a lot of features. So I've rewritten them. The new bindings > > aren't backwards compatible, but I doubt that's a problem. Most

On Mon, Jun 15, 2020 at 08:11:47AM -0600, alan somers wrote: > On Mon, Jun 15, 2020 at 8:04 AM Daniel P. Berrangé <berrange@redhat.com> > wrote: > > > On Mon, Jun 15, 2020 at 02:22:32PM +0100, Richard W.M. Jones wrote: > > > On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > > > > The existing Rust bindings for nbdkit aren't very idiomatic

On Mon, Jun 15, 2020 at 7:22 AM Richard W.M. Jones <rjones@redhat.com> wrote: > On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > > The existing Rust bindings for nbdkit aren't very idiomatic Rust, and > they > > are missing a lot of features. So I've rewritten them. The new bindings > > aren't backwards compatible, but I doubt that's a

On Wed, Oct 14, 2020 at 10:37:26AM +0100, Richard W.M. Jones wrote: > On Tue, Oct 13, 2020 at 03:21:35PM -0600, alan somers wrote: > > Would libguestfs be willing to enable CI for the nbdkit project?  It's very > > easy to set up, at least for the Rust portion.  I'm comfortable with both > > Cirrus CI and Github's native CI.  I can get it started if you agree to do

From: Alan Somers <asomers@gmail.com> There was a missing #include. It only worked on Linux due to header pollution. --- plugins/ssh/ssh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/ssh/ssh.c b/plugins/ssh/ssh.c index ea199a93..a4007c40 100644 --- a/plugins/ssh/ssh.c +++ b/plugins/ssh/ssh.c @@ -30,6 +30,8 @@ * SUCH DAMAGE. */ +#include <sys/stat.h> +

On Wed, Jun 17, 2020 at 08:42:19AM -0600, alan somers wrote: > On Wed, Jun 17, 2020 at 5:23 AM Richard W.M. Jones <rjones@redhat.com> > wrote: > > > I pushed 2 & 3, thanks. > > > > But ... > > > > > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > > > From: Alan Somers <asomers@gmail.com> > > >

On Wed, Jun 17, 2020 at 08:38:30AM -0600, alan somers wrote: > On Wed, Jun 17, 2020 at 7:33 AM Eric Blake <eblake@redhat.com> wrote: > > > On 6/17/20 6:23 AM, Richard W.M. Jones wrote: > > > I pushed 2 & 3, thanks. > > > > > > But ... > > > > > >> From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > >

[To continue the conversation from https://github.com/libguestfs/nbdkit/issues/5] > Currently there's no way for the Rust plugin to report an error. The > idiomatic way to do it would be for each callback to return a Result > object, much like how the Go plugin currently does it. I'm sure it's not idiomatic for Rust, but I just wanted to say that there is a way to return an

I pushed 2 & 3, thanks. But ... > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > From: Alan Somers <asomers@gmail.com> > Date: Mon, 15 Jun 2020 16:59:53 -0600 > Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level directory > > This is necessary for other Rust projects to depend on unrelesed > versions of the nbdkit crate. > ---

On Wed, Jun 17, 2020 at 7:33 AM Eric Blake <eblake@redhat.com> wrote: > On 6/17/20 6:23 AM, Richard W.M. Jones wrote: > > I pushed 2 & 3, thanks. > > > > But ... > > > >> From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > >> From: Alan Somers <asomers@gmail.com> > >> Date: Mon, 15 Jun 2020 16:59:53 -0600

Would libguestfs be willing to enable CI for the nbdkit project? It's very easy to set up, at least for the Rust portion. I'm comfortable with both Cirrus CI and Github's native CI. I can get it started if you agree to do it. -Alan

On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > The existing Rust bindings for nbdkit aren't very idiomatic Rust, and they > are missing a lot of features. So I've rewritten them. The new bindings > aren't backwards compatible, but I doubt that's a problem. Most likely, > nobody has tried to use them yet, since the crate hasn't even published to

On Mon, Jun 15, 2020 at 8:04 AM Daniel P. Berrangé <berrange@redhat.com> wrote: > On Mon, Jun 15, 2020 at 02:22:32PM +0100, Richard W.M. Jones wrote: > > On Thu, Jun 11, 2020 at 04:19:08PM -0600, alan somers wrote: > > > The existing Rust bindings for nbdkit aren't very idiomatic Rust, and > they > > > are missing a lot of features. So I've rewritten

On Sat, Jun 06, 2020 at 07:26:45AM -0600, alan somers wrote: > Yes, Rust uses native threads. Setting the errno explicitly with > nbdkit_set_error sounds good. I have a good start on new bindings, and > should have something to show next week. Thanks - let us know if you have any problems. Also we're usually around in #libguestfs on IRC. Rich. -- Richard Jones, Virtualization