similar to: [v2v PATCH v2] libosinfo: do not declare OsinfoList auto-cleanup in certain situations

libosinfo 1.8.0 declares them automatically for all of its classes, so there is no need to declare ours. This requires fixing the definition of the IS_LIBOSINFO_VERSION macro to wrap its body in brackets. While in the process, simplify the workaround for a related bug by removing a now-useless check. --- v2v/libosinfo-c.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

Avoid using an auto-cleanup for OsinfoList, duplicating the cleanup everywhere needed. --- v2v/libosinfo-c.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/v2v/libosinfo-c.c b/v2v/libosinfo-c.c index 322e7d3d..75c2fae4 100644 --- a/v2v/libosinfo-c.c +++ b/v2v/libosinfo-c.c @@ -49,17 +49,6 @@ #if !IS_LIBOSINFO_VERSION(1, 8, 0)

Starting from glib 2.63.3, Module classes have already auto-cleanup functions declared for them. Reported by: Kevin Locke. --- v2v/libosinfo-c.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/v2v/libosinfo-c.c b/v2v/libosinfo-c.c index 1ab6bb4d..e6827f76 100644 --- a/v2v/libosinfo-c.c +++ b/v2v/libosinfo-c.c @@ -44,7 +44,9 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(OsinfoFilter, g_object_unref)

This patch series integrates libosinfo in virt-v2v to get the list of files for Windows from libosinfo, if possible. The actual data is still from virtio-win, just unpacked. Changes from v1: - adapt to use the priority in libosinfo 1.7.0+ - filter out non-pre-installable drivers - collect all the drivers matching the requirements, not just the first, sorting them by priority like libosinfo does

This patch series integrates libosinfo in virt-v2v to get the list of files for Windows from libosinfo, if possible. The actual data is still from virtio-win, just unpacked. Pino Toscano (3): build: require libosinfo v2v: add a minimal libosinfo interface v2v: try to get windows driver files from libosinfo m4/guestfs-v2v.m4 | 3 + v2v/Makefile.am | 9 +-

Hi All, I'm attempting to compile virt-v2v 1.42.0 on Debian testing. With gcc 9.3.0, libosinfo 1.7.1, and glib 2.64.2, `./configure && make` fails on libosinfo-c.c with the following error message: -8<-------------------------------------------------------------------- In file included from /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:9, from

On Monday, 1 June 2020 04:17:00 CEST Kevin Locke wrote: > Hi All, > > I'm attempting to compile virt-v2v 1.42.0 on Debian testing. With gcc > 9.3.0, libosinfo 1.7.1, and glib 2.64.2, `./configure && make` fails > on libosinfo-c.c with the following error message: > > -8<-------------------------------------------------------------------- > In file included

Hi Pino: I've suppressed some OCaml and libosinfo valgrind errors in virt-v2v. The remaining valgrind errors are here: http://oirase.annexia.org/tmp/v2vvg/ They all seem to be basically the same. But I couldn't work out if these are expected leaks in the libosinfo code (in which case we should suppress them), or if they are actual bugs because we are missing a true destructor here:

NetworkManager used to work fine for me but during the last few installations its a big hurdle in the wireless connectivity. I'm using Madwifi and its interface is correctly listed and working but I cannot connect to any wifi AP without NetworkManager. I've two interfaces: eth0 and wifi0. Starting NetworkManager doesn't show any notification icon in the top right in gnome and I believe

On Fri, Nov 23, 2018 at 02:26:08PM +0100, Martin Kletzander wrote: >On Fri, Nov 23, 2018 at 01:16:55PM +0000, Richard W.M. Jones wrote: >>On Fri, Nov 23, 2018 at 02:10:01PM +0100, Martin Kletzander wrote: [...] >>> I haven't find any unit tests for these kind of functions, so no >>> tests are added. If there is a place where tests would fit >>>

On Tuesday, 14 April 2020 11:53:30 CEST Richard W.M. Jones wrote: > I've suppressed some OCaml and libosinfo valgrind errors in virt-v2v. > > The remaining valgrind errors are here: > > http://oirase.annexia.org/tmp/v2vvg/ > > They all seem to be basically the same. But I couldn't work out if > these are expected leaks in the libosinfo code (in which case we

On Tuesday, 14 April 2020 15:16:49 CEST Richard W.M. Jones wrote: > On Tue, Apr 14, 2020 at 12:37:07PM +0200, Pino Toscano wrote: > > > Unfortunately we never free the database. > > > > Hm it is never freed? Wouldn't that result in actual leaks, since > > OsinfoDb_t_finalize (g_object_unref'ing the OsinfoDb) wouldn't be > > called? > > I was

Query libosinfo to get the list of files for drivers of Windows guests, copying them if they are local files only. In case it is not possible (e.g. no driver files are listed, or their location is a non-local URL, or they do not exists), the manual filtering of the virtio-win content is done as before. --- v2v/windows_virtio.ml | 63 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 59

Query libosinfo to get the list of files for drivers of Windows guests, copying them if they are local files only. In case it is not possible (e.g. no driver files are listed, or their location is a non-local URL, or they do not exists), the manual filtering of the virtio-win content is done as before. --- v2v/windows_virtio.ml | 78 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 74

On Fri, Nov 23, 2018 at 02:10:01PM +0100, Martin Kletzander wrote: > On Fri, Nov 23, 2018 at 11:53:05AM +0000, Richard W.M. Jones wrote: > >On Fri, Nov 23, 2018 at 12:39:44PM +0100, Martin Kletzander wrote: > >>There's a standardized libosinfo namespace for libvirt domain metadata. For now > >>it supports the id of the OS only. However that is still a very helpful

There is already a libosinfo reading function located in src folder to get the iso informations. Provide a similar but more generic function to be used in ocaml tools. --- mllib/Makefile.am | 12 ++++++++-- mllib/osinfo.ml | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++++ mllib/osinfo.mli | 21 ++++++++++++++++++ mllib/osinfopath.ml | 1 + 4 files changed, 96 insertions(+), 2

On Tue, Apr 14, 2020 at 12:37:07PM +0200, Pino Toscano wrote: > > Unfortunately we never free the database. > > Hm it is never freed? Wouldn't that result in actual leaks, since > OsinfoDb_t_finalize (g_object_unref'ing the OsinfoDb) wouldn't be > called? I was thinking because of this:

On Fri, Nov 23, 2018 at 12:39:44PM +0100, Martin Kletzander wrote: > There's a standardized libosinfo namespace for libvirt domain metadata. For now > it supports the id of the OS only. However that is still a very helpful feature > that is already supported in gnome-boxes and virt-manager (at least). > > The discussion happened here: > >

There's a standardized libosinfo namespace for libvirt domain metadata. For now it supports the id of the OS only. However that is still a very helpful feature that is already supported in gnome-boxes and virt-manager (at least). The discussion happened here: https://www.redhat.com/archives/libosinfo/2018-September/msg00003.html So let's add the support to local and libvirt outputs.

libswfdec/swfdec_player.c | 3 +++ 1 file changed, 3 insertions(+) New commits: commit f82b818ab4cf2148fafbb9eec5a27622ccd680d7 Author: Benjamin Otte <otte at gnome.org> Date: Sun Oct 14 17:04:21 2007 +0200 lock the player when handling keys ooooops diff --git a/libswfdec/swfdec_player.c b/libswfdec/swfdec_player.c index 32254ab..4980b21 100644 ---