similar to: [RHEL] nbdkit & libnbd for RHEL AV 8.3.0

On Tue, Aug 08, 2023 at 02:36:12PM +0300, Nir Soffer wrote: > On Thu, Aug 3, 2023 at 4:57?AM Eric Blake <eblake at redhat.com> wrote: > > func copy_uint32_array(entries *C.uint32_t, count C.size_t) []uint32 { > > + if (uint64(count) > 64*1024*1024) { > > + panic(\"violation of state machine guarantee\") > > This is unwanted in a library, it

On Wed, Mar 25, 2020 at 10:14:30AM +0000, Daniel P. Berrangé wrote: > On Wed, Mar 25, 2020 at 10:01:02AM +0000, Richard W.M. Jones wrote: > > On Wed, Mar 25, 2020 at 09:48:02AM +0000, Daniel P. Berrangé wrote: > > > On Wed, Mar 25, 2020 at 09:42:19AM +0000, Richard W.M. Jones wrote: > > > > Now runs a complete set of tests, notably including the AIO test. > >

Pipeline #966273140 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 3b6bf865 ( https://gitlab.com/nbdkit/libnbd/-/commit/3b6bf865cd43fd351e49b37d277e308c54aaac0f ) Commit Message: golang: If --disable-golang is used, make sure ... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones )

Document and make it easier for applications to determine which bitmask values were supported at compile time. Also, generating bitmask values in hex tends to be more legible than in decimal, as it makes it obvious that the values are intended for bitwise operations. And it doesn't hurt that this reduces churn in some of the tests if new bits are added. --- docs/libnbd.pod

On Sat, Oct 17, 2020 at 09:00:30AM +0100, Richard W.M. Jones wrote: >On Sat, Oct 17, 2020 at 08:48:40AM +0100, Richard W.M. Jones wrote: >> [Adding libguestfs mailing list] >> >> I reproduced it locally - the difference was installing "gcc-go". >> I only had golang-bin installed previously. With gcc-go installed: >> >> ../run go install

Now that we have a distinct branch in the generator when returning an enum or bitmask that cannot fail, we can use it in Golang for symmetry, so that the result of a get function can be plugged into a set function without a trip through other types. --- generator/GoLang.ml | 12 ++++++------ .../libnbd/libnbd_110_defaults_test.go | 6 +++---

Combine my recent work on improving the generated Go output with Tage's work on using a canonical formatter for Rust. If gofmt is available during the build, then the generated .go files will now use TAB indents and have proper columnar alignment; if it is not available, the project still compiles. Signed-off-by: Eric Blake <eblake at redhat.com> --- Followup to this earlier series:

Pipeline #958658174 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 9cb10b39 ( https://gitlab.com/nbdkit/libnbd/-/commit/9cb10b390e2def9cc7ed744382e5d68e874e1c7a ) Commit Message: golang: Optionally use gofmt on generated .go f... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline

Pipeline #966102131 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 8709285b ( https://gitlab.com/nbdkit/libnbd/-/commit/8709285b6b71eabd71241a3f9edf653f70efb705 ) Commit Message: golang: Skip test using syscall.Select on BSDs ... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones )

This simply compiles, passes tests, but is only able open a handle. This commit does not contain the full bindings. --- Makefile.am | 2 + configure.ac | 32 +++++ generator/GoLang.ml | 116 ++++++++++++++++++ generator/GoLang.mli | 19 +++ generator/Makefile.am

--- generator/GoLang.ml | 336 +++++++++++++++++- .../libnbd/libnbd_200_connect_command_test.go | 35 ++ 2 files changed, 367 insertions(+), 4 deletions(-) diff --git a/generator/GoLang.ml b/generator/GoLang.ml index 1b8f20b..e5fb97c 100644 --- a/generator/GoLang.ml +++ b/generator/GoLang.ml @@ -23,6 +23,304 @@ open Printf open API open Utils +let go_name_of_arg =

Pipeline #958658174 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 9cb10b39 ( https://gitlab.com/nbdkit/libnbd/-/commit/9cb10b390e2def9cc7ed744382e5d68e874e1c7a ) Commit Message: golang: Optionally use gofmt on generated .go f... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline

This simply compiles, passes tests, but is only able open a handle. This commit does not contain the full bindings. --- Makefile.am | 2 + configure.ac | 32 ++++ generator/GoLang.ml | 150 ++++++++++++++++++ generator/GoLang.mli | 19 +++ generator/Makefile.am

On Sat, Oct 17, 2020 at 08:48:40AM +0100, Richard W.M. Jones wrote: > [Adding libguestfs mailing list] > > I reproduced it locally - the difference was installing "gcc-go". > I only had golang-bin installed previously. With gcc-go installed: > > ../run go install libguestfs.org/libnbd > write of Go pointer 0xc000016060 to non-Go memory 0x7f5fe8297390 >

On Sat, Sep 05, 2020 at 08:40:57PM -0500, Eric Blake wrote: > Natural fallout after my recent testsuite additions that fixed a > couple of ocaml bugs in the setters. However, on at least the OCaml > code, I'm not sure what we should do if a newer libnbd ever returns a > bit that an older NBD.mli was not expecting at the time the OCaml > compiler ran (see below). I'm also

On Sat, Oct 17, 2020 at 10:48:13PM +0200, Martin Kletzander wrote: > The list of packages is something I will have to go through anyway, > for not it is just a list taken from libvirt CI container with bunch > of things added for libnbd. Ideally it should be driven from ”dnf builddep libnbd”, directly or indirectly. For golang ... > The ultimate goal with this is to have >

On Wed, Jun 12, 2019 at 04:00:08PM -0500, Eric Blake wrote: > libnbd-0.1.4-1 is now available in Fedora 29/30 updates testing. > > Diffs since v2 - rebase to master, bump from libnbd 0.1.2 to 0.1.3+, > add tests to TLS usage which flushed out the need to turn relative > pathnames into absolute, doc tweaks > > Now that the testsuite covers TLS and libnbd has been fixed to

On 8/13/19 5:36 PM, Richard W.M. Jones wrote: > Change the way that we deal with freeing closures in language > bindings: > > * The valid_flag is removed (mostly reverting > commit 2d9b98e96772e282d51dafac07f16387dadc8afa). > > * An extra ‘free’ parameter is added to all callback structures. This > is called by the library whenever the closure won't be called

On Sat, Oct 17, 2020 at 10:08:26PM +0100, Richard W.M. Jones wrote: >On Sat, Oct 17, 2020 at 10:48:13PM +0200, Martin Kletzander wrote: >> The list of packages is something I will have to go through anyway, >> for not it is just a list taken from libvirt CI container with bunch >> of things added for libnbd. > >Ideally it should be driven from ”dnf builddep libnbd”,

Since Eric's improvements to the command queue in commit 6af72b8 (and following) there's now a queue of commands waiting to be issued stored in the handle, and there's no need to issue commands only from the ready state. We can therefore remove the want_to_send logic, queue as many commands as possible, and don't need to test if the socket is ready for POLLOUT. This commit also