similar to: nbdkit / mingw support

On Tue, Mar 24, 2020 at 01:43:52PM -0500, Eric Blake wrote: > On 3/21/20 7:06 AM, Richard W.M. Jones wrote: > >Eric: > > > >Yifan Gu has posted a few patches for mingw support. My comments > >below. > > > >https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca > > > >* I think the SHARED_LDFLAGS idea is good. I pushed a

I pushed a few of the msys2 patches upstream. I changed the way that $(SHARED_LDFLAGS) works so it's more to my liking, and the others were pushed unchanged. Three patches remain which I'm posting on the mailing list for proper review. Rich.

Answering a few questions: * Unclear why it's necessary to rename nbdkit-common.h -> nbdkit-compat.h - It's not a rename, but a new file. nbdkit-compat.h is included for PE DLL compatibility, and is included in nbdkit-common.h * Functions are indirected through struct nbdkit_functions _nbdkit_functions which I guess is necessary because of PE linking (we've had similar

From: Yifan Gu <gyf304@gmail.com> Windows PE DLL needs function indirection, this patch injects API functions for plugins / filters if on Windows. Note that nbdkit_peer_name is explicitly disabled due to potential ABI incompatibilities. --- server/main.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/server/main.c b/server/main.c

On Mon, Mar 23, 2020 at 12:28:12PM +0000, Richard W.M. Jones wrote: > From: Yifan Gu <gyf304@gmail.com> > > The create_nbdkit_module function is intended to be exported, therefore > the static keyword is not needed and prevents building on MSYS2. > --- > plugins/python/python.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

From: Yifan Gu <gyf304@gmail.com> This patch adds in indirection for API functions, as PE DLL loader does not resolve undefined symbols. This patch only includes header changes. --- include/nbdkit-common.h | 133 +++++++++++++++++++++++++++++++++++++++- include/nbdkit-compat.h | 97 +++++++++++++++++++++++++++++ include/nbdkit-filter.h | 39 ++++++++++++ include/nbdkit-plugin.h | 27

I think that will break the ABI backward compatibility. On Tue, Mar 24, 2020 at 15:16 Eric Blake <eblake@redhat.com> wrote: > On 3/24/20 1:54 PM, Richard W.M. Jones wrote: > > On Tue, Mar 24, 2020 at 01:43:52PM -0500, Eric Blake wrote: > >> On 3/21/20 7:06 AM, Richard W.M. Jones wrote: > >>> Eric: > >>> > >>> Yifan Gu has posted a few

On 3/21/20 7:06 AM, Richard W.M. Jones wrote: > Eric: > > Yifan Gu has posted a few patches for mingw support. My comments > below. > > https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca > > * I think the SHARED_LDFLAGS idea is good. I pushed a slightly > different take on the idea here: >

On 3/24/20 1:54 PM, Richard W.M. Jones wrote: > On Tue, Mar 24, 2020 at 01:43:52PM -0500, Eric Blake wrote: >> On 3/21/20 7:06 AM, Richard W.M. Jones wrote: >>> Eric: >>> >>> Yifan Gu has posted a few patches for mingw support. My comments >>> below. >>> >>>

On Tue, Mar 24, 2020 at 02:16:32PM -0500, Eric Blake wrote: > On 3/24/20 1:54 PM, Richard W.M. Jones wrote: > >On Tue, Mar 24, 2020 at 01:43:52PM -0500, Eric Blake wrote: > >>On 3/21/20 7:06 AM, Richard W.M. Jones wrote: > >>>Eric: > >>> > >>>Yifan Gu has posted a few patches for mingw support. My comments > >>>below. >

The patches following do indeed allow you to compile nbdkit.exe, but it does not actually work yet. I'm posting this experimental series more as a work in progress and to get feedback. Note this does not require Windows itself to build or test. You can cross-compile it using mingw64-* packages on Fedora or Debian, and test it [spoiler alert: it fails] using Wine. Rich.

From: Yifan Gu <gyf304@gmail.com> The create_nbdkit_module function is intended to be exported, therefore the static keyword is not needed and prevents building on MSYS2. --- plugins/python/python.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/python/python.c b/plugins/python/python.c index a1a0438b..adc1aaa5 100644 --- a/plugins/python/python.c +++

The error is the following libtool: link: (cd .libs/nbdkit-perl-plugin.lax/libutils.a && ar x "/c/Users/yifangu/Documents/devel/nbdkit/plugins/perl/../../common/utils/.libs/libutils.a") libtool: link: ar cru .libs/nbdkit-perl-plugin.a .libs/nbdkit_perl_plugin_la-perl.o .libs/nbdkit-perl-plugin.lax/libutils.a/libutils_la-cleanup-nbdkit.o

This creates libnbdkit.so as discussed in the following thread: https://www.redhat.com/archives/libguestfs/2020-March/thread.html#00203 test-delay-shutdown.sh fails for unclear reasons. This series starts by reverting "tests: Don't strand hung nbdkit processes" which is because several other tests fail randomly unless I revert this patch. I didn't investigate this yet so it

These two commits add new APIs and enhance nbdkit-ip-filter to allow filtering of Unix domain sockets by the client's PID, UID or GID. eg: nbdkit -U sock --filter=ip ... allow=uid:`id -u` deny=all Rich.

On Sat, Mar 21, 2020 at 12:06:15PM +0000, Richard W.M. Jones wrote: > https://github.com/gyf304/nbdkit/commit/20d888fbb8ccf33f0975a070df0d8e3d929b71f8 > > * Is there no way to get the socket peer on Windows? And assuming there's no way to get the socket peer, then the function shouldn't be NULL (which will cause a segfault), but instead you should make the function return an

v2 was here: https://www.redhat.com/archives/libguestfs/2020-October/msg00019.html v3: * defence -> defense * Use int64_t instead of int. This compiles on Windows. * Add GC wrappers to OCaml bindings. * New FreeBSD patch. * Removed "pid:" example from the ip filter manual, and added a warning beside the pid documentation. Rich.

This series is based on my blog posting here: https://rwmj.wordpress.com/2019/09/13/nbdkit-supports-exportnames/ It depends on the fix for realloc: https://www.redhat.com/archives/libguestfs/2019-September/thread.html#00103 This series adds a fun plugin, and also an semi-related feature I've long thought to be desirable. You can consider patches 1 & 4, and patches 2 & 3 as forming

On 3/24/20 3:12 PM, Eric Blake wrote: >> (For non-mingw platforms) this breaks the source API promises rather >> seriously, so if I understand your proposal correctly I don't think >> this is a good idea.  It's possibly something we can consider for >> internal plugins, or for the V3 API. > > How does it break API to request that someone link against a

This is just a simple update to: https://www.redhat.com/archives/libguestfs/2020-October/msg00015.html rebased on top of current nbdkit master because I pushed a few simple refactorings. Rich.