similar to: [nbdkit PATCH v2] eval: Rebuild hard link if git breaks it

Commit 39b40750dd works if you use 'make clean', but not if you rely on incremental builds. Git likes to update files by creating new inodes, which strands hard links. We could either use symlinks, or as done here, add a dependency to force the hard links to be rebuilt as needed. Fixes: 45b4877fde Signed-off-by: Eric Blake <eblake@redhat.com> --- plugins/eval/Makefile.am | 4 ++--

Neutral refactoring. Makes the code a bit easier to handle and simplifies future commits. --- plugins/tmpdisk/Makefile.am | 17 ++++++++- plugins/tmpdisk/tmpdisk.c | 22 +++--------- plugins/tmpdisk/default-command.sh.in | 51 +++++++++++++++++++++++++++ .gitignore | 1 + 4 files changed, 72 insertions(+), 19 deletions(-) diff --git

This change adds an explicit dependency on generator.ml for every file it generates, except java files. Java is left for another time because it's considerably trickier. This fixes parallel make, and will automatically re-create generated files when make is run from any directory. It also fixes the problem which efad4f53 was targetting. Specifically, src/guestfs_protocol.(c|h) had an

On 12/6/18 3:50 PM, Richard W.M. Jones wrote: > --- > src/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/Makefile.am b/src/Makefile.am > index 3490c0f..65f9498 100644 > --- a/src/Makefile.am > +++ b/src/Makefile.am > @@ -80,6 +80,7 @@ nbdkit_LDFLAGS = \ > # synopsis.c is generated from docs/synopsis.txt where it is also > # used to

As discussed on IRC. The naming conventions aren't ideal, but the intent feels right and it works for me. J -- /--------------------------------------------------------------------------\ James Aylett xapian.org james at tartarus.org uncertaintydivision.org -------------- next part -------------- Index:

This commit, which is just code motion, moves the common XDR protocol code (libprotocol) and the common errno handling (liberrnostring) into libraries which are each built once and shared between the library and daemon. --- .gitignore | 20 +++++-------- Makefile.am | 1 + common/errnostring/Makefile.am | 45 +++++++++++++++++++++++++++++

Hi all, I've previously posted this patch on llvm-commits, but due to a lack of replies, and the fact that this patch is more something to discuss than something to apply, I'm posting this again here. While working on my own backend, I found that things got really messy real quickly, partly caused by the fact that all .cpp files must be in the same directory (lib/Target/TargetName).

If you're on the new Makefile system, you will want to update your Makefile.rules. The patch below provides some important fixes for parallel builds and dependencies. It also adds some new features like the -local targets. For example, you can now build "all-local" to build the local directory without recursing into subdirectories. See the comments below for details of the change.

If configured with --without-ocaml, the build might fail because the fix added in df5bd5741b37da9cf97d7a76ac2805557aa630db was not active. According to the automake documentation, it should be enough to set BUILT_SOURCES. --- builder/Makefile.am | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/builder/Makefile.am b/builder/Makefile.am index e3d37667b..3c7113eee 100644

Parallel make was failing because guestfs-structs.h was required before generator.ml ran. --- src/Makefile.am | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 469f6d6..ae10ed8 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -34,8 +34,6 @@ stamp-generator: generator.ml mkdir -p $(top_srcdir)/java/com/redhat/et/libguestfs

This generates small functions which map from various integer NBD protocol flags to the string equivalent. eg: name_of_nbd_cmd (NBD_CMD_READ) ---> "NBD_CMD_READ" This commit uses some hairy sed scripting to ensure that we don't add any more dependencies to nbdkit. --- src/protocol.h | 9 +++++++ .gitignore | 1 + src/Makefile.am | 17

configure.ac | 2 +- vivified/core/Makefile.am | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) New commits: diff-tree b319db3cbe2ce11e2d2edcf27ad44d28fa22de47 (from 08aafab0c67c5db6f1784a6da2c421b58d4474d6) Author: Benjamin Otte <otte at gnome.org> Date: Fri Aug 24 14:14:19 2007 +0200 include vivi_marshal.list diff --git a/vivified/core/Makefile.am

libswfdec/Makefile.am | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) New commits: commit 66095ac2692402646afcc0732c13dc4b3996433d Author: Benjamin Otte <otte at gnome.org> Date: Mon Dec 3 16:46:24 2007 +0100 fix non-srcdir builds from autogen'd sources diff --git a/libswfdec/Makefile.am b/libswfdec/Makefile.am index aad0e05..d5cf0da 100644 ---

This way they can be properly shipped also when creating a distribution tarball ('make dist') from a build configured with --disable-appliance. --- p2v/Makefile.am | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/p2v/Makefile.am b/p2v/Makefile.am index e0b194c29..4e2405e9d 100644 --- a/p2v/Makefile.am +++ b/p2v/Makefile.am @@ -25,7 +25,7 @@ BUILT_SOURCES = \

--- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index 3490c0f..65f9498 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -80,6 +80,7 @@ nbdkit_LDFLAGS = \ # synopsis.c is generated from docs/synopsis.txt where it is also # used to generate the man page. It is included in main.c. +BUILT_SOURCES = synopsis.c EXTRA_DIST = synopsis.c

>From 9e99a1c6cb655a56d7f09dabd10a77a3802bf96d Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 17 Aug 2009 18:44:37 +0200 Subject: [PATCH libguestfs 1/2] avoid compiler warnings about unused vars in generated code * src/Makefile.am: Compile protocol.c into a convenience library, so it can have its own CFLAGS, and link that with the destination one. ---

On Fri, Dec 07, 2018 at 10:00:42AM -0600, Eric Blake wrote: > Use new 'name_of_*' functions to offer a bit more details about > messages being forwarded on to the remote server. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > plugins/nbd/nbd.c | 8 +++++--- > plugins/nbd/Makefile.am | 3 ++- > 2 files changed, 7 insertions(+), 4 deletions(-)

configure.ac | 2 +- src/Makefile.am | 5 +++-- src/plugin.c | 26 ++++++++++++++++++++++---- 3 files changed, 26 insertions(+), 7 deletions(-) New commits: commit ca13a1daef653a80e89250e273496ca01dfccddd Author: Benjamin Otte <otte at gnome.org> Date: Tue Nov 6 21:29:54 2007 +0100 make sure the plugin is never unloaded (#13110, reported by Tom Parker) It seems

Use new 'name_of_*' functions to offer a bit more details about messages being forwarded on to the remote server. Signed-off-by: Eric Blake <eblake@redhat.com> --- plugins/nbd/nbd.c | 8 +++++--- plugins/nbd/Makefile.am | 3 ++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/plugins/nbd/nbd.c b/plugins/nbd/nbd.c index 672f35b..6bd8861 100644 ---

--- mllib/Makefile.am | 2 +- src/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mllib/Makefile.am b/mllib/Makefile.am index 0e317b2..ec624c9 100644 --- a/mllib/Makefile.am +++ b/mllib/Makefile.am @@ -18,7 +18,7 @@ include $(top_srcdir)/subdir-rules.mk EXTRA_DIST = \ - $(SOURCES) + $(filter-out config.ml.in,$(SOURCES)) CLEANFILES = *~ *.cmi *.cmo *.cmx