similar to: Re: Use libguestfs with SAS URI of a disk image

On Fri, Mar 13, 2020 at 09:41:37PM +0000, JP Zhang wrote: > Hi Richard, > > Thanks for the great work you did on libguestfs. > > I try to call libguestfs lib API directly in C to "add drive" by > using a Azure blob storage access SAS URI, which has shared access > token/secret on the URL. > > The URL likes like this: >

The existing --run '$nbd' outputs an older form that differs between libguestfs and qemu, and which is not always a valid URI. For historical compatibility, we probably can't change that; but we can instead add a new '$uri' that outputs a valid URI. Note that the libguestfs '$nbd' TCP form is already a valid URI (at least, as long as the user isn't exploiting

On Tue, Jun 25, 2019 at 09:35:11PM -0500, Eric Blake wrote: > The existing --run '$nbd' outputs an older form that differs between > libguestfs and qemu, and which is not always a valid URI. For > historical compatibility, we probably can't change that; but we can > instead add a new '$uri' that outputs a valid URI. Note that the > libguestfs '$nbd' TCP

The existing --run '$nbd' outputs an older form that differs between libguestfs and qemu, and which is not always a valid URI. For historical compatibility, we probably can't change that; but we can instead add a new '$uri' that outputs a valid URI. Note that the libguestfs '$nbd' TCP form is already a valid URI, but that libguestfs still needs to be taught about the

Now that kernels support vsock loopback, we have no reason to forbid --vsock with --run. Signed-off-by: Eric Blake <eblake@redhat.com> --- I'm hoping to commit something like this, but right now, the testsuite is failing more times than it succeeds, with: + port=1082294412 + nbdkit --vsock --port 1082294412 memory 1M --run 'sleep 1; nbdsh -u "$uri" -c

--- docs/nbdkit-captive.pod | 4 ++-- docs/nbdkit-plugin.pod | 2 +- docs/nbdkit-service.pod | 2 +- docs/nbdkit-tls.pod | 2 +- filters/cow/nbdkit-cow-filter.pod | 4 ++-- filters/delay/nbdkit-delay-filter.pod | 2 +- filters/error/nbdkit-error-filter.pod | 6 +++---

--- docs/nbdkit-captive.pod | 4 ++-- docs/nbdkit-plugin.pod | 2 +- docs/nbdkit-service.pod | 2 +- docs/nbdkit-tls.pod | 2 +- filters/cow/nbdkit-cow-filter.pod | 4 ++-- filters/delay/nbdkit-delay-filter.pod | 2 +- filters/error/nbdkit-error-filter.pod | 6 +++---

While we are unlikely to change our decision that -e should not control our response to NBD_OPT_LIST (because we intend to add a new callback .extents_list for that), it turns out that it is a lot easier to write: nbdkit -U - -e foo info --run 'nbdsh -u "$uri" -c "print(h.pread(3, 0))"' than it is to write the equivalent: nbdkit -U - info --run 'nbdsh -u

Since v1: - new patch to add uri_quote() - rebase on top of other recent patches needed while auditing shell_quote() - use uri_quote() instead of shell_quote() for producing $uri Eric Blake (2): common/utils: Add uri_quote and tests captive: Support $uri in --run docs/nbdkit-captive.pod | 8 ++- common/utils/utils.h | 1 + common/utils/test-quotes.c | 108

This parameter provided a name for the "default export" -- ie. the one and only export returned to the client by NBD_OPT_LIST. But nbdkit traditionally didn't care what export name the client requested. Since 1.16 plugins have been able to serve different content per export name (and return errors for unknown exports), but the -e option didn't reflect that and only created

This filter can be used to open tar files. It uses the technique first suggested by Eric Blake here: https://www.redhat.com/archives/libguestfs/2020-July/msg00017.html We suggest that nbdkit-tar-plugin is deprecated in nbdkit 1.26, but it might happen later. --- docs/nbdkit-captive.pod | 4 +- filters/offset/nbdkit-offset-filter.pod | 2 +- filters/tar/nbdkit-tar-filter.pod

In tests/test-eval.sh we have a test which looks something like this: nbdkit eval close='echo closed > file' --run 'qemu-img info $nbd' if ! grep 'closed' file; then fail; fi However there was a race condition here. nbdkit exits when the --run command exits without waiting for the captive nbdkit subprocess. Thus we couldn't be sure that the final

(apologies if you see this twice, forgot the CC the first time) In data venerdì 26 giugno 2015 18:50:16, Gabriel Hartmann ha scritto: > > > > > By default, when saving a URI using xmlSaveUri it escapes everything in > > the URI. QEMU doesn't want anything escaped, so now I unescape > > everything after the URI is generated. Unfortunately there's no flag to

This essentially turns the whole of nbdkit into a library. There is a rump nbdkit program left which simply contains a main() function that forwards to the nbdkit_main() function in the library. The reason for this is to allow nbdkit to be compiled on Windows, because Windows does not allow shared libraries to contain any undefined symbols. nbdkit previously relied on undefined symbols in all

Test the just-fixed bug in --run failing to detect an nbdkit assertion failure. While at it, sleep less when we don't actually need to wait for the socket to be opened. Signed-off-by: Eric Blake <eblake@redhat.com> --- tests/test-captive.sh | 46 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/tests/test-captive.sh

When running captive, we were blindly calling kill(pid) of the captive nbdkit child process and ignoring failures, even if that process has already exited unexpectedly (most likely, from an assertion failure). Thankfully, because we did not wait on the process, we are guaranteed that the nbdkit child process is either still running or in zombie state, so no other process can recycle the pid yet.

When running captive, we were blindly calling kill(pid) of the captive nbdkit child process, even if that process has already exited unexpectedly (most likely, from an assertion failure) and another opened in its place (pid recycling is rare, but not impossible). We need to check that the child process still exists, and if it unexpectedly died, ensure that our exit status reflects that fact. Note

On Mon, Sep 30, 2019 at 12:15:42PM -0500, Eric Blake wrote: > Test the just-fixed bug in --run failing to detect an nbdkit assertion > failure. > > While at it, sleep less when we don't actually need to wait for the > socket to be opened. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > tests/test-captive.sh | 46

Here's my solution, as a nbdkit plugin written in Perl. As with Max's solution I don't bother to parse the virtual size out of the XML file, so you need to specify that on the command line otherwise the disk will be truncated to the largest extent stored in the file. Also the ‘.xva’ file must not be compressed. $ nbdkit perl script=./xva-reader.pl file=./debian8cloud.xva

When parsing the URI, drop the leading '/' from the path also when the protocol is 'nbd': in this case, the path represents the export name, which does not need the '/' coming from the URI format. Improve the coverage for nbd in test-add-uri.sh, adding a couple of tests, and adjusting the result of an existing one. --- fish/test-add-uri.sh | 8 +++++++- fish/uri.c